[jira] Created: (OFBIZ-884) Service to check if image URLs exist

[Nicolas Malin (Jira)]

Service to check if image URLs exist
------------------------------------

                 Key: OFBIZ-884
                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
             Project: OFBiz (The Open for Business Project)
          Issue Type: New Feature
    Affects Versions: SVN trunk
            Reporter: Ashish Vijaywargiya
            Priority: Trivial
         Attachments: ImageURL.patch

Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
Check  for all images - if it must be for only local ones - that's Ok too.
If URL's not exists in local machine then update the categories/product's URL field values to null.

Regards
Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-884:
--------------------------------------

    Attachment: ImageURL.patch

> Service to check if image URLs exist
> ------------------------------------
>
>                 Key: OFBIZ-884
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>            Priority: Trivial
>         Attachments: ImageURL.patch
>
>
> Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
> Check  for all images - if it must be for only local ones - that's Ok too.
> If URL's not exists in local machine then update the categories/product's URL field values to null.
> Regards
> Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ruppert reassigned OFBIZ-884:
---------------------------------

    Assignee: Tim Ruppert

> Service to check if image URLs exist
> ------------------------------------
>
>                 Key: OFBIZ-884
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>         Assigned To: Tim Ruppert
>            Priority: Trivial
>         Attachments: ImageURL.patch
>
>
> Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
> Check  for all images - if it must be for only local ones - that's Ok too.
> If URL's not exists in local machine then update the categories/product's URL field values to null.
> Regards
> Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-884:
--------------------------------------

    Attachment: imageUrlExternal.patch

Here is the patch that will handle the External Image URL support.
But its not working.

Can anybody of you give some pointers ??

Ashish

> Service to check if image URLs exist
> ------------------------------------
>
>                 Key: OFBIZ-884
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>         Assigned To: Tim Ruppert
>            Priority: Trivial
>         Attachments: ImageURL.patch, imageUrlExternal.patch
>
>
> Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
> Check  for all images - if it must be for only local ones - that's Ok too.
> If URL's not exists in local machine then update the categories/product's URL field values to null.
> Regards
> Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-884:
--------------------------------------

    Attachment: imageUrlExternal_2.patch

Change the string comparision from http:// to http.
And same is done for ftp and https.

Regards
Ashish Vijaywargiya

> Service to check if image URLs exist
> ------------------------------------
>
>                 Key: OFBIZ-884
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>         Assigned To: Tim Ruppert
>            Priority: Trivial
>         Attachments: ImageURL.patch, imageUrlExternal.patch, imageUrlExternal_2.patch
>
>
> Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
> Check  for all images - if it must be for only local ones - that's Ok too.
> If URL's not exists in local machine then update the categories/product's URL field values to null.
> Regards
> Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-884:
-------------------------------

    Attachment: imageUrl.patch

Updated patch for Image url checks.

> Service to check if image URLs exist
> ------------------------------------
>
>                 Key: OFBIZ-884
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>         Assigned To: Tim Ruppert
>            Priority: Trivial
>         Attachments: imageUrl.patch, ImageURL.patch, imageUrlExternal.patch, imageUrlExternal_2.patch
>
>
> Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
> Check  for all images - if it must be for only local ones - that's Ok too.
> If URL's not exists in local machine then update the categories/product's URL field values to null.
> Regards
> Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ruppert closed OFBIZ-884.
-----------------------------

    Resolution: Fixed

Thanks Anil and Ashish - this is in rev 528829.

Btw, upon further reflection, what might be nice is to update the setAllProductImageNames to use logic similar to this so that it doesn't actually default the names of images that do not exist.  I will make an issue for this shortly

> Service to check if image URLs exist
> ------------------------------------
>
>                 Key: OFBIZ-884
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-884
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>         Assigned To: Tim Ruppert
>            Priority: Trivial
>         Attachments: imageUrl.patch, ImageURL.patch, imageUrlExternal.patch, imageUrlExternal_2.patch
>
>
> Run thru all categories & products (virtual and variant) and check each of the image URLs to see if they actually exist.
> Check  for all images - if it must be for only local ones - that's Ok too.
> If URL's not exists in local machine then update the categories/product's URL field values to null.
> Regards
> Ashish

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.