[jira] Created: (OFBIZ-885) Multiple issuances, one tax item on invoice
Locked
[jira] Created: (OFBIZ-885) Multiple issuances, one tax item on invoice
 
|
Multiple issuances, one tax item on invoice
------------------------------------------- Key: OFBIZ-885 URL: https://issues.apache.org/jira/browse/OFBIZ-885 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: accounting Reporter: Iain Fogg Priority: Critical I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. On the invoice I can see entries for: (a) 2 x item X (b) tax on 2 x item X (c)1 x item X (d) 1 x item X (no tax on the last 2 items) Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. This is a bug, right? (that's a rhetorical question :-) Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488666 ] Iain Fogg commented on OFBIZ-885: --------------------------------- Looking at this some more... Why the heck does createInvoiceForOrder bother to check how much of an adjustment is already invoiced? It looks like the adjustment amount (from the ORDER) is being correctly prorated according to the quantity in the BILLING ITEM. I can see that the intent might be to prevent some corner case (?) from invoicing a total adjustment amount greater than the order adjustment amount, but I can't imagine what that corner case might be. The only thing I can think is if we allowed more product to be issued than was ordered, but I still don't see why there is code to limit this in the invoice generation - if that oversupply is not allowed, that should be prevented further upstream. I'm also concerned that with rounding, the intention of createInvoiceForOrder to prevent invoicing adjustment amounts greater than the order amount might prevent an invoice item from being generated. I still think this is a bug since the function isn't comparing cumulative adjustment totals to a "target" total (from the order), but I'm looking forward to a more knowledgeable people either confirming it or setting me straight. Cheers, Iain > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488675 ] Jacopo Cappellato commented on OFBIZ-885: ----------------------------------------- Iain, could you please have a look at the content of the OrderAdjustmentBilling entity? What are the numbers in it? Jacopo > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
Jacopo,
Will do. I'm out of commission until Sunday night, but will follow up as soon as I can. Cheers, Iain Jacopo Cappellato (JIRA) wrote: > [ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488675 ] > > Jacopo Cappellato commented on OFBIZ-885: > ----------------------------------------- > > Iain, > > could you please have a look at the content of the OrderAdjustmentBilling entity? What are the numbers in it? > > Jacopo > > > > > >> Multiple issuances, one tax item on invoice >> ------------------------------------------- >> >> Key: OFBIZ-885 >> URL: https://issues.apache.org/jira/browse/OFBIZ-885 >> Project: OFBiz (The Open for Business Project) >> Issue Type: Bug >> Components: accounting >> Reporter: Iain Fogg >> Priority: Critical >> >> I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. >> When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. >> On the invoice I can see entries for: >> (a) 2 x item X >> (b) tax on 2 x item X >> (c)1 x item X >> (d) 1 x item X >> (no tax on the last 2 items) >> Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. >> Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). >> It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. >> This is a bug, right? (that's a rhetorical question :-) >> Cheers, Iain >> > > -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.5.446 / Virus Database: 269.4.0/759 - Release Date: 12/04/2007 7:58 PM |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489112 ] Iain Fogg commented on OFBIZ-885: --------------------------------- Jacopo, There are 2 entries in OrderAdjustmentBilling. The first is item (b) on my post above. The second is a tax adjustment for another product Y on the order. Does this help pinpoint where the problem might be? Regards, Iain > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489114 ] Jacopo Cappellato commented on OFBIZ-885: ----------------------------------------- Iain, is the amount in the OrderAdjustmentBilling the same of the tax adjustment in the Invoice? > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489144 ] Iain Fogg commented on OFBIZ-885: --------------------------------- Jacopo, Yes it is. Specifically, it is the tax calculated on 2x item X. There is no entry for the other 2 individual instances of item X. Cheers, Iain > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489154 ] Jacopo Cappellato commented on OFBIZ-885: ----------------------------------------- Iain, I reviewed that part of the invoice service and I think it is doing things in the right way. I tried to recreate the issue in my local box but everything seems to work fine. Could you try to recreate the issue in the demo server: https://demo.hotwaxmedia.com/catalog/control/main ? Jacopo > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489359 ] Iain Fogg commented on OFBIZ-885: --------------------------------- Jacopo, Ug. I need to spend some more time getting a clean example going on the sandbox server. I made the mistake of setting up all the tax codes etc, and then selecting the Tiny Gizmo as my sample product, but with everyone playing inventory is all over the place :-) Will attempt again ASAP. Cheers, Iain PS. I like a lot of the cosmetic changes that have been implemented recently. PPS. Check out order number WS10131. I first issues 2 items to the shipment, then issued 1, then issued 1, and it looks like the system has decided to add 12 to the inventory (I ordered 4). Looks like a bug, but totally unrelated to the one I'm trying to demonstrate. -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.5.446 / Virus Database: 269.4.0/762 - Release Date: 15/04/2007 4:22 PM > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489393 ] Jacopo Cappellato commented on OFBIZ-885: ----------------------------------------- Iain, about WS10131: it is strange... but that is a purchase order... what were you trying to do? > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489414 ] Iain Fogg commented on OFBIZ-885: --------------------------------- Jacopo, Yes it is a PO. To be honest, I'm not sure what I was trying to do, but it was curious that it highlighted this odd behaviour. In the normal course of operations, I issue less than the order quantity of an item all the time (assuming my supplier shipped me less than the order quantity), but of course, once I issue the items I receive them into inventory. In this case, I issued 2, then 1, then 1 without Receiving in between. I'm not saying this was necessarily sensible, but I wouldn't have expected the odd behaviour either. Maybe something of low priority... Cheers, Iain -- No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.5.446 / Virus Database: 269.4.0/759 - Release Date: 12/04/2007 7:58 PM > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489415 ] Jacopo Cappellato commented on OFBIZ-885: ----------------------------------------- Iain, yes, it would be great if you could create a Jira issue because you have definitely found something wrong. Jacopo > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-885: --------------------------------------- Assignee: Jacopo Cappellato > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Assigned To: Jacopo Cappellato > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493605 ] Scott Gray commented on OFBIZ-885: ---------------------------------- Just a note to say I tried recreating issue as well and everything worked fine (except for tax calculation, but that's another story). Perhaps we should look at downgrading the priority on this until we can get a set of steps to reproduce? > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Assigned To: Jacopo Cappellato > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Resolved: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato resolved OFBIZ-885. ------------------------------------- Resolution: Cannot Reproduce It seems that this issue has been fixed some time ago and cannot be recreated in trunk and in the release branch 4.0. > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Assigned To: Jacopo Cappellato > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-885) Multiple issuances, one tax item on invoice
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-885. ----------------------------------- > Multiple issuances, one tax item on invoice > ------------------------------------------- > > Key: OFBIZ-885 > URL: https://issues.apache.org/jira/browse/OFBIZ-885 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Iain Fogg > Assigned To: Jacopo Cappellato > Priority: Critical > > I have a couple of sales orders, and through the course of picking/packing multiple item issuances from different inventory items were generated for the order. Eg, customer orders 4 of item X, and we issued 2+1+1 items from inventory as they came into stock. > When I pack the order, and generate the invoice, a tax adjustment is created for only one of the issuances, and consequently total tax is being wrongly reported on the invoice. > On the invoice I can see entries for: > (a) 2 x item X > (b) tax on 2 x item X > (c)1 x item X > (d) 1 x item X > (no tax on the last 2 items) > Both invoices that exhibit this problem have the same characteristic - multiple issuances for a single product id. > Has anyone else seen this, or can point at a fix? I suspect the problem is in .../accounting.../InvoiceServices.java (createInvoiceForOrder). > It looks like when the invoice items are being generated it is trying to work out when NOT to create another invoice adjustment by comparing the adjAlreadyInvoicedAmount to the amount of "this" adjustment. In my example, when it processes the adjustment for (c) above, it sees that we've already invoiced for 1/2 the total tax adjustment (b), and the this is greater than the tax adjustment for (c), so happily "continue"s to the next adjustment. > This is a bug, right? (that's a rhetorical question :-) > Cheers, Iain -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |