[jira] Created: (OFBIZ-890) OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms

[Nicolas Malin (Jira)]

OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-890
                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: accounting, order
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Priority: Trivial
             Fix For: SVN trunk


If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
It's a very small bug and probably there is no-one that use this functionality.
I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-890:
---------------------------------

    Attachment: itemSeqNum.patch

This is the patch to correct this very little bug

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488900 ]

Scott Gray commented on OFBIZ-890:
----------------------------------

Hi Marco

I don't think this patch is the correct approach because the orderItemSeqId field is there to relate individual order items to an order term.  It looks like the data model doesn't support what you are trying to do.

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-890:
---------------------------------

    Attachment: OFBiz_ Web Tools_ Find Values.pdf

This is what happen after check out the purchase order.
See my mail for my suggestion on the dev mailing list:

Probably in my opinion is enough to add the foreign key to the AgreementTerm (agreementTermId) and also removed the redundant fields termValue, termDays, description (directly retrieved from the new foreign key) for the entity BillingAccountTerm, InvoiceTerm, OrderTerm, QuoteTerm.
We have to think about also to change the PK of those entities (now is termTypeId, orderId, orderItemSeqId)

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch, OFBiz_ Web Tools_ Find Values.pdf
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-890:
---------------------------------

    Attachment: OFBiz_ Order Manager_ View Order.pdf

This is the screenshoot of the purchase order created .

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch, OFBiz_ Order Manager_ View Order.pdf, OFBiz_ Web Tools_ Find Values.pdf
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-890:
---------------------------------

    Attachment: itemSeqNum2.patch

I have add to the following entities the field SeqId (ex. orderTermSeqId) :
OrderTerm,
OrderTermAttribute,
InvoiceTerm,
BillingAccountTerm,
QuoteTerm,
QuoteTermAttribute.

As discussed into the dev mailing list I upload this patch for this new fields.
Once everything is ok I will also add the others two field to the Payment entity.

Thanks
Marco

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch, itemSeqNum2.patch, OFBiz_ Order Manager_ View Order.pdf, OFBiz_ Web Tools_ Find Values.pdf
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493076 ]

Marco Risaliti commented on OFBIZ-890:
--------------------------------------

Please do not apply this patch because contains wrong entity definition.
I will provide  a new patch as quickly I can.
I'm sorry for the mistake.

Thanks
Marco

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch, itemSeqNum2.patch, OFBiz_ Order Manager_ View Order.pdf, OFBiz_ Web Tools_ Find Values.pdf
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-890.
--------------------------------

    Resolution: Later

For the moment I will close this issue because I have not the time to work on it and in this issue remains the notes and a draft-patch for this issue.
When I will have the time and interest to work on it I will open a new issue.

Thanks
Marco

> OrderTerm/InvoiceTerm for Sales Order are not correctly stored if there are more than one term days specified on the agreement terms
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-890
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-890
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: itemSeqNum.patch, itemSeqNum2.patch, OFBiz_ Order Manager_ View Order.pdf, OFBiz_ Web Tools_ Find Values.pdf
>
>
> If I create an agreement within admin user and Company organization for sales order when I try to create an order on the backend and selecting this agreement then the OrderTerms and the InvoiceTerms are not correctly stored.
> The fields orderItemSeqId/invoiceItemSeqId are filled with the value "N/A" and so if we have two term days specified on the agreement only the last one is store on the OrderTerms/InvoiceTerms because orderItemSeqId is part of the primary key.
> I have created a patch that fill the orderItemSeqId/invoiceItemSeqId fields with a sequencial number.
> It's a very small bug and probably there is no-one that use this functionality.
> I have seen it because I'm trying to understand how to create an payment aging for OFBIZ.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.