[jira] Created: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Nicolas Malin (Jira)
Deprecated operations replaced by set operations in PromoServices.xml
---------------------------------------------------------------------

                 Key: OFBIZ-90
                 URL: http://issues.apache.org/jira/browse/OFBIZ-90
             Project: The Open For Business Project
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: PromoServices.xml.patch

Hi commiters,

I'm not completly sure of this patch. Please review it.  I only  tested createProductPromo service
As references I used
http://incubator.apache.org/ofbiz/docs/minilang.html which is now deprecated,
Oxygen popup annotations and
http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd.


The inconvenient with this is that there is no semantic in http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd and you are never sure (though almost) of what you do.
Is somewhere an updated documentation that I did not found ? Else may the http://incubator.apache.org/ofbiz/docs/minilang.html document been updated one day ? I'm OK to do some work about but I'm not sure of what to do...

Jacques

Thanks

Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-90?page=all ]

Jacques Le Roux updated OFBIZ-90:
---------------------------------

    Attachment: PromoServices.xml.patch

> Deprecated operations replaced by set operations in PromoServices.xml
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-90
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-90
>             Project: The Open For Business Project
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: PromoServices.xml.patch
>
>
> Hi commiters,
> I'm not completly sure of this patch. Please review it.  I only  tested createProductPromo service
> As references I used
> http://incubator.apache.org/ofbiz/docs/minilang.html which is now deprecated,
> Oxygen popup annotations and
> http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd.
> The inconvenient with this is that there is no semantic in http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd and you are never sure (though almost) of what you do.
> Is somewhere an updated documentation that I did not found ? Else may the http://incubator.apache.org/ofbiz/docs/minilang.html document been updated one day ? I'm OK to do some work about but I'm not sure of what to do...
> Jacques
> Thanks
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-90?page=all ]

Jacques Le Roux resolved OFBIZ-90.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

This is done in svn 429001.

> Deprecated operations replaced by set operations in PromoServices.xml
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-90
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-90
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: PromoServices.xml.patch
>
>
> Hi commiters,
> I'm not completly sure of this patch. Please review it.  I only  tested createProductPromo service
> As references I used
> http://incubator.apache.org/ofbiz/docs/minilang.html which is now deprecated,
> Oxygen popup annotations and
> http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd.
> The inconvenient with this is that there is no semantic in http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd and you are never sure (though almost) of what you do.
> Is somewhere an updated documentation that I did not found ? Else may the http://incubator.apache.org/ofbiz/docs/minilang.html document been updated one day ? I'm OK to do some work about but I'm not sure of what to do...
> Jacques
> Thanks
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-90?page=comments#action_12425963 ]
           
David E. Jones commented on OFBIZ-90:
-------------------------------------

Jacques: feel free to close this sort of issue instead of just resolving it. There are some cases where there is a tentative resolution and you don't want to close the case because you want the reporter or someone to review and test the fix to make sure it was what was intended. If it is a simpler issue and especially if you are the reporter, then it is best to just close it right away rather than coming back to it later to close.

> Deprecated operations replaced by set operations in PromoServices.xml
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-90
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-90
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: PromoServices.xml.patch
>
>
> Hi commiters,
> I'm not completly sure of this patch. Please review it.  I only  tested createProductPromo service
> As references I used
> http://incubator.apache.org/ofbiz/docs/minilang.html which is now deprecated,
> Oxygen popup annotations and
> http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd.
> The inconvenient with this is that there is no semantic in http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd and you are never sure (though almost) of what you do.
> Is somewhere an updated documentation that I did not found ? Else may the http://incubator.apache.org/ofbiz/docs/minilang.html document been updated one day ? I'm OK to do some work about but I'm not sure of what to do...
> Jacques
> Thanks
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-90?page=all ]

Jacques Le Roux reopened OFBIZ-90:
----------------------------------

             
OK, done.

> Deprecated operations replaced by set operations in PromoServices.xml
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-90
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-90
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: PromoServices.xml.patch
>
>
> Hi commiters,
> I'm not completly sure of this patch. Please review it.  I only  tested createProductPromo service
> As references I used
> http://incubator.apache.org/ofbiz/docs/minilang.html which is now deprecated,
> Oxygen popup annotations and
> http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd.
> The inconvenient with this is that there is no semantic in http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd and you are never sure (though almost) of what you do.
> Is somewhere an updated documentation that I did not found ? Else may the http://incubator.apache.org/ofbiz/docs/minilang.html document been updated one day ? I'm OK to do some work about but I'm not sure of what to do...
> Jacques
> Thanks
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-90) Deprecated operations replaced by set operations in PromoServices.xml

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-90?page=all ]

Jacques Le Roux closed OFBIZ-90.
--------------------------------

    Resolution: Fixed

A new commit in rev 429010 resolves this problem.

> Deprecated operations replaced by set operations in PromoServices.xml
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-90
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-90
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: PromoServices.xml.patch
>
>
> Hi commiters,
> I'm not completly sure of this patch. Please review it.  I only  tested createProductPromo service
> As references I used
> http://incubator.apache.org/ofbiz/docs/minilang.html which is now deprecated,
> Oxygen popup annotations and
> http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd.
> The inconvenient with this is that there is no semantic in http://incubator.apache.org/ofbiz/dtds/simple-methods.xsd and you are never sure (though almost) of what you do.
> Is somewhere an updated documentation that I did not found ? Else may the http://incubator.apache.org/ofbiz/docs/minilang.html document been updated one day ? I'm OK to do some work about but I'm not sure of what to do...
> Jacques
> Thanks
> Jacques

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira