[jira] Created: (OFBIZ-939) Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform

[Nicolas Malin (Jira)]

Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
------------------------------------------------------------------------------

                 Key: OFBIZ-939
                 URL: https://issues.apache.org/jira/browse/OFBIZ-939
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
            Reporter: Scott Gray
            Priority: Minor


Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform

I'm also wondering if we should perhaps set the maximumFractionDigits to something like 10 decimal places by default, it would help us to spot any rounding problems since we shouldn't really have display code performing rounding for us.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-939:
-----------------------------

    Attachment: maximumFractionDigits.patch

Patch for this issue, note I haven't included my suggestion regarding defaulting to more decimal places for now

> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-939
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-939
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Scott Gray
>            Priority: Minor
>         Attachments: maximumFractionDigits.patch
>
>
> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> I'm also wondering if we should perhaps set the maximumFractionDigits to something like 10 decimal places by default, it would help us to spot any rounding problems since we shouldn't really have display code performing rounding for us.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492544 ]

Jacques Le Roux commented on OFBIZ-939:
---------------------------------------

I totally agree : +1

> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-939
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-939
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Scott Gray
>            Priority: Minor
>         Attachments: maximumFractionDigits.patch
>
>
> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> I'm also wondering if we should perhaps set the maximumFractionDigits to something like 10 decimal places by default, it would help us to spot any rounding problems since we shouldn't really have display code performing rounding for us.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502337 ]

Jacopo Cappellato commented on OFBIZ-939:
-----------------------------------------

Scott,

is your patch in svn?

> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-939
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-939
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Scott Gray
>            Priority: Minor
>         Attachments: maximumFractionDigits.patch
>
>
> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> I'm also wondering if we should perhaps set the maximumFractionDigits to something like 10 decimal places by default, it would help us to spot any rounding problems since we shouldn't really have display code performing rounding for us.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502687 ]

Scott Gray commented on OFBIZ-939:
----------------------------------

Hi Jacopo

It's not in yet, I hadn't really worried about it since we increased the default number of digits.  I no longer have a use for this but if you or anyone else think it's useful then I can commit it.

> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-939
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-939
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Scott Gray
>            Priority: Minor
>         Attachments: maximumFractionDigits.patch
>
>
> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> I'm also wondering if we should perhaps set the maximumFractionDigits to something like 10 decimal places by default, it would help us to spot any rounding problems since we shouldn't really have display code performing rounding for us.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-939.
----------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Looks like Andy did something similar in rev. 551625

> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-939
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-939
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Scott Gray
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: maximumFractionDigits.patch
>
>
> Add support for maximumFractionDigits to the freemarker OfbizCurrencyTransform
> I'm also wondering if we should perhaps set the maximumFractionDigits to something like 10 decimal places by default, it would help us to spot any rounding problems since we shouldn't really have display code performing rounding for us.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.