[jira] Created: (OFBIZ-96) Edit Invoice Item form, Label for Amount field should be Unit Price

[Nicolas Malin (Jira)]

Edit Invoice Item form,  Label for Amount field should be Unit Price
--------------------------------------------------------------------

                 Key: OFBIZ-96
                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: accounting
            Reporter: Anil K Patel
         Attachments: EditInvoiceItemAmountLabelChanged.patch

Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-96?page=all ]

Anil K Patel updated OFBIZ-96:
------------------------------

    Attachment: EditInvoiceItemAmountLabelChanged.patch

Patch to fix Label for Amount field in Edit Invoice item form.

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: EditInvoiceItemAmountLabelChanged.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12423956 ]
           
Anil K Patel commented on OFBIZ-96:
-----------------------------------

This is a really very small patch. It may take just few min to review and commit. Is it possible for any of the Priveledged person to take a look at this patch.
I am just wondering doing such small usability things are of any importance to community?

Regards
Anil Patel

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: EditInvoiceItemAmountLabelChanged.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-96?page=all ]

Si Chen reassigned OFBIZ-96:
----------------------------

    Assignee: Si Chen

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12423958 ]
           
Si Chen commented on OFBIZ-96:
------------------------------

This patch is a good idea, but if you change the edit invoice items to say "Unit Price" but the list of invoice items still says "Amount", it is very confusing.  Can you please send a patch for that change as well, or a patch which covers both.

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-96?page=all ]

Anil K Patel updated OFBIZ-96:
------------------------------

    Attachment: EditInvoiceItemAmountLabelChangedUpdate.patch

This Update implements changes suggested by Si.
Regards
Anil

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424126 ]
           
Si Chen commented on OFBIZ-96:
------------------------------

Anil,

Sorry but the Invoice Overview page still says "Amount".  I tried fixing it like this in InvoiceForms.xml's invoiceItems form, but it did not work for me:
-        <field name="amount" widget-area-style="tabletextright" use-when="uomId!=null"><display type="currency" currency="${uomId}"/></field>
-        <field name="amount" widget-area-style="tabletextright" use-when="uomId==null"><display type="currency" currency="${invoice.currencyUomId}"/></field>
+        <field name="amount" title="${uiLabelMap.AccountingUnitPrice}" widget-area-style="tabletextright" use-when="uomId!=null"><display type="currency" currency="${uomId}"/></field>
+        <field name="amount" title="${uiLabelMap.AccountingUnitPrice}" widget-area-style="tabletextright" use-when="uomId==null"><display type="currency" currency="${invoice.currencyUomId}"/></field>


Do you know how to make it say "Unit Price" as well, so everything can be consistent?

Si

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424162 ]
           
Anil K Patel commented on OFBIZ-96:
-----------------------------------

Si,
I looked at invoiceItems form.
For me the logic is too complex for form widget.
If there is any body who can make form widgets do the job its good.
If its ok I'll work on ftl file for this and submit the patch later.

Is it possible to get the current patch go into svn and deal with Overview screen as a saperate Issue?

Anil

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424169 ]
           
Si Chen commented on OFBIZ-96:
------------------------------

I'm not sure we should since then on one page it says "Unit Price" and on the other "Amount".  Granted this is a very minor issue, but the policy as stated here http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities

is pretty clear:

Nothing should be committed that breaks existing functionality just to make something easier for a particular client or customization effort. This means, in particular, that if some progress is made on a certain effort but you can't finish it in the time you have available, then don't commit it if it breaks anything that was there, just keep it local or attach it to a Jira issue or something if you want others to be able to get involved (or just it to the point where the stuff it broke works again, then commit it.

Does anybody else have any thoughts on this one?

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424184 ]
           
Jacques Le Roux commented on OFBIZ-96:
--------------------------------------

Sorry I do not have the time to completly review the patch yet. My comment here is only formal.  Nervertheless I think too that both should be done (and afterward commited) at the same time.

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424187 ]
           
Anil K Patel commented on OFBIZ-96:
-----------------------------------

In order to fix invoiceItems form, I think should write it in ftl instead of form widgets.

If ftl is ok then I'll do it?

Anil Patel

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424191 ]
           
Jacques Le Roux commented on OFBIZ-96:
--------------------------------------

For me it's ok. If you really think that it's impossible to do with widget go for FTL. But this will indubitably slow the commit process (tougher review). Anyway I think you presume it.

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-96?page=comments#action_12424195 ]
           
Si Chen commented on OFBIZ-96:
------------------------------

It's ok with me too but maybe somebody knows how to do it with form widget, so you don't have to re-write a whole form?

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Si Chen
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-96?page=all ]

Si Chen reassigned OFBIZ-96:
----------------------------

    Assignee:     (was: Si Chen)

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-96?page=all ]

Scott Gray updated OFBIZ-96:
----------------------------

    Attachment: EditInvoiceItemAmountLabelChangedUpdate2.patch

Hi

The change to the Invoice Overview that Si mention's above works for me, so I'm not sure what's going on there but I've included it in a new patch for review

Regards
Scott

> Edit Invoice Item form,  Label for Amount field should be Unit Price
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-96
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-96
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: EditInvoiceItemAmountLabelChanged.patch, EditInvoiceItemAmountLabelChangedUpdate.patch, EditInvoiceItemAmountLabelChangedUpdate2.patch
>
>
> Edit Invoice Item form has amount field. Label for this field is Auto generated and is misleading. It should be Unit Price.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira