[
https://issues.apache.org/jira/browse/OFBIZ-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637573#action_12637573 ]
eckardjf edited comment on OFBIZ-988 at 10/7/08 11:12 AM:
------------------------------------------------------------
What issue was this patch intended to fix? On my system, this creates a bug by adding an extra "/" to the URI, making it invalid. e.g:
FOP-FontBaseURL: file:////Users/eckard/src/ofbiz-rr/framework/webapp/config/ (wrong)
instead of
FOP-FontBaseURL: file:///Users/eckard/src/ofbiz-rr/framework/webapp/config/ (correct)
also, a few other questions:
1. Why are we constructing the default URI this way? If we're on a windows machine, ofbiz.home may have backslashes
2. Why are we making the default font location framework/webapp/config? Why not create a new fonts directory?
3. Why is the fop config filename hardcoded?
4. Where is the fop.properties file? There doesn't appear to be one in the project with default values & comments.
(will submit patch when time permits, just wanted to re-open so it doesn't get missed)
was (Author: eckardjf):
What issue was this patch intended to fix? On my system, this creates a bug by adding an extra "/" to the URI, making it invalid. e.g:
FOP-FontBaseURL: file:////Users/eckard/src/ofbiz-rr/framework/webapp/config/ (wrong)
instead of
FOP-FontBaseURL: file:///Users/eckard/src/ofbiz-rr/framework/webapp/config/ (correct)
also, a few other questions:
1. Why are we constructing the default URI this way? If we're on a windows machine, ofbiz.home may have backslashes
2. Why are we making the default font location framework/webapp/config? Why not create a new fonts directory?
3. Why is the fop config filename hardcoded?
4. Where is the fop.properties file? There doesn't appear to be one in the project with default values & comments.
> Incorrect default FOP font-base URL
> -----------------------------------
>
> Key: OFBIZ-988
> URL:
https://issues.apache.org/jira/browse/OFBIZ-988> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Oleg Andreyev
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: webapp.diff
>
>
> Attached patch fix this problem
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
