[jira] Created: (OFBIZ-998) Implement RTL UI Layout, Step 2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
Implement RTL UI Layout, Step 2
-------------------------------

                 Key: OFBIZ-998
                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: rtl_step2.patch

This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.

The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:

<set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>

If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.

It's simple and it works.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-998:
------------------------------

    Attachment: rtl_step2.patch

Updated header template files.

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-998:
------------------------------

    Attachment: rtl_step2.patch

Updated patch against latest revision.

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516162 ]

Jacques Le Roux commented on OFBIZ-998:
---------------------------------------

I wonder why nobody needing such a feature is trying this patch and comment. Please, folks from (for instance) Arabian or Chinese speaking countries, can you take a look at this patch before it get outdated again ?

Thans in advance...

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516206 ]

Wickersheimer Jeremy commented on OFBIZ-998:
--------------------------------------------

Jacques, Chinese is ltr so i think only Arabian and related countries would be interested (which may be a very little user base)
Maybe you guys could contact whoever did the Arabian translation for Ofbiz ?

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516211 ]

Jacques Le Roux commented on OFBIZ-998:
---------------------------------------

Jeremy,

Yes I will try something like that ... if nobody react...
BTW not sure for Chinese reading (http://www.mandarintools.com/faq.html#direction : Taiwanese keep their habit  ;o)



> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516223 ]

Adrian Crum commented on OFBIZ-998:
-----------------------------------

Hebrew is rtl also.

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516347 ]

Wickersheimer Jeremy commented on OFBIZ-998:
--------------------------------------------

Jacques,

Since i've been in China i've never seen any computer system or website using the traditional writing directions.
It is true that traditionally it is written top to bottom and right to left, same in Japanese . So i guess you can find it for written documents and books (if you read manga for example).
Never been to Taiwan (yet) but i bet they are using ltr commonly too.

The only interest would be middle east languages.

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-998:
------------------------------

    Attachment: rtl_step2.patch

Attached patch now includes a rtl style sheet .

RTL layout is hard to test in a ltr browser. Mozilla and IE7 try to render rtl, but each has its quirks. At any rate, this patch demonstrates how it works. If a rtl-reading developer wants to develop it further, they are welcome to do so.


> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516475 ]

Jacques Le Roux commented on OFBIZ-998:
---------------------------------------

I asked Amine Azzi if he may help, he answered favourably

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534584 ]

Jacopo Cappellato commented on OFBIZ-998:
-----------------------------------------

Can we apply this patch?
I don't see any votes... no user using a RTL layout tested it?
By the way, it seems good to me, and if Adrian could confirm that is still good for the trunk I'd like to commit it.


> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-998:
---------------------------------------

    Assignee: Jacopo Cappellato

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-998) Implement RTL UI Layout, Step 2

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-998.
-----------------------------------

    Resolution: Fixed

Adrian,

your patch is in rev. 585398

Many Thanks!

> Implement RTL UI Layout, Step 2
> -------------------------------
>
>                 Key: OFBIZ-998
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-998
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: rtl_step2.patch, rtl_step2.patch, rtl_step2.patch
>
>
> This is a continuation of OFBIZ-854. Update the header.ftl and simple.ftl files to support rtl style sheets.
> The concept is to have a list of rtl stylesheets that is passed to the header template just like the existing style sheets. An rtl style sheet can then be specified in the Global Decorator like this:
> <set field="layoutSettings.rtlStyleSheets[]" value="/images/rtlmain.css" global="true"/>
> If the OFBiz user has selected an rtl language, then the rtl style sheet will be cascaded.
> It's simple and it works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.