[jira] [Updated] (OFBIZ-5894) ContentWorker.renderContentAsText render "null" as string if electornic text is empty.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-5894:
--------------------------------
    Attachment: OFBIZ-5894.patch

Here is the patch for this issue.

Added check on DataResourceWorker.writeText method if textData value is null then don't append it to writer else it will render null as string. As we did not add anything on write then getDataResourceText (DataResourceWorker.java 675) method return empty string and it call the FreeMarkerWorker.renderTemplate method with empty templateString.

Also added check on FreeMarkerWorker.renderTemplate, and used the null check instead of UtilValidate.isEmpty method, as isEmpty method return true for empty string and then it try to render template by location instead renderTemplateFromString and throw exception. Ideally it should render the empty string using renderTemplateFromString method.

> ContentWorker.renderContentAsText render "null" as string if electornic text is empty.
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5894
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5894
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>            Reporter: Deepak Dixit
>            Priority: Minor
>         Attachments: OFBIZ-5894.patch, Screen Shot 2014-12-03 at 11.16.15 AM.png
>
>
> If ContentWorker.renderContentAsText used to render content that have electronicText with empty textData then it will render null as string.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)