jquery files not mentioned in the LICENSE file
Locked
jquery files not mentioned in the LICENSE file
 
|
Should the following files without a license header be mentioned in the LICENSE file?
Jacopo ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js |
Re: jquery files not mentioned in the LICENSE file
Administrator
|
I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking for us)
in framework/images so we don't need an older jQuery ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) And... I'm tired... :/ Jacques From: "Jacopo Cappellato" <[hidden email]> > Should the following files without a license header be mentioned in the LICENSE file? > > Jacopo > > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js > > |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
Hans,
Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the feature to continue to work? Jacopo: jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: http://jquery.malsup.com/license.html jquery.function.js should be licensed by us (it's obviously a covert) But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo Jacques From: "Jacques Le Roux" <[hidden email]> >I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking for us) >in framework/images so we don't need an older jQuery > ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. > > So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) > > I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) > > > Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) > > And... I'm tired... :/ > > Jacques > > From: "Jacopo Cappellato" <[hidden email]> >> Should the following files without a license header be mentioned in the LICENSE file? >> >> Jacopo >> >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js >> >> > > |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
Bump...!
Jacques From: "Jacques Le Roux" <[hidden email]> > Hans, > > Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the > feature to continue to work? > > Jacopo: > jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough > jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: http://jquery.malsup.com/license.html > jquery.function.js should be licensed by us (it's obviously a covert) > > But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >>I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking for >>us) in framework/images so we don't need an older jQuery >> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >> >> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) >> >> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) >> >> >> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) >> >> And... I'm tired... :/ >> >> Jacques >> >> From: "Jacopo Cappellato" <[hidden email]> >>> Should the following files without a license header be mentioned in the LICENSE file? >>> >>> Jacopo >>> >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js >>> >>> >> >> > > |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues...
Thanks Jacques From: "Jacques Le Roux" <[hidden email]> > Bump...! > > Jacques > > From: "Jacques Le Roux" <[hidden email]> >> Hans, >> >> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the >> feature to continue to work? >> >> Jacopo: >> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough >> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: http://jquery.malsup.com/license.html >> jquery.function.js should be licensed by us (it's obviously a covert) >> >> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo >> >> Jacques >> >> From: "Jacques Le Roux" <[hidden email]> >>>I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking for >>>us) in framework/images so we don't need an older jQuery >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>> >>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) >>> >>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) >>> >>> >>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) >>> >>> And... I'm tired... :/ >>> >>> Jacques >>> >>> From: "Jacopo Cappellato" <[hidden email]> >>>> Should the following files without a license header be mentioned in the LICENSE file? >>>> >>>> Jacopo >>>> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js >>>> >>>> >>> >>> >> >> > > |
Re: jquery files not mentioned in the LICENSE file
|
The author is willing to change the license, allow some time here.....
On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: > OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues... > > Thanks > > Jacques > > From: "Jacques Le Roux" <[hidden email]> > > Bump...! > > > > Jacques > > > > From: "Jacques Le Roux" <[hidden email]> > >> Hans, > >> > >> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the > >> feature to continue to work? > >> > >> Jacopo: > >> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough > >> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: http://jquery.malsup.com/license.html > >> jquery.function.js should be licensed by us (it's obviously a covert) > >> > >> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo > >> > >> Jacques > >> > >> From: "Jacques Le Roux" <[hidden email]> > >>>I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking for > >>>us) in framework/images so we don't need an older jQuery > >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. > >>> > >>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) > >>> > >>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) > >>> > >>> > >>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) > >>> > >>> And... I'm tired... :/ > >>> > >>> Jacques > >>> > >>> From: "Jacopo Cappellato" <[hidden email]> > >>>> Should the following files without a license header be mentioned in the LICENSE file? > >>>> > >>>> Jacopo > >>>> > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js > >>>> > >>>> > >>> > >>> > >> > >> > > > > > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
Great, thanks Hans
Jacques From: "Hans Bakker" <[hidden email]> > The author is willing to change the license, allow some time here..... > > On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: >> OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues... >> >> Thanks >> >> Jacques >> >> From: "Jacques Le Roux" <[hidden email]> >> > Bump...! >> > >> > Jacques >> > >> > From: "Jacques Le Roux" <[hidden email]> >> >> Hans, >> >> >> >> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the >> >> feature to continue to work? >> >> >> >> Jacopo: >> >> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough >> >> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: >> >> http://jquery.malsup.com/license.html >> >> jquery.function.js should be licensed by us (it's obviously a covert) >> >> >> >> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo >> >> >> >> Jacques >> >> >> >> From: "Jacques Le Roux" <[hidden email]> >> >>>I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >> >>>for >> >>>us) in framework/images so we don't need an older jQuery >> >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >> >>> >> >>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) >> >>> >> >>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) >> >>> >> >>> >> >>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) >> >>> >> >>> And... I'm tired... :/ >> >>> >> >>> Jacques >> >>> >> >>> From: "Jacopo Cappellato" <[hidden email]> >> >>>> Should the following files without a license header be mentioned in the LICENSE file? >> >>>> >> >>>> Jacopo >> >>>> >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >> >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js >> >>>> >> >>>> >> >>> >> >>> >> >> >> >> >> > >> > >> >> > > -- > Ofbiz on twitter: http://twitter.com/apache_ofbiz > Myself on twitter: http://twitter.com/hansbak > Antwebsystems.com: Quality services for competitive rates. > |
Re: jquery files not mentioned in the LICENSE file
|
|
In reply to this post by Jacques Le Roux
Hi Jaques,
although not shown in the js file (the author will update it) the license is MIT: http://code.google.com/p/jqueryrotate/ Regards, Hans On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: > OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues... > > Thanks > > Jacques > > From: "Jacques Le Roux" <[hidden email]> > > Bump...! > > > > Jacques > > > > From: "Jacques Le Roux" <[hidden email]> > >> Hans, > >> > >> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the > >> feature to continue to work? > >> > >> Jacopo: > >> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough > >> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: http://jquery.malsup.com/license.html > >> jquery.function.js should be licensed by us (it's obviously a covert) > >> > >> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo > >> > >> Jacques > >> > >> From: "Jacques Le Roux" <[hidden email]> > >>>I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking for > >>>us) in framework/images so we don't need an older jQuery > >>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. > >>> > >>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) > >>> > >>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) > >>> > >>> > >>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) > >>> > >>> And... I'm tired... :/ > >>> > >>> Jacques > >>> > >>> From: "Jacopo Cappellato" <[hidden email]> > >>>> Should the following files without a license header be mentioned in the LICENSE file? > >>>> > >>>> Jacopo > >>>> > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js > >>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js > >>>> > >>>> > >>> > >>> > >> > >> > > > > > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
OK, cool dual licensing as most jQuery plugins, thanks Hans, I will update LICENCE and it's done
I think the author should make it clear because it's still not obvious if you get to http://code.google.com/p/jquery-rotate/ or is it a wrong url (not the same plugin?) I have still a pure OFBiz concern tough: >>>>> I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >>>>> for us) in framework/images so we don't need an older jQuery >>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>>>> >>>>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement Why not using the one in Framework? Jacques Hans Bakker wrote: > Hi Jaques, > > although not shown in the js file (the author will update it) > > the license is MIT: > > http://code.google.com/p/jqueryrotate/ > > Regards, > Hans > > On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: >> OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues... >> >> Thanks >> >> Jacques >> >> From: "Jacques Le Roux" <[hidden email]> >>> Bump...! >>> >>> Jacques >>> >>> From: "Jacques Le Roux" <[hidden email]> >>>> Hans, >>>> >>>> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the >>>> feature to continue to work? >>>> >>>> Jacopo: >>>> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough >>>> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: >>>> http://jquery.malsup.com/license.html jquery.function.js should be licensed by us (it's obviously a covert) >>>> >>>> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo >>>> >>>> Jacques >>>> >>>> From: "Jacques Le Roux" <[hidden email]> >>>>> I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >>>>> for us) in framework/images so we don't need an older jQuery >>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>>>> >>>>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) >>>>> >>>>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) >>>>> >>>>> >>>>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) >>>>> >>>>> And... I'm tired... :/ >>>>> >>>>> Jacques >>>>> >>>>> From: "Jacopo Cappellato" <[hidden email]> >>>>>> Should the following files without a license header be mentioned in the LICENSE file? >>>>>> >>>>>> Jacopo >>>>>> >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
In reply to this post by Jacopo Cappellato-4
And also why not using the standard jQuery structure with plugins in Framework?
Thanks Jacques Jacques Le Roux wrote: > I have still a pure OFBiz concern tough: >>>>>> I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >>>>>> for us) in framework/images so we don't need an older jQuery >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>>>>> >>>>>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement > > Why not using the one in Framework? > > Jacques > > Hans Bakker wrote: >> Hi Jaques, >> >> although not shown in the js file (the author will update it) >> >> the license is MIT: >> >> http://code.google.com/p/jqueryrotate/ >> >> Regards, >> Hans >> >> On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: >>> OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues... >>> >>> Thanks >>> >>> Jacques >>> >>> From: "Jacques Le Roux" <[hidden email]> >>>> Bump...! >>>> >>>> Jacques >>>> >>>> From: "Jacques Le Roux" <[hidden email]> >>>>> Hans, >>>>> >>>>> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets the >>>>> feature to continue to work? >>>>> >>>>> Jacopo: >>>>> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough >>>>> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: >>>>> http://jquery.malsup.com/license.html jquery.function.js should be licensed by us (it's obviously a covert) >>>>> >>>>> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo >>>>> >>>>> Jacques >>>>> >>>>> From: "Jacques Le Roux" <[hidden email]> >>>>>> I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >>>>>> for us) in framework/images so we don't need an older jQuery >>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>>>>> >>>>>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) >>>>>> >>>>>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) >>>>>> >>>>>> >>>>>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) >>>>>> >>>>>> And... I'm tired... :/ >>>>>> >>>>>> Jacques >>>>>> >>>>>> From: "Jacopo Cappellato" <[hidden email]> >>>>>>> Should the following files without a license header be mentioned in the LICENSE file? >>>>>>> >>>>>>> Jacopo >>>>>>> >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js |
Re: jquery files not mentioned in the LICENSE file
|
Administrator
|
In reply to this post by Jacopo Cappellato-4
Easier for us to update (nothing to do) in LICENCE
ofbiz/trunk/framework/images/webapp/images/jquery/* et voilà! Thanks Jacques Le Roux wrote: > And also why not using the standard jQuery structure with plugins in Framework? > > Thanks > > Jacques > > Jacques Le Roux wrote: >> I have still a pure OFBiz concern tough: >>>>>>> I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >>>>>>> for us) in framework/images so we don't need an older jQuery >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>>>>>> >>>>>>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement >> >> Why not using the one in Framework? >> >> Jacques >> >> Hans Bakker wrote: >>> Hi Jaques, >>> >>> although not shown in the js file (the author will update it) >>> >>> the license is MIT: >>> >>> http://code.google.com/p/jqueryrotate/ >>> >>> Regards, >>> Hans >>> >>> On Mon, 2011-01-24 at 15:57 +0100, Jacques Le Roux wrote: >>>> OK, I will have to revert this commit (it's our duty), unless someone take care of the GPL issues... >>>> >>>> Thanks >>>> >>>> Jacques >>>> >>>> From: "Jacques Le Roux" <[hidden email]> >>>>> Bump...! >>>>> >>>>> Jacques >>>>> >>>>> From: "Jacques Le Roux" <[hidden email]> >>>>>> Hans, >>>>>> >>>>>> Could you please check that removing ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js lets >>>>>> the feature to continue to work? >>>>>> >>>>>> Jacopo: >>>>>> jCrop is MIT licenced http://deepliquid.com/content/Jcrop_License.html, a simple note in NOTICE is enough >>>>>> jquery.form.js is dual licensed as jQuery (GPL and MIT), a simple note in NOTICE is enough: >>>>>> http://jquery.malsup.com/license.html jquery.function.js should be licensed by us (it's obviously a covert) >>>>>> >>>>>> But jquery.Rotate.js is a real issue: LGPL http://code.google.com/p/jquery-rotate/ and should not be commited in our repo >>>>>> >>>>>> Jacques >>>>>> >>>>>> From: "Jacques Le Roux" <[hidden email]> >>>>>>> I did not notice, this is messy. We already have jQuery 1.4.2 (we have also 1.4.3 and 1.4.4 but they are buggy and blocking >>>>>>> for us) in framework/images so we don't need an older jQuery >>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js is v1.3.2. >>>>>>> >>>>>>> So imagemanagement should rather use jQuery 1.4.2 unless they are issues with it for imagemanagement (I doubt) >>>>>>> >>>>>>> I'd strongly recommend for any new jQuery stuff to follow the path we used so far (have all centralized in framework/images) >>>>>>> >>>>>>> >>>>>>> Also I can't connect to http://deepliquid.com/content/Jcrop.html (actually I get a blank screen) >>>>>>> >>>>>>> And... I'm tired... :/ >>>>>>> >>>>>>> Jacques >>>>>>> >>>>>>> From: "Jacopo Cappellato" <[hidden email]> >>>>>>>> Should the following files without a license header be mentioned in the LICENSE file? >>>>>>>> >>>>>>>> Jacopo >>>>>>>> >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.css >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.js >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Jcrop.min.js >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.Rotate.js >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.form.js >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.function.js >>>>>>>> ofbiz-trunk/applications/product/webapp/catalog/imagemanagement/js/jquery.min.js |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |