partymanager consistency with the other components
Locked
partymanager consistency with the other components
 
|
Hi all,
when looking at the party manager component, I've seen two things that aren't the same as the other components, and I was wondering if this was intentional or not yet done (in this case I will provide a patch to correct it) : * the file with the menus is named PartyMenus.xml, and in most of other components, it is just named Menus.xml. Should we name all the menus files by the name of the component and add Menus.xml to them, or just name them with Menus.xml ? * the file containing the forms in Party is located in webapp/partymgr/party/, but for most of the components, it is in widget/<component>/ or widget/<component>/forms. Should we move it to the same place as others ? Regards, -- Erwan |
Re: partymanager consistency with the other components
|
|
+1
I totally agree with keeping consistency. Will you create the JIRA? Regards, Pierre 2009/10/20 Erwan de FERRIERES <[hidden email]> > Hi all, > > when looking at the party manager component, I've seen two things that > aren't the same as the other components, and I was wondering if this was > intentional or not yet done (in this case I will provide a patch to correct > it) : > > * the file with the menus is named PartyMenus.xml, and in most of other > components, it is just named Menus.xml. Should we name all the menus files > by the name of the component and add Menus.xml to them, or just name them > with Menus.xml ? > > * the file containing the forms in Party is located in > webapp/partymgr/party/, but for most of the components, it is in > widget/<component>/ or widget/<component>/forms. Should we move it to the > same place as others ? > > Regards, > > -- > Erwan > |
Re: partymanager consistency with the other components
|
|
+1 on having the menu files like xxxxxMenus.xml
+1 on moving the menu files in the widget folder -Bruno 2009/10/20 Pierre Smits <[hidden email]>: > +1 > I totally agree with keeping consistency. Will you create the JIRA? > > Regards, > > Pierre > > 2009/10/20 Erwan de FERRIERES <[hidden email]> > >> Hi all, >> >> when looking at the party manager component, I've seen two things that >> aren't the same as the other components, and I was wondering if this was >> intentional or not yet done (in this case I will provide a patch to correct >> it) : >> >> * the file with the menus is named PartyMenus.xml, and in most of other >> components, it is just named Menus.xml. Should we name all the menus files >> by the name of the component and add Menus.xml to them, or just name them >> with Menus.xml ? >> >> * the file containing the forms in Party is located in >> webapp/partymgr/party/, but for most of the components, it is in >> widget/<component>/ or widget/<component>/forms. Should we move it to the >> same place as others ? >> >> Regards, >> >> -- >> Erwan >> > |
Re: partymanager consistency with the other components
|
|
In reply to this post by Erwan de FERRIERES-3
The location of the form widget XML files has been discussed before.
There are two perspectives: 1) The form widget XML files belong with the rest of the widget XML files in the widget folder, and 2) The form widget XML files are part of the web application - so they belong in the webapp folder. My personal preference is that they be kept with the other widget XML files, but I'm sure others will disagree. -Adrian Erwan de FERRIERES wrote: > Hi all, > > when looking at the party manager component, I've seen two things that > aren't the same as the other components, and I was wondering if this was > intentional or not yet done (in this case I will provide a patch to > correct it) : > > * the file with the menus is named PartyMenus.xml, and in most of other > components, it is just named Menus.xml. Should we name all the menus > files by the name of the component and add Menus.xml to them, or just > name them with Menus.xml ? > > * the file containing the forms in Party is located in > webapp/partymgr/party/, but for most of the components, it is in > widget/<component>/ or widget/<component>/forms. Should we move it to > the same place as others ? > > Regards, > |
Re: partymanager consistency with the other components
|
|
I do not see any -1 so... ;-)
I think they are in the webapp becouse they were originally implemented as FTL files and then moved to XML when the menu widget was created. I personally converted lots of TabBar menus but at that time I named all files just Menus.xml and I did not move them to the widget folder but now may be its time to clean this up. -Bruno 2009/10/20 Adrian Crum <[hidden email]>: > The location of the form widget XML files has been discussed before. There > are two perspectives: 1) The form widget XML files belong with the rest of > the widget XML files in the widget folder, and 2) The form widget XML files > are part of the web application - so they belong in the webapp folder. > > My personal preference is that they be kept with the other widget XML files, > but I'm sure others will disagree. > > -Adrian > > Erwan de FERRIERES wrote: >> >> Hi all, >> >> when looking at the party manager component, I've seen two things that >> aren't the same as the other components, and I was wondering if this was >> intentional or not yet done (in this case I will provide a patch to correct >> it) : >> >> * the file with the menus is named PartyMenus.xml, and in most of other >> components, it is just named Menus.xml. Should we name all the menus files >> by the name of the component and add Menus.xml to them, or just name them >> with Menus.xml ? >> >> * the file containing the forms in Party is located in >> webapp/partymgr/party/, but for most of the components, it is in >> widget/<component>/ or widget/<component>/forms. Should we move it to the >> same place as others ? >> >> Regards, >> > |
Re: partymanager consistency with the other components
|
|
I was referring to form widgets, not menu widgets.
-Adrian Bruno Busco wrote: > I do not see any -1 so... ;-) > > I think they are in the webapp becouse they were originally > implemented as FTL files and then moved to XML when the menu widget > was created. > I personally converted lots of TabBar menus but at that time I named > all files just Menus.xml and I did not move them to the widget folder > but now may be its time to clean this up. > > -Bruno > > 2009/10/20 Adrian Crum <[hidden email]>: >> The location of the form widget XML files has been discussed before. There >> are two perspectives: 1) The form widget XML files belong with the rest of >> the widget XML files in the widget folder, and 2) The form widget XML files >> are part of the web application - so they belong in the webapp folder. >> >> My personal preference is that they be kept with the other widget XML files, >> but I'm sure others will disagree. >> >> -Adrian >> >> Erwan de FERRIERES wrote: >>> Hi all, >>> >>> when looking at the party manager component, I've seen two things that >>> aren't the same as the other components, and I was wondering if this was >>> intentional or not yet done (in this case I will provide a patch to correct >>> it) : >>> >>> * the file with the menus is named PartyMenus.xml, and in most of other >>> components, it is just named Menus.xml. Should we name all the menus files >>> by the name of the component and add Menus.xml to them, or just name them >>> with Menus.xml ? >>> >>> * the file containing the forms in Party is located in >>> webapp/partymgr/party/, but for most of the components, it is in >>> widget/<component>/ or widget/<component>/forms. Should we move it to the >>> same place as others ? >>> >>> Regards, >>> > |
Re: partymanager consistency with the other components
|
|
The reason why some forms files are in the webapp is the same:
becouse they were originally implemented as FTL files and then moved to XML when the FORM widget was created. -Bruno 2009/10/20 Adrian Crum <[hidden email]>: > I was referring to form widgets, not menu widgets. > > -Adrian > > Bruno Busco wrote: >> >> I do not see any -1 so... ;-) >> >> I think they are in the webapp becouse they were originally >> implemented as FTL files and then moved to XML when the menu widget >> was created. >> I personally converted lots of TabBar menus but at that time I named >> all files just Menus.xml and I did not move them to the widget folder >> but now may be its time to clean this up. >> >> -Bruno >> >> 2009/10/20 Adrian Crum <[hidden email]>: >>> >>> The location of the form widget XML files has been discussed before. >>> There >>> are two perspectives: 1) The form widget XML files belong with the rest >>> of >>> the widget XML files in the widget folder, and 2) The form widget XML >>> files >>> are part of the web application - so they belong in the webapp folder. >>> >>> My personal preference is that they be kept with the other widget XML >>> files, >>> but I'm sure others will disagree. >>> >>> -Adrian >>> >>> Erwan de FERRIERES wrote: >>>> >>>> Hi all, >>>> >>>> when looking at the party manager component, I've seen two things that >>>> aren't the same as the other components, and I was wondering if this was >>>> intentional or not yet done (in this case I will provide a patch to >>>> correct >>>> it) : >>>> >>>> * the file with the menus is named PartyMenus.xml, and in most of other >>>> components, it is just named Menus.xml. Should we name all the menus >>>> files >>>> by the name of the component and add Menus.xml to them, or just name >>>> them >>>> with Menus.xml ? >>>> >>>> * the file containing the forms in Party is located in >>>> webapp/partymgr/party/, but for most of the components, it is in >>>> widget/<component>/ or widget/<component>/forms. Should we move it to >>>> the >>>> same place as others ? >>>> >>>> Regards, >>>> >> > |
Re: partymanager consistency with the other components
|
|
No, that is not the reason they are there. As I said previously, some
developers believe that is the most appropriate place for them. -Adrian Bruno Busco wrote: > The reason why some forms files are in the webapp is the same: > becouse they were originally implemented as FTL files and then moved > to XML when the FORM widget > was created. > > -Bruno > > 2009/10/20 Adrian Crum <[hidden email]>: >> I was referring to form widgets, not menu widgets. >> >> -Adrian >> >> Bruno Busco wrote: >>> I do not see any -1 so... ;-) >>> >>> I think they are in the webapp becouse they were originally >>> implemented as FTL files and then moved to XML when the menu widget >>> was created. >>> I personally converted lots of TabBar menus but at that time I named >>> all files just Menus.xml and I did not move them to the widget folder >>> but now may be its time to clean this up. >>> >>> -Bruno >>> >>> 2009/10/20 Adrian Crum <[hidden email]>: >>>> The location of the form widget XML files has been discussed before. >>>> There >>>> are two perspectives: 1) The form widget XML files belong with the rest >>>> of >>>> the widget XML files in the widget folder, and 2) The form widget XML >>>> files >>>> are part of the web application - so they belong in the webapp folder. >>>> >>>> My personal preference is that they be kept with the other widget XML >>>> files, >>>> but I'm sure others will disagree. >>>> >>>> -Adrian >>>> >>>> Erwan de FERRIERES wrote: >>>>> Hi all, >>>>> >>>>> when looking at the party manager component, I've seen two things that >>>>> aren't the same as the other components, and I was wondering if this was >>>>> intentional or not yet done (in this case I will provide a patch to >>>>> correct >>>>> it) : >>>>> >>>>> * the file with the menus is named PartyMenus.xml, and in most of other >>>>> components, it is just named Menus.xml. Should we name all the menus >>>>> files >>>>> by the name of the component and add Menus.xml to them, or just name >>>>> them >>>>> with Menus.xml ? >>>>> >>>>> * the file containing the forms in Party is located in >>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>> widget/<component>/ or widget/<component>/forms. Should we move it to >>>>> the >>>>> same place as others ? >>>>> >>>>> Regards, >>>>> > |
Re: partymanager consistency with the other components
|
|
OK,
thank you for sharing this. -Bruno 2009/10/20 Adrian Crum <[hidden email]>: > No, that is not the reason they are there. As I said previously, some > developers believe that is the most appropriate place for them. > > -Adrian > > Bruno Busco wrote: >> >> The reason why some forms files are in the webapp is the same: >> becouse they were originally implemented as FTL files and then moved >> to XML when the FORM widget >> was created. >> >> -Bruno >> >> 2009/10/20 Adrian Crum <[hidden email]>: >>> >>> I was referring to form widgets, not menu widgets. >>> >>> -Adrian >>> >>> Bruno Busco wrote: >>>> >>>> I do not see any -1 so... ;-) >>>> >>>> I think they are in the webapp becouse they were originally >>>> implemented as FTL files and then moved to XML when the menu widget >>>> was created. >>>> I personally converted lots of TabBar menus but at that time I named >>>> all files just Menus.xml and I did not move them to the widget folder >>>> but now may be its time to clean this up. >>>> >>>> -Bruno >>>> >>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>> >>>>> The location of the form widget XML files has been discussed before. >>>>> There >>>>> are two perspectives: 1) The form widget XML files belong with the rest >>>>> of >>>>> the widget XML files in the widget folder, and 2) The form widget XML >>>>> files >>>>> are part of the web application - so they belong in the webapp folder. >>>>> >>>>> My personal preference is that they be kept with the other widget XML >>>>> files, >>>>> but I'm sure others will disagree. >>>>> >>>>> -Adrian >>>>> >>>>> Erwan de FERRIERES wrote: >>>>>> >>>>>> Hi all, >>>>>> >>>>>> when looking at the party manager component, I've seen two things that >>>>>> aren't the same as the other components, and I was wondering if this >>>>>> was >>>>>> intentional or not yet done (in this case I will provide a patch to >>>>>> correct >>>>>> it) : >>>>>> >>>>>> * the file with the menus is named PartyMenus.xml, and in most of >>>>>> other >>>>>> components, it is just named Menus.xml. Should we name all the menus >>>>>> files >>>>>> by the name of the component and add Menus.xml to them, or just name >>>>>> them >>>>>> with Menus.xml ? >>>>>> >>>>>> * the file containing the forms in Party is located in >>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>> widget/<component>/ or widget/<component>/forms. Should we move it to >>>>>> the >>>>>> same place as others ? >>>>>> >>>>>> Regards, >>>>>> >> > |
Re: partymanager consistency with the other components
|
|
In reply to this post by Adrian Crum
Who are the "some developers" who believe that under the webapp folder is the best place for that? Do you mean yourself? If so, why do you like them there? If not, then whoever the "some developers" are... could you comment on why you like them there? That should be much easier to discuss than where this is going... -David On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: > No, that is not the reason they are there. As I said previously, > some developers believe that is the most appropriate place for them. > > -Adrian > > Bruno Busco wrote: >> The reason why some forms files are in the webapp is the same: >> becouse they were originally implemented as FTL files and then moved >> to XML when the FORM widget >> was created. >> -Bruno >> 2009/10/20 Adrian Crum <[hidden email]>: >>> I was referring to form widgets, not menu widgets. >>> >>> -Adrian >>> >>> Bruno Busco wrote: >>>> I do not see any -1 so... ;-) >>>> >>>> I think they are in the webapp becouse they were originally >>>> implemented as FTL files and then moved to XML when the menu widget >>>> was created. >>>> I personally converted lots of TabBar menus but at that time I >>>> named >>>> all files just Menus.xml and I did not move them to the widget >>>> folder >>>> but now may be its time to clean this up. >>>> >>>> -Bruno >>>> >>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>> The location of the form widget XML files has been discussed >>>>> before. >>>>> There >>>>> are two perspectives: 1) The form widget XML files belong with >>>>> the rest >>>>> of >>>>> the widget XML files in the widget folder, and 2) The form >>>>> widget XML >>>>> files >>>>> are part of the web application - so they belong in the webapp >>>>> folder. >>>>> >>>>> My personal preference is that they be kept with the other >>>>> widget XML >>>>> files, >>>>> but I'm sure others will disagree. >>>>> >>>>> -Adrian >>>>> >>>>> Erwan de FERRIERES wrote: >>>>>> Hi all, >>>>>> >>>>>> when looking at the party manager component, I've seen two >>>>>> things that >>>>>> aren't the same as the other components, and I was wondering if >>>>>> this was >>>>>> intentional or not yet done (in this case I will provide a >>>>>> patch to >>>>>> correct >>>>>> it) : >>>>>> >>>>>> * the file with the menus is named PartyMenus.xml, and in most >>>>>> of other >>>>>> components, it is just named Menus.xml. Should we name all the >>>>>> menus >>>>>> files >>>>>> by the name of the component and add Menus.xml to them, or just >>>>>> name >>>>>> them >>>>>> with Menus.xml ? >>>>>> >>>>>> * the file containing the forms in Party is located in >>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>> widget/<component>/ or widget/<component>/forms. Should we move >>>>>> it to >>>>>> the >>>>>> same place as others ? >>>>>> >>>>>> Regards, >>>>>> |
Re: partymanager consistency with the other components
|
|
No, I didn't mean myself. I already stated that I would prefer them kept
in the widget folder. I tried to Google the conversation, but I can't find it. I recall someone some time ago suggesting form widget XML files being put in the widget folder, and you objected to it - saying graphic artists or web authors would expect forms to be inside the webapp folder. You have also used the same explanation for keeping scripts in the webapp folder. -Adrian David E Jones wrote: > > Who are the "some developers" who believe that under the webapp folder > is the best place for that? Do you mean yourself? If so, why do you like > them there? If not, then whoever the "some developers" are... could you > comment on why you like them there? > > That should be much easier to discuss than where this is going... > > -David > > > On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: > >> No, that is not the reason they are there. As I said previously, some >> developers believe that is the most appropriate place for them. >> >> -Adrian >> >> Bruno Busco wrote: >>> The reason why some forms files are in the webapp is the same: >>> becouse they were originally implemented as FTL files and then moved >>> to XML when the FORM widget >>> was created. >>> -Bruno >>> 2009/10/20 Adrian Crum <[hidden email]>: >>>> I was referring to form widgets, not menu widgets. >>>> >>>> -Adrian >>>> >>>> Bruno Busco wrote: >>>>> I do not see any -1 so... ;-) >>>>> >>>>> I think they are in the webapp becouse they were originally >>>>> implemented as FTL files and then moved to XML when the menu widget >>>>> was created. >>>>> I personally converted lots of TabBar menus but at that time I named >>>>> all files just Menus.xml and I did not move them to the widget folder >>>>> but now may be its time to clean this up. >>>>> >>>>> -Bruno >>>>> >>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>> The location of the form widget XML files has been discussed before. >>>>>> There >>>>>> are two perspectives: 1) The form widget XML files belong with the >>>>>> rest >>>>>> of >>>>>> the widget XML files in the widget folder, and 2) The form widget XML >>>>>> files >>>>>> are part of the web application - so they belong in the webapp >>>>>> folder. >>>>>> >>>>>> My personal preference is that they be kept with the other widget XML >>>>>> files, >>>>>> but I'm sure others will disagree. >>>>>> >>>>>> -Adrian >>>>>> >>>>>> Erwan de FERRIERES wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> when looking at the party manager component, I've seen two things >>>>>>> that >>>>>>> aren't the same as the other components, and I was wondering if >>>>>>> this was >>>>>>> intentional or not yet done (in this case I will provide a patch to >>>>>>> correct >>>>>>> it) : >>>>>>> >>>>>>> * the file with the menus is named PartyMenus.xml, and in most of >>>>>>> other >>>>>>> components, it is just named Menus.xml. Should we name all the menus >>>>>>> files >>>>>>> by the name of the component and add Menus.xml to them, or just name >>>>>>> them >>>>>>> with Menus.xml ? >>>>>>> >>>>>>> * the file containing the forms in Party is located in >>>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>>> widget/<component>/ or widget/<component>/forms. Should we move >>>>>>> it to >>>>>>> the >>>>>>> same place as others ? >>>>>>> >>>>>>> Regards, >>>>>>> > > |
Re: partymanager consistency with the other components
|
|
Well, I guess that would be interesting to look up and see. IMO widget XML files should not go under the webapp directory because they are not web-only artifacts. Early on there was nothing by the form widget, and it was commonly included from an FTL file (no screen widget, etc), and in that era the form widget XML files did go under the webapp directory... but that was a long time ago and before the more general widget stuff was fleshed out. -David On Oct 20, 2009, at 1:59 PM, Adrian Crum wrote: > No, I didn't mean myself. I already stated that I would prefer them > kept in the widget folder. > > I tried to Google the conversation, but I can't find it. I recall > someone some time ago suggesting form widget XML files being put in > the widget folder, and you objected to it - saying graphic artists > or web authors would expect forms to be inside the webapp folder. > You have also used the same explanation for keeping scripts in the > webapp folder. > > -Adrian > > David E Jones wrote: >> Who are the "some developers" who believe that under the webapp >> folder is the best place for that? Do you mean yourself? If so, why >> do you like them there? If not, then whoever the "some developers" >> are... could you comment on why you like them there? >> That should be much easier to discuss than where this is going... >> -David >> On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: >>> No, that is not the reason they are there. As I said previously, >>> some developers believe that is the most appropriate place for them. >>> >>> -Adrian >>> >>> Bruno Busco wrote: >>>> The reason why some forms files are in the webapp is the same: >>>> becouse they were originally implemented as FTL files and then >>>> moved >>>> to XML when the FORM widget >>>> was created. >>>> -Bruno >>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>> I was referring to form widgets, not menu widgets. >>>>> >>>>> -Adrian >>>>> >>>>> Bruno Busco wrote: >>>>>> I do not see any -1 so... ;-) >>>>>> >>>>>> I think they are in the webapp becouse they were originally >>>>>> implemented as FTL files and then moved to XML when the menu >>>>>> widget >>>>>> was created. >>>>>> I personally converted lots of TabBar menus but at that time I >>>>>> named >>>>>> all files just Menus.xml and I did not move them to the widget >>>>>> folder >>>>>> but now may be its time to clean this up. >>>>>> >>>>>> -Bruno >>>>>> >>>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>>> The location of the form widget XML files has been discussed >>>>>>> before. >>>>>>> There >>>>>>> are two perspectives: 1) The form widget XML files belong with >>>>>>> the rest >>>>>>> of >>>>>>> the widget XML files in the widget folder, and 2) The form >>>>>>> widget XML >>>>>>> files >>>>>>> are part of the web application - so they belong in the webapp >>>>>>> folder. >>>>>>> >>>>>>> My personal preference is that they be kept with the other >>>>>>> widget XML >>>>>>> files, >>>>>>> but I'm sure others will disagree. >>>>>>> >>>>>>> -Adrian >>>>>>> >>>>>>> Erwan de FERRIERES wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> when looking at the party manager component, I've seen two >>>>>>>> things that >>>>>>>> aren't the same as the other components, and I was wondering >>>>>>>> if this was >>>>>>>> intentional or not yet done (in this case I will provide a >>>>>>>> patch to >>>>>>>> correct >>>>>>>> it) : >>>>>>>> >>>>>>>> * the file with the menus is named PartyMenus.xml, and in >>>>>>>> most of other >>>>>>>> components, it is just named Menus.xml. Should we name all >>>>>>>> the menus >>>>>>>> files >>>>>>>> by the name of the component and add Menus.xml to them, or >>>>>>>> just name >>>>>>>> them >>>>>>>> with Menus.xml ? >>>>>>>> >>>>>>>> * the file containing the forms in Party is located in >>>>>>>> webapp/partymgr/party/, but for most of the components, it is >>>>>>>> in >>>>>>>> widget/<component>/ or widget/<component>/forms. Should we >>>>>>>> move it to >>>>>>>> the >>>>>>>> same place as others ? >>>>>>>> >>>>>>>> Regards, >>>>>>>> |
Re: partymanager consistency with the other components
|
|
In reply to this post by Adrian Crum
Here is the old discussion
http://n4.nabble.com/What-is-the-standard-location-of-WebAppName-Forms-xml-files-td191548.html#a191549 I would also prefer to have all the widgets under widget folder. - Bilgin Adrian Crum wrote: > No, I didn't mean myself. I already stated that I would prefer them > kept in the widget folder. > > I tried to Google the conversation, but I can't find it. I recall > someone some time ago suggesting form widget XML files being put in > the widget folder, and you objected to it - saying graphic artists or > web authors would expect forms to be inside the webapp folder. You > have also used the same explanation for keeping scripts in the webapp > folder. > > -Adrian > > David E Jones wrote: >> >> Who are the "some developers" who believe that under the webapp >> folder is the best place for that? Do you mean yourself? If so, why >> do you like them there? If not, then whoever the "some developers" >> are... could you comment on why you like them there? >> >> That should be much easier to discuss than where this is going... >> >> -David >> >> >> On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: >> >>> No, that is not the reason they are there. As I said previously, >>> some developers believe that is the most appropriate place for them. >>> >>> -Adrian >>> >>> Bruno Busco wrote: >>>> The reason why some forms files are in the webapp is the same: >>>> becouse they were originally implemented as FTL files and then moved >>>> to XML when the FORM widget >>>> was created. >>>> -Bruno >>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>> I was referring to form widgets, not menu widgets. >>>>> >>>>> -Adrian >>>>> >>>>> Bruno Busco wrote: >>>>>> I do not see any -1 so... ;-) >>>>>> >>>>>> I think they are in the webapp becouse they were originally >>>>>> implemented as FTL files and then moved to XML when the menu widget >>>>>> was created. >>>>>> I personally converted lots of TabBar menus but at that time I named >>>>>> all files just Menus.xml and I did not move them to the widget >>>>>> folder >>>>>> but now may be its time to clean this up. >>>>>> >>>>>> -Bruno >>>>>> >>>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>>> The location of the form widget XML files has been discussed >>>>>>> before. >>>>>>> There >>>>>>> are two perspectives: 1) The form widget XML files belong with >>>>>>> the rest >>>>>>> of >>>>>>> the widget XML files in the widget folder, and 2) The form >>>>>>> widget XML >>>>>>> files >>>>>>> are part of the web application - so they belong in the webapp >>>>>>> folder. >>>>>>> >>>>>>> My personal preference is that they be kept with the other >>>>>>> widget XML >>>>>>> files, >>>>>>> but I'm sure others will disagree. >>>>>>> >>>>>>> -Adrian >>>>>>> >>>>>>> Erwan de FERRIERES wrote: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> when looking at the party manager component, I've seen two >>>>>>>> things that >>>>>>>> aren't the same as the other components, and I was wondering if >>>>>>>> this was >>>>>>>> intentional or not yet done (in this case I will provide a >>>>>>>> patch to >>>>>>>> correct >>>>>>>> it) : >>>>>>>> >>>>>>>> * the file with the menus is named PartyMenus.xml, and in most >>>>>>>> of other >>>>>>>> components, it is just named Menus.xml. Should we name all the >>>>>>>> menus >>>>>>>> files >>>>>>>> by the name of the component and add Menus.xml to them, or just >>>>>>>> name >>>>>>>> them >>>>>>>> with Menus.xml ? >>>>>>>> >>>>>>>> * the file containing the forms in Party is located in >>>>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>>>> widget/<component>/ or widget/<component>/forms. Should we move >>>>>>>> it to >>>>>>>> the >>>>>>>> same place as others ? >>>>>>>> >>>>>>>> Regards, >>>>>>>> >> >> |
Re: partymanager consistency with the other components
|
|
+1 for keeping all the widgets under "widget" folder.
-- Ashish On Wed, Oct 21, 2009 at 1:03 PM, Bilgin Ibryam <[hidden email]> wrote: > Here is the old discussion > http://n4.nabble.com/What-is-the-standard-location-of-WebAppName-Forms-xml-files-td191548.html#a191549 > I would also prefer to have all the widgets under widget folder. > > - Bilgin > > > > > Adrian Crum wrote: > >> No, I didn't mean myself. I already stated that I would prefer them kept >> in the widget folder. >> >> I tried to Google the conversation, but I can't find it. I recall someone >> some time ago suggesting form widget XML files being put in the widget >> folder, and you objected to it - saying graphic artists or web authors would >> expect forms to be inside the webapp folder. You have also used the same >> explanation for keeping scripts in the webapp folder. >> >> -Adrian >> >> David E Jones wrote: >> >>> >>> Who are the "some developers" who believe that under the webapp folder is >>> the best place for that? Do you mean yourself? If so, why do you like them >>> there? If not, then whoever the "some developers" are... could you comment >>> on why you like them there? >>> >>> That should be much easier to discuss than where this is going... >>> >>> -David >>> >>> >>> On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: >>> >>> No, that is not the reason they are there. As I said previously, some >>>> developers believe that is the most appropriate place for them. >>>> >>>> -Adrian >>>> >>>> Bruno Busco wrote: >>>> >>>>> The reason why some forms files are in the webapp is the same: >>>>> becouse they were originally implemented as FTL files and then moved >>>>> to XML when the FORM widget >>>>> was created. >>>>> -Bruno >>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>> >>>>>> I was referring to form widgets, not menu widgets. >>>>>> >>>>>> -Adrian >>>>>> >>>>>> Bruno Busco wrote: >>>>>> >>>>>>> I do not see any -1 so... ;-) >>>>>>> >>>>>>> I think they are in the webapp becouse they were originally >>>>>>> implemented as FTL files and then moved to XML when the menu widget >>>>>>> was created. >>>>>>> I personally converted lots of TabBar menus but at that time I named >>>>>>> all files just Menus.xml and I did not move them to the widget folder >>>>>>> but now may be its time to clean this up. >>>>>>> >>>>>>> -Bruno >>>>>>> >>>>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>>> >>>>>>>> The location of the form widget XML files has been discussed before. >>>>>>>> There >>>>>>>> are two perspectives: 1) The form widget XML files belong with the >>>>>>>> rest >>>>>>>> of >>>>>>>> the widget XML files in the widget folder, and 2) The form widget >>>>>>>> XML >>>>>>>> files >>>>>>>> are part of the web application - so they belong in the webapp >>>>>>>> folder. >>>>>>>> >>>>>>>> My personal preference is that they be kept with the other widget >>>>>>>> XML >>>>>>>> files, >>>>>>>> but I'm sure others will disagree. >>>>>>>> >>>>>>>> -Adrian >>>>>>>> >>>>>>>> Erwan de FERRIERES wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> when looking at the party manager component, I've seen two things >>>>>>>>> that >>>>>>>>> aren't the same as the other components, and I was wondering if >>>>>>>>> this was >>>>>>>>> intentional or not yet done (in this case I will provide a patch to >>>>>>>>> correct >>>>>>>>> it) : >>>>>>>>> >>>>>>>>> * the file with the menus is named PartyMenus.xml, and in most of >>>>>>>>> other >>>>>>>>> components, it is just named Menus.xml. Should we name all the >>>>>>>>> menus >>>>>>>>> files >>>>>>>>> by the name of the component and add Menus.xml to them, or just >>>>>>>>> name >>>>>>>>> them >>>>>>>>> with Menus.xml ? >>>>>>>>> >>>>>>>>> * the file containing the forms in Party is located in >>>>>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>>>>> widget/<component>/ or widget/<component>/forms. Should we move it >>>>>>>>> to >>>>>>>>> the >>>>>>>>> same place as others ? >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> >>>>>>>>> >>> >>> > |
Re: partymanager consistency with the other components
|
|
In reply to this post by Bilgin Ibryam-2
Maybe the tecnical documents should be enhanced to state more explicitly
where types of files should be located in applications, so that the learning curve decreases and a One Way of Working forms. 2009/10/21 Bilgin Ibryam <[hidden email]> > Here is the old discussion > http://n4.nabble.com/What-is-the-standard-location-of-WebAppName-Forms-xml-files-td191548.html#a191549 > I would also prefer to have all the widgets under widget folder. > > - Bilgin > > > > > Adrian Crum wrote: > >> No, I didn't mean myself. I already stated that I would prefer them kept >> in the widget folder. >> >> I tried to Google the conversation, but I can't find it. I recall someone >> some time ago suggesting form widget XML files being put in the widget >> folder, and you objected to it - saying graphic artists or web authors would >> expect forms to be inside the webapp folder. You have also used the same >> explanation for keeping scripts in the webapp folder. >> >> -Adrian >> >> David E Jones wrote: >> >>> >>> Who are the "some developers" who believe that under the webapp folder is >>> the best place for that? Do you mean yourself? If so, why do you like them >>> there? If not, then whoever the "some developers" are... could you comment >>> on why you like them there? >>> >>> That should be much easier to discuss than where this is going... >>> >>> -David >>> >>> >>> On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: >>> >>> No, that is not the reason they are there. As I said previously, some >>>> developers believe that is the most appropriate place for them. >>>> >>>> -Adrian >>>> >>>> Bruno Busco wrote: >>>> >>>>> The reason why some forms files are in the webapp is the same: >>>>> becouse they were originally implemented as FTL files and then moved >>>>> to XML when the FORM widget >>>>> was created. >>>>> -Bruno >>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>> >>>>>> I was referring to form widgets, not menu widgets. >>>>>> >>>>>> -Adrian >>>>>> >>>>>> Bruno Busco wrote: >>>>>> >>>>>>> I do not see any -1 so... ;-) >>>>>>> >>>>>>> I think they are in the webapp becouse they were originally >>>>>>> implemented as FTL files and then moved to XML when the menu widget >>>>>>> was created. >>>>>>> I personally converted lots of TabBar menus but at that time I named >>>>>>> all files just Menus.xml and I did not move them to the widget folder >>>>>>> but now may be its time to clean this up. >>>>>>> >>>>>>> -Bruno >>>>>>> >>>>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>>> >>>>>>>> The location of the form widget XML files has been discussed before. >>>>>>>> There >>>>>>>> are two perspectives: 1) The form widget XML files belong with the >>>>>>>> rest >>>>>>>> of >>>>>>>> the widget XML files in the widget folder, and 2) The form widget >>>>>>>> XML >>>>>>>> files >>>>>>>> are part of the web application - so they belong in the webapp >>>>>>>> folder. >>>>>>>> >>>>>>>> My personal preference is that they be kept with the other widget >>>>>>>> XML >>>>>>>> files, >>>>>>>> but I'm sure others will disagree. >>>>>>>> >>>>>>>> -Adrian >>>>>>>> >>>>>>>> Erwan de FERRIERES wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> when looking at the party manager component, I've seen two things >>>>>>>>> that >>>>>>>>> aren't the same as the other components, and I was wondering if >>>>>>>>> this was >>>>>>>>> intentional or not yet done (in this case I will provide a patch to >>>>>>>>> correct >>>>>>>>> it) : >>>>>>>>> >>>>>>>>> * the file with the menus is named PartyMenus.xml, and in most of >>>>>>>>> other >>>>>>>>> components, it is just named Menus.xml. Should we name all the >>>>>>>>> menus >>>>>>>>> files >>>>>>>>> by the name of the component and add Menus.xml to them, or just >>>>>>>>> name >>>>>>>>> them >>>>>>>>> with Menus.xml ? >>>>>>>>> >>>>>>>>> * the file containing the forms in Party is located in >>>>>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>>>>> widget/<component>/ or widget/<component>/forms. Should we move it >>>>>>>>> to >>>>>>>>> the >>>>>>>>> same place as others ? >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> >>>>>>>>> >>> >>> > |
Re: partymanager consistency with the other components
Administrator
|
Please suggest a place...
Jacques From: "Pierre Smits" <[hidden email]> > Maybe the tecnical documents should be enhanced to state more explicitly > where types of files should be located in applications, so that the learning > curve decreases and a One Way of Working forms. > > 2009/10/21 Bilgin Ibryam <[hidden email]> > >> Here is the old discussion >> http://n4.nabble.com/What-is-the-standard-location-of-WebAppName-Forms-xml-files-td191548.html#a191549 >> I would also prefer to have all the widgets under widget folder. >> >> - Bilgin >> >> >> >> >> Adrian Crum wrote: >> >>> No, I didn't mean myself. I already stated that I would prefer them kept >>> in the widget folder. >>> >>> I tried to Google the conversation, but I can't find it. I recall someone >>> some time ago suggesting form widget XML files being put in the widget >>> folder, and you objected to it - saying graphic artists or web authors would >>> expect forms to be inside the webapp folder. You have also used the same >>> explanation for keeping scripts in the webapp folder. >>> >>> -Adrian >>> >>> David E Jones wrote: >>> >>>> >>>> Who are the "some developers" who believe that under the webapp folder is >>>> the best place for that? Do you mean yourself? If so, why do you like them >>>> there? If not, then whoever the "some developers" are... could you comment >>>> on why you like them there? >>>> >>>> That should be much easier to discuss than where this is going... >>>> >>>> -David >>>> >>>> >>>> On Oct 20, 2009, at 11:01 AM, Adrian Crum wrote: >>>> >>>> No, that is not the reason they are there. As I said previously, some >>>>> developers believe that is the most appropriate place for them. >>>>> >>>>> -Adrian >>>>> >>>>> Bruno Busco wrote: >>>>> >>>>>> The reason why some forms files are in the webapp is the same: >>>>>> becouse they were originally implemented as FTL files and then moved >>>>>> to XML when the FORM widget >>>>>> was created. >>>>>> -Bruno >>>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>> >>>>>>> I was referring to form widgets, not menu widgets. >>>>>>> >>>>>>> -Adrian >>>>>>> >>>>>>> Bruno Busco wrote: >>>>>>> >>>>>>>> I do not see any -1 so... ;-) >>>>>>>> >>>>>>>> I think they are in the webapp becouse they were originally >>>>>>>> implemented as FTL files and then moved to XML when the menu widget >>>>>>>> was created. >>>>>>>> I personally converted lots of TabBar menus but at that time I named >>>>>>>> all files just Menus.xml and I did not move them to the widget folder >>>>>>>> but now may be its time to clean this up. >>>>>>>> >>>>>>>> -Bruno >>>>>>>> >>>>>>>> 2009/10/20 Adrian Crum <[hidden email]>: >>>>>>>> >>>>>>>>> The location of the form widget XML files has been discussed before. >>>>>>>>> There >>>>>>>>> are two perspectives: 1) The form widget XML files belong with the >>>>>>>>> rest >>>>>>>>> of >>>>>>>>> the widget XML files in the widget folder, and 2) The form widget >>>>>>>>> XML >>>>>>>>> files >>>>>>>>> are part of the web application - so they belong in the webapp >>>>>>>>> folder. >>>>>>>>> >>>>>>>>> My personal preference is that they be kept with the other widget >>>>>>>>> XML >>>>>>>>> files, >>>>>>>>> but I'm sure others will disagree. >>>>>>>>> >>>>>>>>> -Adrian >>>>>>>>> >>>>>>>>> Erwan de FERRIERES wrote: >>>>>>>>> >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> when looking at the party manager component, I've seen two things >>>>>>>>>> that >>>>>>>>>> aren't the same as the other components, and I was wondering if >>>>>>>>>> this was >>>>>>>>>> intentional or not yet done (in this case I will provide a patch to >>>>>>>>>> correct >>>>>>>>>> it) : >>>>>>>>>> >>>>>>>>>> * the file with the menus is named PartyMenus.xml, and in most of >>>>>>>>>> other >>>>>>>>>> components, it is just named Menus.xml. Should we name all the >>>>>>>>>> menus >>>>>>>>>> files >>>>>>>>>> by the name of the component and add Menus.xml to them, or just >>>>>>>>>> name >>>>>>>>>> them >>>>>>>>>> with Menus.xml ? >>>>>>>>>> >>>>>>>>>> * the file containing the forms in Party is located in >>>>>>>>>> webapp/partymgr/party/, but for most of the components, it is in >>>>>>>>>> widget/<component>/ or widget/<component>/forms. Should we move it >>>>>>>>>> to >>>>>>>>>> the >>>>>>>>>> same place as others ? >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> >>>>>>>>>> >>>> >>>> >> > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |