removing some code from the SVN

[Si Chen-2]

Hi.  What should be our policy for removing code when we have a  
better implementation?  We originally put some code in OrderServices  
for auto-exploding marketing packages, but now with Jacopo's new auto  
production run that code is no longer needed by us at least.  I was  
also never fully satisfied with the code -- it caused all sorts of  
problems when there were fractions or adjustments, so I'd like to  
remove.  Is that OK?

Si

[BJ Freeman]

I would like to see both on additions, changes, removing, a comment left
in the code.
in your case a simple removed see such and such.
Also like to see a Jira with the deleted code so someone could uses it
if they wanted.

Si Chen sent the following on 6/23/06 12:07 PM:

> Hi.  What should be our policy for removing code when we have a  better
> implementation?  We originally put some code in OrderServices  for
> auto-exploding marketing packages, but now with Jacopo's new auto  
> production run that code is no longer needed by us at least.  I was  
> also never fully satisfied with the code -- it caused all sorts of  
> problems when there were fractions or adjustments, so I'd like to  
> remove.  Is that OK?
>
> Si
>

[Jacques Le Roux]

I agree with BJ

Jacques

> I would like to see both on additions, changes, removing, a comment left
> in the code.
> in your case a simple removed see such and such.
> Also like to see a Jira with the deleted code so someone could uses it
> if they wanted.
>
> Si Chen sent the following on 6/23/06 12:07 PM:
> > Hi.  What should be our policy for removing code when we have a  better
> > implementation?  We originally put some code in OrderServices  for
> > auto-exploding marketing packages, but now with Jacopo's new auto  
> > production run that code is no longer needed by us at least.  I was  
> > also never fully satisfied with the code -- it caused all sorts of  
> > problems when there were fractions or adjustments, so I'd like to  
> > remove.  Is that OK?
> >
> > Si
> >

[Vinay Agarwal]

I think any code (or entity) intended for removal should be marked
"deprecated" for some period so that anyone using them have time to change
their implementation. Subsequently, it should be simply removed.

Regards,
Vinay Agarwal


-----Original Message-----
From: Jacques Le Roux [mailto:[hidden email]]
Sent: Friday, June 23, 2006 2:24 PM
To: [hidden email]
Subject: Re: removing some code from the SVN

I agree with BJ

Jacques

> I would like to see both on additions, changes, removing, a comment
> left in the code.
> in your case a simple removed see such and such.
> Also like to see a Jira with the deleted code so someone could uses it
> if they wanted.
>
> Si Chen sent the following on 6/23/06 12:07 PM:
> > Hi.  What should be our policy for removing code when we have a  
> > better implementation?  We originally put some code in OrderServices  
> > for auto-exploding marketing packages, but now with Jacopo's new
> > auto production run that code is no longer needed by us at least.  I
> > was also never fully satisfied with the code -- it caused all sorts
> > of problems when there were fractions or adjustments, so I'd like to
> > remove.  Is that OK?
> >
> > Si
> >

[Si Chen-2]

Yeah, I think that's a good idea.  Let me mark up some stuff.  SVN r  
7853.


Si


On Jun 23, 2006, at 2:58 PM, Vinay Agarwal wrote:

> I think any code (or entity) intended for removal should be marked
> "deprecated" for some period so that anyone using them have time to  
> change
> their implementation. Subsequently, it should be simply removed.
>
> Regards,
> Vinay Agarwal
>
>
> -----Original Message-----
> From: Jacques Le Roux [mailto:[hidden email]]
> Sent: Friday, June 23, 2006 2:24 PM
> To: [hidden email]
> Subject: Re: removing some code from the SVN
>
> I agree with BJ
>
> Jacques
>
>
>> I would like to see both on additions, changes, removing, a comment
>> left in the code.
>> in your case a simple removed see such and such.
>> Also like to see a Jira with the deleted code so someone could  
>> uses it
>> if they wanted.
>>
>> Si Chen sent the following on 6/23/06 12:07 PM:
>>> Hi.  What should be our policy for removing code when we have a
>>> better implementation?  We originally put some code in OrderServices
>>> for auto-exploding marketing packages, but now with Jacopo's new
>>> auto production run that code is no longer needed by us at least.  I
>>> was also never fully satisfied with the code -- it caused all sorts
>>> of problems when there were fractions or adjustments, so I'd like to
>>> remove.  Is that OK?
>>>
>>> Si
>>>

[David E. Jones]

For entities that are now longer used: they should be prefixed with "Old" and then the table-name attribute should be used to point to the original default table name.

For code that is deprecated and no longer used in the project: just kill it and put a good comment in the commit log, unless perhaps there is some suspicion that the code is widely used of course... If there is anyone using it they will have been using it for a while, and as long as it is fairly loosely coupled and isolated then they can always pull the stuff from previous SVN versions as needed.

-David


Si Chen wrote:
> Hi.  What should be our policy for removing code when we have a better
> implementation?  We originally put some code in OrderServices for
> auto-exploding marketing packages, but now with Jacopo's new auto
> production run that code is no longer needed by us at least.  I was also
> never fully satisfied with the code -- it caused all sorts of problems
> when there were fractions or adjustments, so I'd like to remove.  Is
> that OK?
>
> Si

[Jacopo Cappellato]

Si,

that code was causing a major issue: non-product order items were
excluded from the order; for this reason I've commented, in the
createOrder service the call to the autoExplode* method in rev 7860.

I think that now that code can be removed, could you have a look at it?

Thanks,

Jacopo

Si Chen wrote:

> Yeah, I think that's a good idea.  Let me mark up some stuff.  SVN r 7853.
>
>
> Si
>
>
> On Jun 23, 2006, at 2:58 PM, Vinay Agarwal wrote:
>
>> I think any code (or entity) intended for removal should be marked
>> "deprecated" for some period so that anyone using them have time to
>> change
>> their implementation. Subsequently, it should be simply removed.
>>
>> Regards,
>> Vinay Agarwal
>>
>>
>> -----Original Message-----
>> From: Jacques Le Roux [mailto:[hidden email]]
>> Sent: Friday, June 23, 2006 2:24 PM
>> To: [hidden email]
>> Subject: Re: removing some code from the SVN
>>
>> I agree with BJ
>>
>> Jacques
>>
>>
>>> I would like to see both on additions, changes, removing, a comment
>>> left in the code.
>>> in your case a simple removed see such and such.
>>> Also like to see a Jira with the deleted code so someone could uses it
>>> if they wanted.
>>>
>>> Si Chen sent the following on 6/23/06 12:07 PM:
>>>> Hi.  What should be our policy for removing code when we have a
>>>> better implementation?  We originally put some code in OrderServices
>>>> for auto-exploding marketing packages, but now with Jacopo's new
>>>> auto production run that code is no longer needed by us at least.  I
>>>> was also never fully satisfied with the code -- it caused all sorts
>>>> of problems when there were fractions or adjustments, so I'd like to
>>>> remove.  Is that OK?
>>>>
>>>> Si
>>>>
>
>