sort-field="true" by default?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

sort-field="true" by default?

Jacques Le Roux
Administrator
Hi,

I was wondering why we don't have  <<sort-field="true">> by default. I looked for an explanation or a discussion and found
https://issues.apache.org/jira/browse/OFBIZ-1943?focusedCommentId=12632303
Could we not try to finally implement <<sort-field="true">> by default, I found it works most of the time but did not review the code in details yet.

Thanks for your opinions

Jacques
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Jacques Le Roux
Administrator
Le 07/07/2015 15:08, Jacques Le Roux a écrit :
> Hi,
>
> I was wondering why we don't have <<sort-field="true">> by default. I looked for an explanation or a discussion and found
> https://issues.apache.org/jira/browse/OFBIZ-1943?focusedCommentId=12632303
> Could we not try to finally implement <<sort-field="true">> by default, I found it works most of the time but did not review the code in details yet.

For instance in lookups lists

jacques

>
> Thanks for your opinions
>
> Jacques
>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Pierre Smits
In reply to this post by Jacques Le Roux
Being able to use default setting enhances the user experience
tremendously. Yet we must not forget that hard coding such has an impact
too.

So we must ensure that any default setting can be adjusted through
configuration.

Best regards,

Pierre
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Jacques Le Roux
Administrator
Configuration is easy here, just put sort-field="false" to override the new default (currently sort-field="false")

Jacques

Le 07/07/2015 16:47, Pierre Smits a écrit :

> Being able to use default setting enhances the user experience
> tremendously. Yet we must not forget that hard coding such has an impact
> too.
>
> So we must ensure that any default setting can be adjusted through
> configuration.
>
> Best regards,
>
> Pierre
>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Pierre Smits
Where?


Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
[hidden email]> wrote:

> Configuration is easy here, just put sort-field="false" to override the
> new default (currently sort-field="false")
>
> Jacques
>
>
> Le 07/07/2015 16:47, Pierre Smits a écrit :
>
>> Being able to use default setting enhances the user experience
>> tremendously. Yet we must not forget that hard coding such has an impact
>> too.
>>
>> So we must ensure that any default setting can be adjusted through
>> configuration.
>>
>> Best regards,
>>
>> Pierre
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Jacques Le Roux
Administrator
I speak about the sort-order attribute of the field element in form widget. It makes sense only in list/multi.

Look for <xs:attribute name="sort-field" default="false"> at http://ofbiz.apache.org/dtds/widget-form.xsd

Another attribute which needs documentation. Though this one is quite obvious and related attributes (sort-field-style, sort-field-help-text,
sort-field-asc-style, "sort-field-desc-style) are documented

Jacques

Le 07/07/2015 23:21, Pierre Smits a écrit :

> Where?
>
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Configuration is easy here, just put sort-field="false" to override the
>> new default (currently sort-field="false")
>>
>> Jacques
>>
>>
>> Le 07/07/2015 16:47, Pierre Smits a écrit :
>>
>>> Being able to use default setting enhances the user experience
>>> tremendously. Yet we must not forget that hard coding such has an impact
>>> too.
>>>
>>> So we must ensure that any default setting can be adjusted through
>>> configuration.
>>>
>>> Best regards,
>>>
>>> Pierre
>>>
>>>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Pierre Smits
I am talking about the same.

Best regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Jul 8, 2015 at 9:09 AM, Jacques Le Roux <
[hidden email]> wrote:

> I speak about the sort-order attribute of the field element in form
> widget. It makes sense only in list/multi.
>
> Look for <xs:attribute name="sort-field" default="false"> at
> http://ofbiz.apache.org/dtds/widget-form.xsd
>
> Another attribute which needs documentation. Though this one is quite
> obvious and related attributes (sort-field-style, sort-field-help-text,
> sort-field-asc-style, "sort-field-desc-style) are documented
>
> Jacques
>
> Le 07/07/2015 23:21, Pierre Smits a écrit :
>
>> Where?
>>
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>  Configuration is easy here, just put sort-field="false" to override the
>>> new default (currently sort-field="false")
>>>
>>> Jacques
>>>
>>>
>>> Le 07/07/2015 16:47, Pierre Smits a écrit :
>>>
>>>  Being able to use default setting enhances the user experience
>>>> tremendously. Yet we must not forget that hard coding such has an impact
>>>> too.
>>>>
>>>> So we must ensure that any default setting can be adjusted through
>>>> configuration.
>>>>
>>>> Best regards,
>>>>
>>>> Pierre
>>>>
>>>>
>>>>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Jacques Le Roux
Administrator
Imagine if we had to have a mean to configure each default?

If in a project the contrary seems better then, yes why not a config but OOTB I see no reasons. It's now false we would just turn it to true.

Anyway this needs to be checked before being applied. It seems Bruno has some concerns, I did not get  a chance to review details yet

Jacques

Le 08/07/2015 09:14, Pierre Smits a écrit :

> I am talking about the same.
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
> On Wed, Jul 8, 2015 at 9:09 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> I speak about the sort-order attribute of the field element in form
>> widget. It makes sense only in list/multi.
>>
>> Look for <xs:attribute name="sort-field" default="false"> at
>> http://ofbiz.apache.org/dtds/widget-form.xsd
>>
>> Another attribute which needs documentation. Though this one is quite
>> obvious and related attributes (sort-field-style, sort-field-help-text,
>> sort-field-asc-style, "sort-field-desc-style) are documented
>>
>> Jacques
>>
>> Le 07/07/2015 23:21, Pierre Smits a écrit :
>>
>>> Where?
>>>
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>> On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>   Configuration is easy here, just put sort-field="false" to override the
>>>> new default (currently sort-field="false")
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 07/07/2015 16:47, Pierre Smits a écrit :
>>>>
>>>>   Being able to use default setting enhances the user experience
>>>>> tremendously. Yet we must not forget that hard coding such has an impact
>>>>> too.
>>>>>
>>>>> So we must ensure that any default setting can be adjusted through
>>>>> configuration.
>>>>>
>>>>> Best regards,
>>>>>
>>>>> Pierre
>>>>>
>>>>>
>>>>>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Pierre Smits
Rome wasn't build in one day. And it still isn't perfect.

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

On Wed, Jul 8, 2015 at 3:44 PM, Jacques Le Roux <
[hidden email]> wrote:

> Imagine if we had to have a mean to configure each default?
>
> If in a project the contrary seems better then, yes why not a config but
> OOTB I see no reasons. It's now false we would just turn it to true.
>
> Anyway this needs to be checked before being applied. It seems Bruno has
> some concerns, I did not get  a chance to review details yet
>
> Jacques
>
> Le 08/07/2015 09:14, Pierre Smits a écrit :
>
>> I am talking about the same.
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Wed, Jul 8, 2015 at 9:09 AM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>  I speak about the sort-order attribute of the field element in form
>>> widget. It makes sense only in list/multi.
>>>
>>> Look for <xs:attribute name="sort-field" default="false"> at
>>> http://ofbiz.apache.org/dtds/widget-form.xsd
>>>
>>> Another attribute which needs documentation. Though this one is quite
>>> obvious and related attributes (sort-field-style, sort-field-help-text,
>>> sort-field-asc-style, "sort-field-desc-style) are documented
>>>
>>> Jacques
>>>
>>> Le 07/07/2015 23:21, Pierre Smits a écrit :
>>>
>>>  Where?
>>>>
>>>>
>>>> Pierre Smits
>>>>
>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>
>>>> Services & Solutions for Cloud-
>>>> Based Manufacturing, Professional
>>>> Services and Retail & Trade
>>>> http://www.orrtiz.com
>>>>
>>>> On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
>>>> [hidden email]> wrote:
>>>>
>>>>   Configuration is easy here, just put sort-field="false" to override
>>>> the
>>>>
>>>>> new default (currently sort-field="false")
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 07/07/2015 16:47, Pierre Smits a écrit :
>>>>>
>>>>>   Being able to use default setting enhances the user experience
>>>>>
>>>>>> tremendously. Yet we must not forget that hard coding such has an
>>>>>> impact
>>>>>> too.
>>>>>>
>>>>>> So we must ensure that any default setting can be adjusted through
>>>>>> configuration.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Pierre
>>>>>>
>>>>>>
>>>>>>
>>>>>>
Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Nicolas Malin-2
In reply to this post by Jacques Le Roux
Jacques this idea crossed my brain some time ago but I don't found a
real advantage.

If each field are sorted, we need to ensure that the
service/entity-find/script to populate the list can use the sort field.
I'm not optimist to believe that more than half fields present on all
form can be cover natively. For end user when he would clic on header
field list to sort the list, nothing would be realize (it's just
irritating).

We can use this idea with a form analyse to detect two case, if the form
action call the performFind or only one entity-find, check for each
form's field if the modelEntity related to entityName contains also the
same field, automatically set by default to sort-field="Y"

Nicolas

Le 08/07/2015 15:44, Jacques Le Roux a écrit :

> Imagine if we had to have a mean to configure each default?
>
> If in a project the contrary seems better then, yes why not a config
> but OOTB I see no reasons. It's now false we would just turn it to true.
>
> Anyway this needs to be checked before being applied. It seems Bruno
> has some concerns, I did not get  a chance to review details yet
>
> Jacques
>
> Le 08/07/2015 09:14, Pierre Smits a écrit :
>> I am talking about the same.
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>> On Wed, Jul 8, 2015 at 9:09 AM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> I speak about the sort-order attribute of the field element in form
>>> widget. It makes sense only in list/multi.
>>>
>>> Look for <xs:attribute name="sort-field" default="false"> at
>>> http://ofbiz.apache.org/dtds/widget-form.xsd
>>>
>>> Another attribute which needs documentation. Though this one is quite
>>> obvious and related attributes (sort-field-style, sort-field-help-text,
>>> sort-field-asc-style, "sort-field-desc-style) are documented
>>>
>>> Jacques
>>>
>>> Le 07/07/2015 23:21, Pierre Smits a écrit :
>>>
>>>> Where?
>>>>
>>>>
>>>> Pierre Smits
>>>>
>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>
>>>> Services & Solutions for Cloud-
>>>> Based Manufacturing, Professional
>>>> Services and Retail & Trade
>>>> http://www.orrtiz.com
>>>>
>>>> On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
>>>> [hidden email]> wrote:
>>>>
>>>>   Configuration is easy here, just put sort-field="false" to
>>>> override the
>>>>> new default (currently sort-field="false")
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 07/07/2015 16:47, Pierre Smits a écrit :
>>>>>
>>>>>   Being able to use default setting enhances the user experience
>>>>>> tremendously. Yet we must not forget that hard coding such has an
>>>>>> impact
>>>>>> too.
>>>>>>
>>>>>> So we must ensure that any default setting can be adjusted through
>>>>>> configuration.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Pierre
>>>>>>
>>>>>>
>>>>>>

Reply | Threaded
Open this post in threaded view
|

Re: sort-field="true" by default?

Gil Portenseigne
Hi all,

I agree that sort-field to true by default could do much damage than
benefit, moreover on field populated in row-action. What is the best,
let unactive functionnalities and active them when needed, or set active
and unactive when it's not working ?
With an integrator point of view, I prefer the first one.

To dig Nicolas Idea, using default-entity-name in form header could be a
way to automatically set up default sort-field to true. But not sure
it's a good idea.

Gil

On 11/07/2015 22:34, Nicolas Malin wrote:

> Jacques this idea crossed my brain some time ago but I don't found a
> real advantage.
>
> If each field are sorted, we need to ensure that the
> service/entity-find/script to populate the list can use the sort
> field. I'm not optimist to believe that more than half fields present
> on all form can be cover natively. For end user when he would clic on
> header field list to sort the list, nothing would be realize (it's
> just irritating).
>
> We can use this idea with a form analyse to detect two case, if the
> form action call the performFind or only one entity-find, check for
> each form's field if the modelEntity related to entityName contains
> also the same field, automatically set by default to sort-field="Y"
>
> Nicolas
>
> Le 08/07/2015 15:44, Jacques Le Roux a écrit :
>> Imagine if we had to have a mean to configure each default?
>>
>> If in a project the contrary seems better then, yes why not a config
>> but OOTB I see no reasons. It's now false we would just turn it to true.
>>
>> Anyway this needs to be checked before being applied. It seems Bruno
>> has some concerns, I did not get  a chance to review details yet
>>
>> Jacques
>>
>> Le 08/07/2015 09:14, Pierre Smits a écrit :
>>> I am talking about the same.
>>>
>>> Best regards,
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>> On Wed, Jul 8, 2015 at 9:09 AM, Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>> I speak about the sort-order attribute of the field element in form
>>>> widget. It makes sense only in list/multi.
>>>>
>>>> Look for <xs:attribute name="sort-field" default="false"> at
>>>> http://ofbiz.apache.org/dtds/widget-form.xsd
>>>>
>>>> Another attribute which needs documentation. Though this one is quite
>>>> obvious and related attributes (sort-field-style,
>>>> sort-field-help-text,
>>>> sort-field-asc-style, "sort-field-desc-style) are documented
>>>>
>>>> Jacques
>>>>
>>>> Le 07/07/2015 23:21, Pierre Smits a écrit :
>>>>
>>>>> Where?
>>>>>
>>>>>
>>>>> Pierre Smits
>>>>>
>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>
>>>>> Services & Solutions for Cloud-
>>>>> Based Manufacturing, Professional
>>>>> Services and Retail & Trade
>>>>> http://www.orrtiz.com
>>>>>
>>>>> On Tue, Jul 7, 2015 at 11:06 PM, Jacques Le Roux <
>>>>> [hidden email]> wrote:
>>>>>
>>>>>   Configuration is easy here, just put sort-field="false" to
>>>>> override the
>>>>>> new default (currently sort-field="false")
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 07/07/2015 16:47, Pierre Smits a écrit :
>>>>>>
>>>>>>   Being able to use default setting enhances the user experience
>>>>>>> tremendously. Yet we must not forget that hard coding such has
>>>>>>> an impact
>>>>>>> too.
>>>>>>>
>>>>>>> So we must ensure that any default setting can be adjusted through
>>>>>>> configuration.
>>>>>>>
>>>>>>> Best regards,
>>>>>>>
>>>>>>> Pierre
>>>>>>>
>>>>>>>
>>>>>>>
>