svn commit: r1100197 - /ofbiz/trunk/framework/security/entitydef/entitymodel.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1100197 - /ofbiz/trunk/framework/security/entitydef/entitymodel.xml

jleroux@apache.org
Author: jleroux
Date: Fri May  6 13:07:18 2011
New Revision: 1100197

URL: http://svn.apache.org/viewvc?rev=1100197&view=rev
Log:
Closes <<Caching is used by org.ofbiz.webapp.control.ProtectViewWorker(line 68) for UserLoginAndProtectedView (since changeset r1075350), but the view has set never-cache="true">> reported by Jonas Hoef at https://issues.apache.org/jira/browse/OFBIZ-4243

I wondered if I should not remove the event from the common-controller since I guess this is rarely used. But, as the functionality is available OOTB, I preferred to keep it as is. So I simply remove the never-cache from  UserLoginAndProtectedView view-entity. Since it will almost ever be empty, no memory issues and better performance is expected. If I remember well, at the moment I committed this, I checked: the performance impact was already not noticeable (only one check).

Modified:
    ofbiz/trunk/framework/security/entitydef/entitymodel.xml

Modified: ofbiz/trunk/framework/security/entitydef/entitymodel.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/security/entitydef/entitymodel.xml?rev=1100197&r1=1100196&r2=1100197&view=diff
==============================================================================
--- ofbiz/trunk/framework/security/entitydef/entitymodel.xml (original)
+++ ofbiz/trunk/framework/security/entitydef/entitymodel.xml Fri May  6 13:07:18 2011
@@ -225,7 +225,6 @@ under the License.
     </entity>
     <view-entity entity-name="UserLoginAndProtectedView"
           package-name="org.ofbiz.security.securitygroup"
-          never-cache="true"
           title="UserLogin And ProtectedView View Entity">
       <member-entity entity-alias="ULSGPV" entity-name="UserLoginSecurityGroup"/>
       <member-entity entity-alias="PV" entity-name="ProtectedView"/>