what happens when orders have both credit cards and billing accounts?

[Si Chen-2]

Hi.

We just noticed that if an order had a billing account  
(OrderHeader.billingAccountId) and a credit card associated with it,  
only the credit card should be charged.  This should be the right  
behavior if the billing account is used for wholesale customers as a  
line of credit, but if the billing account is a retail consumer's  
store credit (arising from a return), then most retailers would want  
the store credit used up first.

So, how about we add a ProductStore field to control whether the  
billing account should be used before other payment methods?

Si

[cjhowe]

The entire order/payment/bililng account
implementation is quite a bit more complicated than it
needs to be.  I think the following rational is the
reason.

OFBiz associates a payment method with an order.  

I think it would be much more transparent and more
correct if payment methods were only associated with
invoices. (ie you pay invoices, you don't pay orders).
 This would require the creation of a "CheckoutMethod"
(which is not a payment method) which would be
associated with orders instead of payment methods.
Instead of OrderPaymentPreferences, you would have
OrderCheckoutPreferences and all of the routines run
against that.

This way you're never confusing charging to a billing
account as a payment.

This helps solve your issue here by having different
services for different folks instead of a flag as this
issue is a bit more complex depending on a company's
actual policies.


--- Si Chen <[hidden email]> wrote:

> Hi.
>
> We just noticed that if an order had a billing
> account  
> (OrderHeader.billingAccountId) and a credit card
> associated with it,  
> only the credit card should be charged.  This should
> be the right  
> behavior if the billing account is used for
> wholesale customers as a  
> line of credit, but if the billing account is a
> retail consumer's  
> store credit (arising from a return), then most
> retailers would want  
> the store credit used up first.
>
> So, how about we add a ProductStore field to control
> whether the  
> billing account should be used before other payment
> methods?
>
> Si
>

[Andrew Sykes]

Si,

Perhaps this is better as a type than a boolean field, I have seen
people with exotic setups like £1 credit for each £1 spent etc...

Andrew

On Thu, 2006-07-13 at 12:24 -0700, Si Chen wrote:

> Hi.
>
> We just noticed that if an order had a billing account  
> (OrderHeader.billingAccountId) and a credit card associated with it,  
> only the credit card should be charged.  This should be the right  
> behavior if the billing account is used for wholesale customers as a  
> line of credit, but if the billing account is a retail consumer's  
> store credit (arising from a return), then most retailers would want  
> the store credit used up first.
>
> So, how about we add a ProductStore field to control whether the  
> billing account should be used before other payment methods?
>
> Si

--
Kind Regards
Andrew Sykes <[hidden email]>
Sykes Development Ltd
http://www.sykesdevelopment.com

[David E Jones-2]

The general idea with PaymentPreferences (regardless of what each PaymentPreference represents) is that all but one should have a limit amount, and the one that does not have a limit amount inherits the balance of the order after the other PPs have been considered.

If this is properly applied in the checkout process then no such preference should be needed. I know there are issues with the current code setting the max amount automatically, it is not extremely well implemented for the case where a user gets to the order verification page and then goes back to earlier pages in the checkout process (ie it leaves the max amount for the PP even if the order total has changed).

I may be wrong, but it seems this pattern of having all PPs but one contain a max amount and putting the rest on the remaining PP would allow the user to select where things should go and support both scenarios you mentioned.

-David


Si Chen wrote:

> Hi.
>
> We just noticed that if an order had a billing account
> (OrderHeader.billingAccountId) and a credit card associated with it,
> only the credit card should be charged.  This should be the right
> behavior if the billing account is used for wholesale customers as a
> line of credit, but if the billing account is a retail consumer's store
> credit (arising from a return), then most retailers would want the store
> credit used up first.
>
> So, how about we add a ProductStore field to control whether the billing
> account should be used before other payment methods?
>
> Si