Dev - Code review, please (UoM conversion enhancement)

[Carl Sopchak]

Hi,

Since this is my first shot at modifying OFBiz, I though I'd ask for the
community's review of my changes to the CommonServices.xml file that allow
for custom UoM conversions.  Please feel free to rip it to shreds, if
warranted.  I'd rather learn how to do these things right now than 3 months
from now...

I've attached both the diff of the changes as well as the resulting complete
CommonServices.xml for review.

Thanks,

Carl

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Jacopo Cappellato]

Hi Carl,

at a first look it seems rather good to me...

Jacopo

Carl Sopchak wrote:

> Hi,
>
> Since this is my first shot at modifying OFBiz, I though I'd ask for the
> community's review of my changes to the CommonServices.xml file that allow
> for custom UoM conversions.  Please feel free to rip it to shreds, if
> warranted.  I'd rather learn how to do these things right now than 3 months
> from now...
>
> I've attached both the diff of the changes as well as the resulting complete
> CommonServices.xml for review.
>
> Thanks,
>
> Carl
>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev