I think userPrefGroupId field on UserPrefGroupType should be userPrefGroupTypeId, as per conventions

[Vikas Mayur-3]

dev,

WDYT ?

If agreed I would submit a patch.


- Vikas

[Vikas Mayur-3]

or entity name would be UserPrefGroup and not UserPrefGroupType as we  
are actually creating a group of User Preferences (This is what I  
understand with the cursory view of data, but I may be wrong).

- Vikas

On Oct 7, 2008, at 11:55 AM, Vikas Mayur wrote:

> dev,
>
> WDYT ?
>
> If agreed I would submit a patch.
>
>
> - Vikas

[Jacques Le Roux]

+1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)

Jacques

From: "Vikas Mayur" <[hidden email]>
> dev,
>
> WDYT ?
>
> If agreed I would submit a patch.
>
>
> - Vikas

[Vikas Mayur-3]

Thanks Jacques for interest.

Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 
, as it has framework files and I do not have rights.

- Vikas

On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:

> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)
>
> Jacques
>
> From: "Vikas Mayur" <[hidden email]>
>> dev,
>> WDYT ?
>> If agreed I would submit a patch.
>> - Vikas

[Jacques Le Roux]

Hi Vikas,

Did not look into detail yet, but did you think about any needs to fill
http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions ?

Jacques

From: "Vikas Mayur" <[hidden email]>

> Thanks Jacques for interest.
>
> Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 , as it has framework files and I do not have rights.
>
> - Vikas
>
> On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:
>
>> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)
>>
>> Jacques
>>
>> From: "Vikas Mayur" <[hidden email]>
>>> dev,
>>> WDYT ?
>>> If agreed I would submit a patch.
>>> - Vikas
>

[Vikas Mayur-3]

I think it would be good to document such change.

- Vikas

On Oct 13, 2008, at 8:36 PM, Jacques Le Roux wrote:

> Hi Vikas,
>
> Did not look into detail yet, but did you think about any needs to  
> fill http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions 
>  ?
>
> Jacques
>
> From: "Vikas Mayur" <[hidden email]>
>> Thanks Jacques for interest.
>>
>> Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 
>>  , as it has framework files and I do not have rights.
>>
>> - Vikas
>>
>> On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:
>>
>>> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)
>>>
>>> Jacques
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>> dev,
>>>> WDYT ?
>>>> If agreed I would submit a patch.
>>>> - Vikas
>

[Jacques Le Roux]

Hi Vikas,

I'd prefer to wait, before committing, that the changes are documented

Thanks

Jacques

From: "Vikas Mayur" <[hidden email]>

>I think it would be good to document such change.
>
> - Vikas
>
> On Oct 13, 2008, at 8:36 PM, Jacques Le Roux wrote:
>
>> Hi Vikas,
>>
>> Did not look into detail yet, but did you think about any needs to  
>> fill http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions 
>>  ?
>>
>> Jacques
>>
>> From: "Vikas Mayur" <[hidden email]>
>>> Thanks Jacques for interest.
>>>
>>> Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 
>>>  , as it has framework files and I do not have rights.
>>>
>>> - Vikas
>>>
>>> On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:
>>>
>>>> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)
>>>>
>>>> Jacques
>>>>
>>>> From: "Vikas Mayur" <[hidden email]>
>>>>> dev,
>>>>> WDYT ?
>>>>> If agreed I would submit a patch.
>>>>> - Vikas
>>
>

[Vikas Mayur-3]

Hi Jacques,

I have added the details at the bottom of the page http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions
After commit, this will need a little modification. It is to  
replace ?????? with actual revision number.

The Jira issue is https://issues.apache.org/jira/browse/OFBIZ-1996


Thanks,
Vikas

On Oct 14, 2008, at 3:14 PM, Jacques Le Roux wrote:

> Hi Vikas,
>
> I'd prefer to wait, before committing, that the changes are documented
>
> Thanks
>
> Jacques
>
> From: "Vikas Mayur" <[hidden email]>
>> I think it would be good to document such change.
>> - Vikas
>> On Oct 13, 2008, at 8:36 PM, Jacques Le Roux wrote:
>>> Hi Vikas,
>>>
>>> Did not look into detail yet, but did you think about any needs  
>>> to  fill http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions 
>>>   ?
>>>
>>> Jacques
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>> Thanks Jacques for interest.
>>>>
>>>> Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 
>>>>   , as it has framework files and I do not have rights.
>>>>
>>>> - Vikas
>>>>
>>>> On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:
>>>>
>>>>> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>> dev,
>>>>>> WDYT ?
>>>>>> If agreed I would submit a patch.
>>>>>> - Vikas
>>>
>>

[Jacques Le Roux]

Thanks Vikas,

Commited in r712366, Wiki page updated

Jacques

From: "Vikas Mayur" <[hidden email]>

> Hi Jacques,
>
> I have added the details at the bottom of the page http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions
> After commit, this will need a little modification. It is to  
> replace ?????? with actual revision number.
>
> The Jira issue is https://issues.apache.org/jira/browse/OFBIZ-1996
>
>
> Thanks,
> Vikas
>
> On Oct 14, 2008, at 3:14 PM, Jacques Le Roux wrote:
>
>> Hi Vikas,
>>
>> I'd prefer to wait, before committing, that the changes are documented
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Vikas Mayur" <[hidden email]>
>>> I think it would be good to document such change.
>>> - Vikas
>>> On Oct 13, 2008, at 8:36 PM, Jacques Le Roux wrote:
>>>> Hi Vikas,
>>>>
>>>> Did not look into detail yet, but did you think about any needs  
>>>> to  fill http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions 
>>>>   ?
>>>>
>>>> Jacques
>>>>
>>>> From: "Vikas Mayur" <[hidden email]>
>>>>> Thanks Jacques for interest.
>>>>>
>>>>> Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 
>>>>>   , as it has framework files and I do not have rights.
>>>>>
>>>>> - Vikas
>>>>>
>>>>> On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:
>>>>>
>>>>>> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java, *.xml)
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>>> dev,
>>>>>>> WDYT ?
>>>>>>> If agreed I would submit a patch.
>>>>>>> - Vikas
>>>>
>>>
>
>

[Vikas Mayur-3]

Thanks Jacques.

Vikas

On Nov 8, 2008, at 2:31 PM, Jacques Le Roux wrote:

> Thanks Vikas,
>
> Commited in r712366, Wiki page updated
>
> Jacques
>
> From: "Vikas Mayur" <[hidden email]>
>> Hi Jacques,
>> I have added the details at the bottom of the page http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions
>> After commit, this will need a little modification. It is to  
>> replace ?????? with actual revision number.
>> The Jira issue is https://issues.apache.org/jira/browse/OFBIZ-1996
>> Thanks,
>> Vikas
>> On Oct 14, 2008, at 3:14 PM, Jacques Le Roux wrote:
>>> Hi Vikas,
>>>
>>> I'd prefer to wait, before committing, that the changes are  
>>> documented
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>> From: "Vikas Mayur" <[hidden email]>
>>>> I think it would be good to document such change.
>>>> - Vikas
>>>> On Oct 13, 2008, at 8:36 PM, Jacques Le Roux wrote:
>>>>> Hi Vikas,
>>>>>
>>>>> Did not look into detail yet, but did you think about any needs  
>>>>> to  fill http://docs.ofbiz.org/display/OFBTECH/Upgrading+OFBiz+from+earlier+revisions 
>>>>>    ?
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>> Thanks Jacques for interest.
>>>>>>
>>>>>> Please find the patch at https://issues.apache.org/jira/browse/OFBIZ-1996 
>>>>>>    , as it has framework files and I do not have rights.
>>>>>>
>>>>>> - Vikas
>>>>>>
>>>>>> On Oct 12, 2008, at 9:57 PM, Jacques Le Roux wrote:
>>>>>>
>>>>>>> +1 (64 occurences in code, ie *.bsh, *.ftl, *.gro*, *.java,  
>>>>>>> *.xml)
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> From: "Vikas Mayur" <[hidden email]>
>>>>>>>> dev,
>>>>>>>> WDYT ?
>>>>>>>> If agreed I would submit a patch.
>>>>>>>> - Vikas
>>>>>
>>>>
>>