[jira] Created: (OFBIZ-893) And createOrStore option to create-value in minilang

[Nicolas Malin (Jira)]

And createOrStore option to create-value in minilang
----------------------------------------------------

                 Key: OFBIZ-893
                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
            Reporter: Chris Howe


Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:

methodContext.getDelegator().createOrStore(value, doCacheClear)

instead of:

methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-893:
-----------------------------

    Attachment: CreateOrStoreMinilang.patch

> And createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-893:
-----------------------------

    Priority: Minor  (was: Major)

> And createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-893:
-----------------------------

    Summary: Add createOrStore option to create-value in minilang  (was: And createOrStore option to create-value in minilang)

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489141 ]

Anil K Patel commented on OFBIZ-893:
------------------------------------

I think this is good enhancement. Patch looks good, other then few tab keys instead of spaces.

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489205 ]

Jacques Le Roux commented on OFBIZ-893:
---------------------------------------

+1

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489212 ]

Chris Howe commented on OFBIZ-893:
----------------------------------

I was wondering if it may be worthwhile to combine the <store-value> and <create-value> into the same element and having an attribute handle the various insert/update scenarios.

create               - create if doesn't exist/fail if does
createOrStore - create if doesn't exist/update if does
store                 - fail if doesn't exist/ update if does

And perhaps the same with store-list.  Adding a create, and createOrStore setting so that lists have be created likewise.

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526364 ]

Jonathon Wong commented on OFBIZ-893:
-------------------------------------

I vote for NOT overloading the <create-value> function! Yes, have <create-value>, <create-or-store-value>, <store-value>, etc.

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641874#action_12641874 ]

Jacques Le Roux commented on OFBIZ-893:
---------------------------------------

This is still mergeable, do we agree to commit ? Without answers I will commit in some days...

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-893:
-------------------------------------

    Assignee: Jacques Le Roux

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643992#action_12643992 ]

Jacques Le Roux commented on OFBIZ-893:
---------------------------------------

Finally I'd like to have opininons about Jonathon suggestion.
Would you prefer to keep  <create-value> as it is and add <create-or-store-value>, <store-value>, etc. ?

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644054#action_12644054 ]

BJ Freeman commented on OFBIZ-893:
----------------------------------

guess my question if we have a create, and a store, why do  we want to create this.

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644103#action_12644103 ]

Jacques Le Roux commented on OFBIZ-893:
---------------------------------------

Thanks for interest BJ,

Because it would allow to use GenericDelegator.createOrStore  which needs no prior knowledge of the existence (or not) of the Entity.

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644105#action_12644105 ]

BJ Freeman commented on OFBIZ-893:
----------------------------------

Ok, I don't mind a new createOrStore  just not remove the independent create, store

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644112#action_12644112 ]

Jacques Le Roux commented on OFBIZ-893:
---------------------------------------

Yes sure !

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-893.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Chris,

Your patch is in trunk, revision: 712480  

> Add createOrStore option to create-value in minilang
> ----------------------------------------------------
>
>                 Key: OFBIZ-893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-893
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: CreateOrStoreMinilang.patch
>
>
> Add attribute or-store to <create-value> in simple-mehtod.  Will run operation with:
> methodContext.getDelegator().createOrStore(value, doCacheClear)
> instead of:
> methodContext.getDelegator().create(value, doCacheClear);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.