Ldap.authentication.patch ofbiz 4.0 branches release

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Ldap.authentication.patch ofbiz 4.0 branches release

ChristopherJ
Hi

I have recently started looking at the Apache Ofbiz Development Guide : Beginner´s Tutorial,
and reverted to the stable release 4.0 as referenced in the book. This is a major step
back from the trunk version, yet for production it seems to be a lot more stable. (Is this true?) Now comparing the trunk with the branch version I have discovered that the trunk has Ldap
compatibility and the branch has none.

I have found the following patch (https://issues.apache.org/jira/browse/OFBIZ-811)
but when I try to apply it I get the following error.


[root@itux ofbiz4.0]# patch -p0 < ldap_authentication.patch            
(Stripping trailing CRs from patch.)                                    
patching file framework/common/src/org/ofbiz/common/login/LdapAuthenticationServices.java
(Stripping trailing CRs from patch.)                                                    
patching file framework/common/src/org/ofbiz/common/login/LoginServices.java            
Hunk #1 FAILED at 64.                                                                    
1 out of 1 hunk FAILED -- saving rejects to file framework/common/src/org/ofbiz/common/login/LoginServices.java.rej
(Stripping trailing CRs from patch.)                                                                              
patching file framework/security/config/jndiLdap.properties                                                        
(Stripping trailing CRs from patch.)                                                                              
patching file framework/security/config/security.properties                                                        
Hunk #1 FAILED at 60.                                                                                              
Hunk #2 FAILED at 76.                                                                                              
2 out of 2 hunks FAILED -- saving rejects to file framework/security/config/security.properties.rej                
(Stripping trailing CRs from patch.)                                                                              
patching file framework/security/entitydef/entitygroup.xml                                                        
(Stripping trailing CRs from patch.)                                                                              
patching file framework/security/entitydef/entitymodel.xml

Can anybody advise which is the best option to use: Ofbiz release 4.0 or a (specific or XX count back) trunk version for production. (This being as I have notes on configuring a trunk version to be more production orientated, rather than development related)

Alternatively, where am I going wrong with the patch and why is the stable release so far behind the trunk....

Thanks!
Reply | Threaded
Open this post in threaded view
|

Re: Ldap.authentication.patch ofbiz 4.0 branches release

Jacques Le Roux
Administrator
>
> Hi
>
> I have recently started looking at the Apache Ofbiz Development Guide :
> Beginner´s Tutorial,
> and reverted to the stable release 4.0 as referenced in the book. This is a
> major step
> back from the trunk version, yet for production it seems to be a lot more
> stable. (Is this true?)

Yes it is, especially nowadays : we have commited massive changes to the trunk these last days

>Now comparing the trunk with the branch version I
> have discovered that the trunk has Ldap
> compatibility and the branch has none.
>
> I have found the following patch
> (https://issues.apache.org/jira/browse/OFBIZ-811)
> but when I try to apply it I get the following error.
>
>
> [root@itux ofbiz4.0]# patch -p0 < ldap_authentication.patch
> (Stripping trailing CRs from patch.)
> patching file
> framework/common/src/org/ofbiz/common/login/LdapAuthenticationServices.java
> (Stripping trailing CRs from patch.)
> patching file framework/common/src/org/ofbiz/common/login/LoginServices.java
> Hunk #1 FAILED at 64.
> 1 out of 1 hunk FAILED -- saving rejects to file
> framework/common/src/org/ofbiz/common/login/LoginServices.java.rej
> (Stripping trailing CRs from patch.)
> patching file framework/security/config/jndiLdap.properties
> (Stripping trailing CRs from patch.)
> patching file framework/security/config/security.properties
> Hunk #1 FAILED at 60.
> Hunk #2 FAILED at 76.
> 2 out of 2 hunks FAILED -- saving rejects to file
> framework/security/config/security.properties.rej
> (Stripping trailing CRs from patch.)
> patching file framework/security/entitydef/entitygroup.xml
> (Stripping trailing CRs from patch.)
> patching file framework/security/entitydef/entitymodel.xml
>
> Can anybody advise which is the best option to use: Ofbiz release 4.0 or a
> (specific or XX count back) trunk version for production. (This being as I
> have notes on configuring a trunk version to be more production orientated,
> rather than development related)

As noted in OFBIZ-811 this has been commited in trunk r669994 http://svn.apache.org/viewvc?view=rev&revision=669994. You would have
to do the work by your self either on R4 or using this release. If you fiund bugs, there are chances that patches have been commited
since. So you would have to commit them from this release at least.

> Alternatively, where am I going wrong with the patch and why is the stable
> release so far behind the trunk....

Manpower...

Jacques

> Thanks!
> --
> View this message in context: http://www.nabble.com/Ldap.authentication.patch-ofbiz-4.0-branches-release-tp21228256p21228256.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Ldap.authentication.patch ofbiz 4.0 branches release

ChristopherJ
Thanks for the reply

I will have to read through all the ldap notes and see what I can do with it,
otherwise bring it in later with the next major release.

Thanks for the interesting points made gave me something to think about!


jacques.le.roux wrote
>
> Hi
>
> I have recently started looking at the Apache Ofbiz Development Guide :
> Beginner´s Tutorial,
> and reverted to the stable release 4.0 as referenced in the book. This is a
> major step
> back from the trunk version, yet for production it seems to be a lot more
> stable. (Is this true?)

Yes it is, especially nowadays : we have commited massive changes to the trunk these last days

>Now comparing the trunk with the branch version I
> have discovered that the trunk has Ldap
> compatibility and the branch has none.
>
> I have found the following patch
> (https://issues.apache.org/jira/browse/OFBIZ-811)
> but when I try to apply it I get the following error.
>
>
> [root@itux ofbiz4.0]# patch -p0 < ldap_authentication.patch
> (Stripping trailing CRs from patch.)
> patching file
> framework/common/src/org/ofbiz/common/login/LdapAuthenticationServices.java
> (Stripping trailing CRs from patch.)
> patching file framework/common/src/org/ofbiz/common/login/LoginServices.java
> Hunk #1 FAILED at 64.
> 1 out of 1 hunk FAILED -- saving rejects to file
> framework/common/src/org/ofbiz/common/login/LoginServices.java.rej
> (Stripping trailing CRs from patch.)
> patching file framework/security/config/jndiLdap.properties
> (Stripping trailing CRs from patch.)
> patching file framework/security/config/security.properties
> Hunk #1 FAILED at 60.
> Hunk #2 FAILED at 76.
> 2 out of 2 hunks FAILED -- saving rejects to file
> framework/security/config/security.properties.rej
> (Stripping trailing CRs from patch.)
> patching file framework/security/entitydef/entitygroup.xml
> (Stripping trailing CRs from patch.)
> patching file framework/security/entitydef/entitymodel.xml
>
> Can anybody advise which is the best option to use: Ofbiz release 4.0 or a
> (specific or XX count back) trunk version for production. (This being as I
> have notes on configuring a trunk version to be more production orientated,
> rather than development related)

As noted in OFBIZ-811 this has been commited in trunk r669994 http://svn.apache.org/viewvc?view=rev&revision=669994. You would have
to do the work by your self either on R4 or using this release. If you fiund bugs, there are chances that patches have been commited
since. So you would have to commit them from this release at least.

> Alternatively, where am I going wrong with the patch and why is the stable
> release so far behind the trunk....

Manpower...

Jacques

> Thanks!
> --
> View this message in context: http://www.nabble.com/Ldap.authentication.patch-ofbiz-4.0-branches-release-tp21228256p21228256.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Ldap.authentication.patch ofbiz 4.0 branches release

Adrian Crum-2
In reply to this post by Jacques Le Roux
--- On Wed, 12/31/08, Jacques Le Roux <[hidden email]> wrote:

> From: Jacques Le Roux <[hidden email]>
> Subject: Re: Ldap.authentication.patch ofbiz 4.0 branches release
> To: [hidden email]
> Date: Wednesday, December 31, 2008, 1:22 AM
> >
> > Hi
> >
> > I have recently started looking at the Apache Ofbiz
> Development Guide :
> > Beginner´s Tutorial,
> > and reverted to the stable release 4.0 as referenced
> in the book. This is a
> > major step
> > back from the trunk version, yet for production it
> seems to be a lot more
> > stable. (Is this true?)
>
> Yes it is, especially nowadays : we have commited massive
> changes to the trunk these last days
>
> >Now comparing the trunk with the branch version I
> > have discovered that the trunk has Ldap
> > compatibility and the branch has none.
> >
> > I have found the following patch
> > (https://issues.apache.org/jira/browse/OFBIZ-811)
> > but when I try to apply it I get the following error.
> >
> >
> > [root@itux ofbiz4.0]# patch -p0 <
> ldap_authentication.patch
> > (Stripping trailing CRs from patch.)
> > patching file
> >
> framework/common/src/org/ofbiz/common/login/LdapAuthenticationServices.java
> > (Stripping trailing CRs from patch.)
> > patching file
> framework/common/src/org/ofbiz/common/login/LoginServices.java
> > Hunk #1 FAILED at 64.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> >
> framework/common/src/org/ofbiz/common/login/LoginServices.java.rej
> > (Stripping trailing CRs from patch.)
> > patching file
> framework/security/config/jndiLdap.properties
> > (Stripping trailing CRs from patch.)
> > patching file
> framework/security/config/security.properties
> > Hunk #1 FAILED at 60.
> > Hunk #2 FAILED at 76.
> > 2 out of 2 hunks FAILED -- saving rejects to file
> > framework/security/config/security.properties.rej
> > (Stripping trailing CRs from patch.)
> > patching file
> framework/security/entitydef/entitygroup.xml
> > (Stripping trailing CRs from patch.)
> > patching file
> framework/security/entitydef/entitymodel.xml
> >
> > Can anybody advise which is the best option to use:
> Ofbiz release 4.0 or a
> > (specific or XX count back) trunk version for
> production. (This being as I
> > have notes on configuring a trunk version to be more
> production orientated,
> > rather than development related)
>
> As noted in OFBIZ-811 this has been commited in trunk
> r669994
> http://svn.apache.org/viewvc?view=rev&revision=669994.
> You would have
> to do the work by your self either on R4 or using this
> release. If you fiund bugs, there are chances that patches
> have been commited
> since. So you would have to commit them from this release
> at least.
>
> > Alternatively, where am I going wrong with the patch
> and why is the stable
> > release so far behind the trunk....
>
> Manpower...
>
> Jacques

It's not really a manpower issue. The release is a branch from the trunk, and it was done almost two years ago. The release receives bug fixes but not new features - so naturally there will be large differences between the release and the trunk as time passes.

-Adrian




Reply | Threaded
Open this post in threaded view
|

Re: Ldap.authentication.patch ofbiz 4.0 branches release

David E Jones-3
In reply to this post by Jacques Le Roux

On Dec 31, 2008, at 2:22 AM, Jacques Le Roux wrote:

>>
>> Hi
>>
>> I have recently started looking at the Apache Ofbiz Development  
>> Guide :
>> Beginner´s Tutorial,
>> and reverted to the stable release 4.0 as referenced in the book.  
>> This is a
>> major step
>> back from the trunk version, yet for production it seems to be a  
>> lot more
>> stable. (Is this true?)
>
> Yes it is, especially nowadays : we have commited massive changes to  
> the trunk these last days

Actually, it may be true right in this instant due to some untested  
commits, but the I'd say in general the trunk has less issues than the  
release branch because there are more people working with it, and bugs  
get fixed a lot faster. The trunk is certainly not more stable though,  
as stable means unchanging and that is more true of the branch than  
the trunk, but there are fairly serious issues that have been fixed in  
the trunk that may never make it back to the release branch because  
they have too many touch points and no one wants to do it.

Many of those who use the release branch don't even contribute bug  
fixes back, so even though there are people using it sometimes it  
takes a while for fixes to get in... and there seem to be issues even  
though it has been out for nearly 2 years.

In short, I'd say if you're going to do custom development then my  
recommendation is, and always has been, to start with the trunk. If  
you go with the release branch your experience will be considerably  
more painful, and you won't have many opportunities to collaborate  
with others in the community.

A summary of the choices is available here:

http://docs.ofbiz.org/display/OFBADMIN/Apache+OFBiz+Getting+Started

Keep in mind that there are many people in the community who simply  
don't understand this because they haven't been involved long enough  
or haven't run across relevant experience or dealt with end-users on a  
long-term basis. That is where the difference really shows up.

-David

Reply | Threaded
Open this post in threaded view
|

Re: Ldap.authentication.patch ofbiz 4.0 branches release

Jacques Le Roux
Administrator
In reply to this post by Adrian Crum-2
From: "Adrian Crum" <[hidden email]>

> --- On Wed, 12/31/08, Jacques Le Roux <[hidden email]> wrote:
>
>> From: Jacques Le Roux <[hidden email]>
>> Subject: Re: Ldap.authentication.patch ofbiz 4.0 branches release
>> To: [hidden email]
>> Date: Wednesday, December 31, 2008, 1:22 AM
>> >
>> > Hi
>> >
>> > I have recently started looking at the Apache Ofbiz
>> Development Guide :
>> > Beginner´s Tutorial,
>> > and reverted to the stable release 4.0 as referenced
>> in the book. This is a
>> > major step
>> > back from the trunk version, yet for production it
>> seems to be a lot more
>> > stable. (Is this true?)
>>
>> Yes it is, especially nowadays : we have commited massive
>> changes to the trunk these last days
>>
>> >Now comparing the trunk with the branch version I
>> > have discovered that the trunk has Ldap
>> > compatibility and the branch has none.
>> >
>> > I have found the following patch
>> > (https://issues.apache.org/jira/browse/OFBIZ-811)
>> > but when I try to apply it I get the following error.
>> >
>> >
>> > [root@itux ofbiz4.0]# patch -p0 <
>> ldap_authentication.patch
>> > (Stripping trailing CRs from patch.)
>> > patching file
>> >
>> framework/common/src/org/ofbiz/common/login/LdapAuthenticationServices.java
>> > (Stripping trailing CRs from patch.)
>> > patching file
>> framework/common/src/org/ofbiz/common/login/LoginServices.java
>> > Hunk #1 FAILED at 64.
>> > 1 out of 1 hunk FAILED -- saving rejects to file
>> >
>> framework/common/src/org/ofbiz/common/login/LoginServices.java.rej
>> > (Stripping trailing CRs from patch.)
>> > patching file
>> framework/security/config/jndiLdap.properties
>> > (Stripping trailing CRs from patch.)
>> > patching file
>> framework/security/config/security.properties
>> > Hunk #1 FAILED at 60.
>> > Hunk #2 FAILED at 76.
>> > 2 out of 2 hunks FAILED -- saving rejects to file
>> > framework/security/config/security.properties.rej
>> > (Stripping trailing CRs from patch.)
>> > patching file
>> framework/security/entitydef/entitygroup.xml
>> > (Stripping trailing CRs from patch.)
>> > patching file
>> framework/security/entitydef/entitymodel.xml
>> >
>> > Can anybody advise which is the best option to use:
>> Ofbiz release 4.0 or a
>> > (specific or XX count back) trunk version for
>> production. (This being as I
>> > have notes on configuring a trunk version to be more
>> production orientated,
>> > rather than development related)
>>
>> As noted in OFBIZ-811 this has been commited in trunk
>> r669994
>> http://svn.apache.org/viewvc?view=rev&revision=669994.
>> You would have
>> to do the work by your self either on R4 or using this
>> release. If you fiund bugs, there are chances that patches
>> have been commited
>> since. So you would have to commit them from this release
>> at least.
>>
>> > Alternatively, where am I going wrong with the patch
>> and why is the stable
>> > release so far behind the trunk....
>>
>> Manpower...
>>
>> Jacques
>
> It's not really a manpower issue. The release is a branch from the trunk, and it was done almost two years ago. The release
> receives bug fixes but not new features - so naturally there will be large differences between the release and the trunk as time
> passes.

I was speaking about the 1,5 years gap between trunk and release...

Jacques

> -Adrian