Re: Users - invoice - wrong calculation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Hans Bakker
Joachim,
I just committed a change to solve the problem below.
upgrade to the latest version and it should be solved, please let know if it
is not.

--
Regards,
Hans Bakker
ANT Websystems Co.,Ltd (http://www.antwebsystems.com)

If you want to verify that this message really originates from
from the above person, download the public key from:
http://www.antwebsystems.com/hbakkerAntwebsystems.asc

On Thursday 13 April 2006 19:06, Schreibmaier Joachim wrote:

> > Attached a simple patch which solves this problem, however i am not sure
> > it is
> > the right solution.
> >
> > I have send David this patch, however he seem to be very busy at this
> > moment.
>
> Thanks for your reply. I am working on a Windows 2003 machine. How can I
> execute the image. What do I have to do to get this patch working?
>
> I have manually edited the ObjectType.java class. It works but there should
> be a way without hardcoding.
>
> Another problem:
> When I make a sales order via the pos-terminal and the customer pays cash
> the invoice should be balanced. But the whole invoice amount is "open" with
> the status ready (approved). Shouldn't be there the status paid when the
> customer pays cash?
>
> I am using ofbiz revision no. 6989.
>
> Thanks for helping.
>
> Best regards
> --
> Joachim Schreibmaier
>
>
>
> _______________________________________________
> Users mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/users

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Schreibmaier Joachim
Hans,

Thanks for your mail concerning the accounting problem.

Unfortunately it doesn't work correct. If I make an offline payment and open the referencing invoice, I get the exception:
java.lang.NumberFormatException: For input string: "51,2".

I stopped ofbiz and compiled the class files via ant.bat.

I am now using revision no. 7414.

Thanks for helping.

Best Regards
Joachim

--
Joachim Schreibmaier


 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Hans Bakker
In reply to this post by Hans Bakker
Joachim,

I localized all the outputs under accounting --> invoices/payments. There you
should see the invoice/payment properly.

It would help if you tell me the url where you see the error.

regards,
Hans

On Wednesday 26 April 2006 01:37, Schreibmaier Joachim wrote:

> Hans,
>
> Thanks for your mail concerning the accounting problem.
>
> Unfortunately it doesn't work correct. If I make an offline payment and
> open the referencing invoice, I get the exception:
> java.lang.NumberFormatException: For input string: "51,2".
>
> I stopped ofbiz and compiled the class files via ant.bat.
>
> I am now using revision no. 7414.
>
> Thanks for helping.
>
> Best Regards
> Joachim
--
Regards,
Hans Bakker
ANT Websystems Co.,Ltd (http://www.antwebsystems.com)

If you want to verify that this message really originates from
from the above person, download the public key from:
http://www.antwebsystems.com/hbakkerAntwebsystems.asc

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Schreibmaier Joachim
In reply to this post by Hans Bakker
Hans,

> I localized all the outputs under accounting --> invoices/payments.
> There you should see the invoice/payment properly.
If I call the payment for the corresponding invoice via
https://ebiz.internet-technik.com:8443/accounting/control/paymentOverview?pa
ymentId=10240

There are no payments applied although I did an offline payment before. If I
try to manually update the payment I get the following bsh exception:
rg.ofbiz.base.util.GeneralException: Error rendering screen
[component://accounting/widget/PaymentScreens.xml#EditPaymentApplications]:
org.ofbiz.base.util.GeneralException: Error running BSH script at location
[component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
liedInvoices.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH
script at
[component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
liedInvoices.bsh], line [64]: Sourced file:
component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
iedInvoices.bsh : null : at Line: 64 : in file:
component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
iedInvoices.bsh : .get ( "lastLocale" )

> It would help if you tell me the url where you see the error.
The url fort he call of the invoice is:
https://ebiz.internet-technik.com:8443/accounting/control/invoiceOverview?in
voiceId=62&externalLoginKey=EL244445331300

Thanks for helping.

Best Regards
Joachim

--
Joachim Schreibmaier

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Hans Bakker
In reply to this post by Hans Bakker
Hi Joachim,

with the latest update it should be a lot better now. If you find some more
let me know...

Thanks for reporting these locale problems.....

Hans

On Wednesday 26 April 2006 14:13, Schreibmaier Joachim wrote:

> Hans,
>
> > I localized all the outputs under accounting --> invoices/payments.
> > There you should see the invoice/payment properly.
>
> If I call the payment for the corresponding invoice via
> https://ebiz.internet-technik.com:8443/accounting/control/paymentOverview?p
>a ymentId=10240
>
> There are no payments applied although I did an offline payment before. If
> I try to manually update the payment I get the following bsh exception:
> rg.ofbiz.base.util.GeneralException: Error rendering screen
> [component://accounting/widget/PaymentScreens.xml#EditPaymentApplications]:
> org.ofbiz.base.util.GeneralException: Error running BSH script at location
> [component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAp
>p liedInvoices.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH
> script at
> [component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAp
>p liedInvoices.bsh], line [64]: Sourced file:
> component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
>l iedInvoices.bsh : null : at Line: 64 : in file:
> component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
>l iedInvoices.bsh : .get ( "lastLocale" )
>
> > It would help if you tell me the url where you see the error.
>
> The url fort he call of the invoice is:
> https://ebiz.internet-technik.com:8443/accounting/control/invoiceOverview?i
>n voiceId=62&externalLoginKey=EL244445331300
>
> Thanks for helping.
>
> Best Regards
> Joachim
--
Regards,
Hans Bakker
ANT Websystems Co.,Ltd (http://www.antwebsystems.com)

If you want to verify that this message really originates from
from the above person, download the public key from:
http://www.antwebsystems.com/hbakkerAntwebsystems.asc

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users

attachment0 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Schreibmaier Joachim
In reply to this post by Hans Bakker
Hans,

> with the latest update it should be a lot better now. If you find some
> more let me know...

Same behaviour as before. Although I did an offline payment (total invoice
amount) there is the full invoice amount open to pay. If I manually try to
update the payment amount I get the exception:
org.ofbiz.base.util.GeneralException: Error rendering screen
[component://accounting/widget/PaymentScreens.xml#EditPaymentApplications]:
org.ofbiz.base.util.GeneralException: Error running BSH script at location
[component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
liedInvoices.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH
script at
[component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
liedInvoices.bsh], line [64]: Sourced file:
component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
iedInvoices.bsh : null : at Line: 64 : in file:
component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
iedInvoices.bsh : .get ( "lastLocale" )

I am now working with svn revision no. 7421 and also compiled the source
files.

Thanks for helping.

Best Regards

Joachim
--
Joachim Schreibmaier

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Jacopo Cappellato
In reply to this post by Hans Bakker
Hi Joachim,

just curious... could you please try to comment the line 42 of file
accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedPayments.bsh
?

Line 42 should contain:

Locale locale = parameters.get("locale");

Jacopo



Schreibmaier Joachim wrote:

> Hans,
>
>> with the latest update it should be a lot better now. If you find some
>> more let me know...
>
> Same behaviour as before. Although I did an offline payment (total invoice
> amount) there is the full invoice amount open to pay. If I manually try to
> update the payment amount I get the exception:
> org.ofbiz.base.util.GeneralException: Error rendering screen
> [component://accounting/widget/PaymentScreens.xml#EditPaymentApplications]:
> org.ofbiz.base.util.GeneralException: Error running BSH script at location
> [component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
> liedInvoices.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH
> script at
> [component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
> liedInvoices.bsh], line [64]: Sourced file:
> component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
> iedInvoices.bsh : null : at Line: 64 : in file:
> component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
> iedInvoices.bsh : .get ( "lastLocale" )
>
> I am now working with svn revision no. 7421 and also compiled the source
> files.
>
> Thanks for helping.
>
> Best Regards
>
> Joachim

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Schreibmaier Joachim
In reply to this post by Hans Bakker
Jacopo,

> just curious... could you please try to comment the line 42 of file
> accounting/webapp/accounting/WEB-
INF/actions/payment/listNotAppliedPayments.bsh

> Line 42 should contain:

> Locale locale = parameters.get("locale");
I am not sure if you mean comment out or you mean debug.

If I comment out the line you have mentioned nothing changes.

The locale of my ofbiz is de_AT.

Best Regards
Joachim

--
Joachim Schreibmaier

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Jacopo Cappellato
In reply to this post by Jacopo Cappellato
Joachim,

sorry, could you please apply the attached patch instead?
You can do it without stopping and without recompiling OFBiz.

Jacopo

Jacopo Cappellato wrote:

> Hi Joachim,
>
> just curious... could you please try to comment the line 42 of file
> accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedPayments.bsh
> ?
>
> Line 42 should contain:
>
> Locale locale = parameters.get("locale");
>
> Jacopo
>
>
>
> Schreibmaier Joachim wrote:
>> Hans,
>>
>>> with the latest update it should be a lot better now. If you find some
>>> more let me know...
>> Same behaviour as before. Although I did an offline payment (total invoice
>> amount) there is the full invoice amount open to pay. If I manually try to
>> update the payment amount I get the exception:
>> org.ofbiz.base.util.GeneralException: Error rendering screen
>> [component://accounting/widget/PaymentScreens.xml#EditPaymentApplications]:
>> org.ofbiz.base.util.GeneralException: Error running BSH script at location
>> [component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
>> liedInvoices.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH
>> script at
>> [component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotApp
>> liedInvoices.bsh], line [64]: Sourced file:
>> component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
>> iedInvoices.bsh : null : at Line: 64 : in file:
>> component://accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppl
>> iedInvoices.bsh : .get ( "lastLocale" )
>>
>> I am now working with svn revision no. 7421 and also compiled the source
>> files.
>>
>> Thanks for helping.
>>
>> Best Regards
>>
>> Joachim
>
>  
> _______________________________________________
> Users mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/users
>

Index: applications/accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedInvoices.bsh
===================================================================
--- applications/accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedInvoices.bsh (revision 7421)
+++ applications/accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedInvoices.bsh (working copy)
@@ -28,6 +28,7 @@
 import java.math.*;
 import java.text.NumberFormat;
 
+Locale locale = context.get("locale");
 
 paymentId = parameters.get("paymentId");
 payment = delegator.findByPrimaryKey("Payment", UtilMisc.toMap("paymentId", paymentId));
@@ -61,7 +62,6 @@
             invoiceMap.put("description",invoice.getString("description"));
             invoiceMap.put("invoiceDate", invoice.getString("invoiceDate").substring(0,10)); // display only YYYY-MM-DD
             invoiceMap.put("amountApplied", invoiceApplied);
-            locale = parameters.get("autoUserLogin").get("lastLocale");
             if (paymentToApply.compareTo(invoiceToApply) < 0 ) {
                 invoiceMap.put("amountToApply",paymentToApply);
             }
Index: applications/accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedPayments.bsh
===================================================================
--- applications/accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedPayments.bsh (revision 7421)
+++ applications/accounting/webapp/accounting/WEB-INF/actions/payment/listNotAppliedPayments.bsh (working copy)
@@ -39,7 +39,7 @@
 
 int decimals = UtilNumber.getBigDecimalScale("invoice.decimals");
 int rounding = UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
-Locale locale = parameters.get("locale");
+Locale locale = context.get("locale");
 
 ArrayList paymentsMapList = new ArrayList();  // to pass back to the screeen list of unapplied payments
 
@@ -81,7 +81,7 @@
            paymentMap.put("toPaymentId", payment.getString("paymentId"));
            paymentMap.put("currencyUomId", payment.getString("currencyUomId"));
            paymentMap.put("effectiveDate", payment.getString("effectiveDate").substring(0,10)); // list as YYYY-MM-DD
-           paymentMap.put("amount", payment.getString("amount"));
+           paymentMap.put("amount", payment.getBigDecimal("amount"));
            paymentMap.put("amountApplied", PaymentWorker.getPaymentAppliedBd(payment));
            BigDecimal paymentToApply = PaymentWorker.getPaymentNotAppliedBd(payment);
            if (paymentToApply.compareTo(basePaymentToApply) < 0 ) {

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Jacopo Cappellato
In reply to this post by Hans Bakker
Joachim,

sorry, a few minutes ago I've sent you another message (with an attached
patch)... could you please try it and see if it works?

Jacopo

Schreibmaier Joachim wrote:

> Jacopo,
>
>> just curious... could you please try to comment the line 42 of file
>> accounting/webapp/accounting/WEB-
> INF/actions/payment/listNotAppliedPayments.bsh
>
>> Line 42 should contain:
>
>> Locale locale = parameters.get("locale");
> I am not sure if you mean comment out or you mean debug.
>
> If I comment out the line you have mentioned nothing changes.
>
> The locale of my ofbiz is de_AT.
>
> Best Regards
> Joachim
>

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Jacopo Cappellato
The fix is very simple, so if you don't know how to apply a patch I can
tell you what lines you have to manually change.

Jacopo

Jacopo Cappellato wrote:

> Joachim,
>
> sorry, a few minutes ago I've sent you another message (with an attached
> patch)... could you please try it and see if it works?
>
> Jacopo
>
> Schreibmaier Joachim wrote:
>> Jacopo,
>>
>>> just curious... could you please try to comment the line 42 of file
>>> accounting/webapp/accounting/WEB-
>> INF/actions/payment/listNotAppliedPayments.bsh
>>
>>> Line 42 should contain:
>>> Locale locale = parameters.get("locale");
>> I am not sure if you mean comment out or you mean debug.
>>
>> If I comment out the line you have mentioned nothing changes.
>>
>> The locale of my ofbiz is de_AT.
>>
>> Best Regards
>> Joachim
>>
>
>  
> _______________________________________________
> Users mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/users
>

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Schreibmaier Joachim
In reply to this post by Hans Bakker
Jacopo,

> sorry, could you please apply the attached patch instead?
Hi,

Now it works correct. But if I do an offline payment before creating the
invoice, there is no reference between the invoice and the payment. Although
at the order there are is the invoice amount received the amount in the
invoice is still open and not applied.

Best Regards
Joachim

--
Joachim Schreibmaier


 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Jacopo Cappellato
In reply to this post by Hans Bakker
Joachim,

ok, for now I'll commit this patch and let Hans, Si or others comment on
this.

Hans, please, could you review rev 7422 that I've committed a few
minutes ago?
Joachim, thanks for your tests.

Jacopo

Schreibmaier Joachim wrote:

> Jacopo,
>
>> sorry, could you please apply the attached patch instead?
> Hi,
>
> Now it works correct. But if I do an offline payment before creating the
> invoice, there is no reference between the invoice and the payment. Although
> at the order there are is the invoice amount received the amount in the
> invoice is still open and not applied.
>
> Best Regards
> Joachim
>

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - invoice - wrong calculation

Hans Bakker
Excellent Jacopo, still some older code i overlooked.

On Thursday 27 April 2006 00:34, Jacopo Cappellato wrote:

> Joachim,
>
> ok, for now I'll commit this patch and let Hans, Si or others comment on
> this.
>
> Hans, please, could you review rev 7422 that I've committed a few
> minutes ago?
> Joachim, thanks for your tests.
>
> Jacopo
>
> Schreibmaier Joachim wrote:
> > Jacopo,
> >
> >> sorry, could you please apply the attached patch instead?
> >
> > Hi,
> >
> > Now it works correct. But if I do an offline payment before creating the
> > invoice, there is no reference between the invoice and the payment.
> > Although at the order there are is the invoice amount received the amount
> > in the invoice is still open and not applied.
> >
> > Best Regards
> > Joachim
>
> _______________________________________________
> Users mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/users
--
Regards,
Hans Bakker
ANT Websystems Co.,Ltd (http://www.antwebsystems.com)

If you want to verify that this message really originates from
from the above person, download the public key from:
http://www.antwebsystems.com/hbakkerAntwebsystems.asc

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users

attachment0 (196 bytes) Download Attachment