was this commit done as a tested thing or just thrown in
[hidden email] sent the following on 10/17/2007 7:18 PM: > Author: doogie > Date: Wed Oct 17 19:18:34 2007 > New Revision: 585788 > > URL: http://svn.apache.org/viewvc?rev=585788&view=rev > Log: > Switch to collections class, from Vector/Hashtable. > > Modified: > ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java > ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java > ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/SOAPClientEngine.java > > Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java?rev=585788&r1=585787&r2=585788&view=diff > ============================================================================== > --- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java (original) > +++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java Wed Oct 17 19:18:34 2007 > @@ -24,7 +24,7 @@ > public class AuthorizeResponse { > > private String rawResp = null; > - private Vector response = new Vector(); > + private List response = new ArrayList(); > private String respCode = ""; > private String reasonCode = ""; > private String reasonText = ""; > @@ -153,19 +153,19 @@ > return this.rawResp; > } > > - private Vector splitResp(String r, String delim) { > + private List splitResp(String r, String delim) { > int s1=0, s2=-1; > - Vector out = new Vector(40); > - out.addElement("empty"); > + List out = new ArrayList(40); > + out.add("empty"); > while(true){ > s2 = r.indexOf(delim, s1); > if(s2 != -1){ > - out.addElement(r.substring(s1, s2)); > + out.add(r.substring(s1, s2)); > }else{ > //the end part of the string (string not pattern terminated) > String _ = r.substring(s1); > if(_ != null && !_.equals("")){ > - out.addElement(_); > + out.add(_); > } > break; > } > > Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java?rev=585788&r1=585787&r2=585788&view=diff > ============================================================================== > --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java (original) > +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartHelper.java Wed Oct 17 19:18:34 2007 > @@ -798,7 +798,7 @@ > try { > this.cart.removeCartItem(itemIndex, dispatcher); > } catch (CartItemModifyException e) { > - result = ServiceUtil.returnError(new Vector()); > + result = ServiceUtil.returnError(new ArrayList()); > errorMsgs.add(e.getMessage()); > } > } > > Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/SOAPClientEngine.java > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/SOAPClientEngine.java?rev=585788&r1=585787&r2=585788&view=diff > ============================================================================== > --- ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/SOAPClientEngine.java (original) > +++ ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/SOAPClientEngine.java Wed Oct 17 19:18:34 2007 > @@ -20,12 +20,11 @@ > > import java.net.MalformedURLException; > import java.net.URL; > +import java.util.ArrayList; > import java.util.HashMap; > -import java.util.Hashtable; > import java.util.Iterator; > import java.util.List; > import java.util.Map; > -import java.util.Vector; > > import javax.xml.namespace.QName; > import javax.xml.rpc.ParameterMode; > @@ -121,7 +120,7 @@ > int i = 0; > > call.setOperation(call.getOperationName().getLocalPart()); > - Vector vParams = new Vector(); > + List vParams = new ArrayList(); > Iterator iter = inModelParamList.iterator(); > while (iter.hasNext()) { > ModelParam p = (ModelParam) iter.next(); > @@ -160,7 +159,7 @@ > } > > private Map getResponseParams(Message respMessage) { > - Map mRet = new Hashtable(); > + Map mRet = new HashMap(); > try { > SOAPEnvelope resEnv = respMessage.getSOAPEnvelope(); > List bodies = resEnv.getBodyElements(); > > > > |
Free forum by Nabble | Edit this page |