// TODO: Remove this block after the next release 2010-11-29

[Jacques Le Roux]

Hi,

Should we not remove this block and stuff related?
// TODO: Remove this block after the next release 2010-11-29

Jacques

[Pierre Smits]

Hi Jacques,

This is very cryptic. To what issue does this relate to, and to what
application or component?

Regards,

Pierre

Op 7 april 2012 11:12 schreef Jacques Le Roux
<[hidden email]>het volgende:

> Hi,
>
> Should we not remove this block and stuff related?
> // TODO: Remove this block after the next release 2010-11-29
>
> Jacques
>

[Jacques Le Roux]

Just look into *.java you will find it easily ;o)

It's in WorkEffortServices.processWorkEffortEventReminder()

Jacques

From: "Pierre Smits" <[hidden email]>

> Hi Jacques,
>
> This is very cryptic. To what issue does this relate to, and to what
> application or component?
>
> Regards,
>
> Pierre
>
> Op 7 april 2012 11:12 schreef Jacques Le Roux
> <[hidden email]>het volgende:
>
>> Hi,
>>
>> Should we not remove this block and stuff related?
>> // TODO: Remove this block after the next release 2010-11-29
>>
>> Jacques
>>
>

[Jacques Le Roux]

I meant this should awake a committer, at least one person should be aware of that...

Jacques

From: "Jacques Le Roux" <[hidden email]>

> Just look into *.java you will find it easily ;o)
>
> It's in WorkEffortServices.processWorkEffortEventReminder()
>
> Jacques
>
> From: "Pierre Smits" <[hidden email]>
>> Hi Jacques,
>>
>> This is very cryptic. To what issue does this relate to, and to what
>> application or component?
>>
>> Regards,
>>
>> Pierre
>>
>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>> <[hidden email]>het volgende:
>>
>>> Hi,
>>>
>>> Should we not remove this block and stuff related?
>>> // TODO: Remove this block after the next release 2010-11-29
>>>
>>> Jacques
>>>
>>

[Scott Gray-2]

The instructions seem quite clear to me.

Regards
Scott

On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:

> I meant this should awake a committer, at least one person should be aware of that...
>
> Jacques
>
> From: "Jacques Le Roux" <[hidden email]>
>> Just look into *.java you will find it easily ;o)
>> It's in WorkEffortServices.processWorkEffortEventReminder()
>> Jacques
>> From: "Pierre Smits" <[hidden email]>
>>> Hi Jacques,
>>> This is very cryptic. To what issue does this relate to, and to what
>>> application or component?
>>> Regards,
>>> Pierre
>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>> <[hidden email]>het volgende:
>>>> Hi,
>>>>
>>>> Should we not remove this block and stuff related?
>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>
>>>> Jacques
>>>>
>>>

[Jacques Le Roux]

Hi Scott,

So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev

Whay did you not remove it? Is there a reason or only an oversight?
Is it the only thing to do? What about @Deprecated processEventReminder method?
Should we keep EventReminders.properties file, etc. ?

Jacques

From: "Scott Gray" <[hidden email]>

> The instructions seem quite clear to me.
>
> Regards
> Scott
>
> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>
>> I meant this should awake a committer, at least one person should be aware of that...
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <[hidden email]>
>>> Just look into *.java you will find it easily ;o)
>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>> Jacques
>>> From: "Pierre Smits" <[hidden email]>
>>>> Hi Jacques,
>>>> This is very cryptic. To what issue does this relate to, and to what
>>>> application or component?
>>>> Regards,
>>>> Pierre
>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>> <[hidden email]>het volgende:
>>>>> Hi,
>>>>>
>>>>> Should we not remove this block and stuff related?
>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>
>>>>> Jacques
>>>>>
>>>>
>
>

[Scott Gray-2]

Hi Jaques,

All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.

On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote:

> Hi Scott,
>
> So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev
>
> What did you not remove it?

I figured it would be nicer for users if we waited until after a release.

> Is there a reason or only an oversight?

Do you mean why haven't I removed it after the 11.04 release?  Because we haven't had a next release yet.

> Is it the only thing to do?

No, the property file also needs to be removed.

> What about @Deprecated processEventReminder method?

Do you mean processWorkEffortEventReminder?  Because #1 it's a service so deprecating it would do nothing and #2 only a block needs to be removed so why deprecate it?

> Should we keep EventReminders.properties file, etc. ?

No the property file should also be removed, I don't know what else you're referring to with "etc."

>
> Jacques
>
> From: "Scott Gray" <[hidden email]>
>> The instructions seem quite clear to me.
>>
>> Regards
>> Scott
>>
>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>>
>>> I meant this should awake a committer, at least one person should be aware of that...
>>>
>>> Jacques
>>>
>>> From: "Jacques Le Roux" <[hidden email]>
>>>> Just look into *.java you will find it easily ;o)
>>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>>> Jacques
>>>> From: "Pierre Smits" <[hidden email]>
>>>>> Hi Jacques,
>>>>> This is very cryptic. To what issue does this relate to, and to what
>>>>> application or component?
>>>>> Regards,
>>>>> Pierre
>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>>> <[hidden email]>het volgende:
>>>>>> Hi,
>>>>>>
>>>>>> Should we not remove this block and stuff related?
>>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>
>>

[Jacques Le Roux]

From: "Scott Gray" <[hidden email]>
> Hi Jaques,
>
> All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.

Thanks for the answer, with humour is better :o)

> On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote:
>
>> Hi Scott,
>>
>> So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev
>>
>> What did you not remove it?
>
> I figured it would be nicer for users if we waited until after a release.
>
>> Is there a reason or only an oversight?
>
> Do you mean why haven't I removed it after the 11.04 release?  Because we haven't had a next release yet.

Ha I did not understood that. I thought R11.04 was the next.

>> Is it the only thing to do?
>
> No, the property file also needs to be removed.
>
>> What about @Deprecated processEventReminder method?
>
> Do you mean processWorkEffortEventReminder?  Because #1 it's a service so deprecating it would do nothing and #2 only a block
> needs to be removed so why deprecate it?

No I meant: should we not remove also the WorkEffortServices.processEventReminder() deprecated method?

>> Should we keep EventReminders.properties file, etc. ?
>
> No the property file should also be removed, I don't know what else you're referring to with "etc."

Unknown, so I put etc. , ... in case (was not so clear to me)

So we will clear that with R12.04, right?

Jacques

>>
>> Jacques
>>
>> From: "Scott Gray" <[hidden email]>
>>> The instructions seem quite clear to me.
>>>
>>> Regards
>>> Scott
>>>
>>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>>>
>>>> I meant this should awake a committer, at least one person should be aware of that...
>>>>
>>>> Jacques
>>>>
>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>> Just look into *.java you will find it easily ;o)
>>>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>>>> Jacques
>>>>> From: "Pierre Smits" <[hidden email]>
>>>>>> Hi Jacques,
>>>>>> This is very cryptic. To what issue does this relate to, and to what
>>>>>> application or component?
>>>>>> Regards,
>>>>>> Pierre
>>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>>>> <[hidden email]>het volgende:
>>>>>>> Hi,
>>>>>>>
>>>>>>> Should we not remove this block and stuff related?
>>>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>
>>>
>
>

[Scott Gray-2]

On 8/04/2012, at 11:05 PM, Jacques Le Roux wrote:

> From: "Scott Gray" <[hidden email]>
>> Hi Jaques,
>>
>> All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.
>
> Thanks for the answer, with humour is better :o)
>
>> On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote:
>>
>>> Hi Scott,
>>>
>>> So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev
>>>
>>> What did you not remove it?
>>
>> I figured it would be nicer for users if we waited until after a release.
>>
>>> Is there a reason or only an oversight?
>>
>> Do you mean why haven't I removed it after the 11.04 release?  Because we haven't had a next release yet.
>
> Ha I did not understood that. I thought R11.04 was the next.

Sorry I mistyped the first sentence, I meant that 11.04 has been branched but not released.  Code shouldn't be removed until after the actual release.

>
>>> Is it the only thing to do?
>>
>> No, the property file also needs to be removed.
>>
>>> What about @Deprecated processEventReminder method?
>>
>> Do you mean processWorkEffortEventReminder?  Because #1 it's a service so deprecating it would do nothing and #2 only a block needs to be removed so why deprecate it?
>
> No I meant: should we not remove also the WorkEffortServices.processEventReminder() deprecated method?

Ah a different commit.  After the official release all code deprecated prior to the 11.04 branch should be removed.

>>> Should we keep EventReminders.properties file, etc. ?
>>
>> No the property file should also be removed, I don't know what else you're referring to with "etc."
>
> Unknown, so I put etc. , ... in case (was not so clear to me)
>
> So we will clear that with R12.04, right?

Sorry I don't understand the question.

> Jacques
>
>>>
>>> Jacques
>>>
>>> From: "Scott Gray" <[hidden email]>
>>>> The instructions seem quite clear to me.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>>>>
>>>>> I meant this should awake a committer, at least one person should be aware of that...
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>>> Just look into *.java you will find it easily ;o)
>>>>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>>>>> Jacques
>>>>>> From: "Pierre Smits" <[hidden email]>
>>>>>>> Hi Jacques,
>>>>>>> This is very cryptic. To what issue does this relate to, and to what
>>>>>>> application or component?
>>>>>>> Regards,
>>>>>>> Pierre
>>>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>>>>> <[hidden email]>het volgende:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Should we not remove this block and stuff related?
>>>>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>
>>>>
>>

[Jacques Le Roux]

From: "Scott Gray" <[hidden email]>

> On 8/04/2012, at 11:05 PM, Jacques Le Roux wrote:
>
>> From: "Scott Gray" <[hidden email]>
>>> Hi Jaques,
>>>
>>> All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.
>>
>> Thanks for the answer, with humour is better :o)
>>
>>> On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote:
>>>
>>>> Hi Scott,
>>>>
>>>> So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev
>>>>
>>>> What did you not remove it?
>>>
>>> I figured it would be nicer for users if we waited until after a release.
>>>
>>>> Is there a reason or only an oversight?
>>>
>>> Do you mean why haven't I removed it after the 11.04 release?  Because we haven't had a next release yet.
>>
>> Ha I did not understood that. I thought R11.04 was the next.
>
> Sorry I mistyped the first sentence, I meant that 11.04 has been branched but not released.  Code shouldn't be removed until after
> the actual release.
>
>>
>>>> Is it the only thing to do?
>>>
>>> No, the property file also needs to be removed.
>>>
>>>> What about @Deprecated processEventReminder method?
>>>
>>> Do you mean processWorkEffortEventReminder?  Because #1 it's a service so deprecating it would do nothing and #2 only a block
>>> needs to be removed so why deprecate it?
>>
>> No I meant: should we not remove also the WorkEffortServices.processEventReminder() deprecated method?
>
> Ah a different commit.  After the official release all code deprecated prior to the 11.04 branch should be removed.
>
>>>> Should we keep EventReminders.properties file, etc. ?
>>>
>>> No the property file should also be removed, I don't know what else you're referring to with "etc."
>>
>> Unknown, so I put etc. , ... in case (was not so clear to me)
>>
>> So we will clear that with R12.04, right?
>
> Sorry I don't understand the question.

Sorry I was not clear, actually forgot that R11.04 is not already officially released. So I meant rather "when we will release
R11.04" and now all is clear to me, thanks

Last question, should we not have a list of such changes somewhere (in a Jira related to release?), or a standard way to find them
quickly, or (another idea?)...

Jacques

>> Jacques
>>
>>>>
>>>> Jacques
>>>>
>>>> From: "Scott Gray" <[hidden email]>
>>>>> The instructions seem quite clear to me.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>>>>>
>>>>>> I meant this should awake a committer, at least one person should be aware of that...
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>>>> Just look into *.java you will find it easily ;o)
>>>>>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>>>>>> Jacques
>>>>>>> From: "Pierre Smits" <[hidden email]>
>>>>>>>> Hi Jacques,
>>>>>>>> This is very cryptic. To what issue does this relate to, and to what
>>>>>>>> application or component?
>>>>>>>> Regards,
>>>>>>>> Pierre
>>>>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>>>>>> <[hidden email]>het volgende:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Should we not remove this block and stuff related?
>>>>>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>
>>>>>
>>>
>
>

[Scott Gray-2]

On 8/04/2012, at 11:29 PM, Jacques Le Roux wrote:

> From: "Scott Gray" <[hidden email]>
>> On 8/04/2012, at 11:05 PM, Jacques Le Roux wrote:
>>
>>> From: "Scott Gray" <[hidden email]>
>>>> Hi Jaques,
>>>>
>>>> All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.
>>>
>>> Thanks for the answer, with humour is better :o)
>>>
>>>> On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote:
>>>>
>>>>> Hi Scott,
>>>>>
>>>>> So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev
>>>>>
>>>>> What did you not remove it?
>>>>
>>>> I figured it would be nicer for users if we waited until after a release.
>>>>
>>>>> Is there a reason or only an oversight?
>>>>
>>>> Do you mean why haven't I removed it after the 11.04 release?  Because we haven't had a next release yet.
>>>
>>> Ha I did not understood that. I thought R11.04 was the next.
>>
>> Sorry I mistyped the first sentence, I meant that 11.04 has been branched but not released.  Code shouldn't be removed until after the actual release.
>>
>>>
>>>>> Is it the only thing to do?
>>>>
>>>> No, the property file also needs to be removed.
>>>>
>>>>> What about @Deprecated processEventReminder method?
>>>>
>>>> Do you mean processWorkEffortEventReminder?  Because #1 it's a service so deprecating it would do nothing and #2 only a block needs to be removed so why deprecate it?
>>>
>>> No I meant: should we not remove also the WorkEffortServices.processEventReminder() deprecated method?
>>
>> Ah a different commit.  After the official release all code deprecated prior to the 11.04 branch should be removed.
>>
>>>>> Should we keep EventReminders.properties file, etc. ?
>>>>
>>>> No the property file should also be removed, I don't know what else you're referring to with "etc."
>>>
>>> Unknown, so I put etc. , ... in case (was not so clear to me)
>>>
>>> So we will clear that with R12.04, right?
>>
>> Sorry I don't understand the question.
>
> Sorry I was not clear, actually forgot that R11.04 is not already officially released. So I meant rather "when we will release R11.04" and now all is clear to me, thanks
>
> Last question, should we not have a list of such changes somewhere (in a Jira related to release?), or a standard way to find them quickly, or (another idea?)…

I should've added "Deprecated" to the comment on the block.  When I'm removing old code I search for deprecated then check the revision history to see when it happened, would be nice if we included the date everywhere to make it easier.

> Jacques
>
>>> Jacques
>>>
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Scott Gray" <[hidden email]>
>>>>>> The instructions seem quite clear to me.
>>>>>>
>>>>>> Regards
>>>>>> Scott
>>>>>>
>>>>>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>>>>>>
>>>>>>> I meant this should awake a committer, at least one person should be aware of that...
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>>>>> Just look into *.java you will find it easily ;o)
>>>>>>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>>>>>>> Jacques
>>>>>>>> From: "Pierre Smits" <[hidden email]>
>>>>>>>>> Hi Jacques,
>>>>>>>>> This is very cryptic. To what issue does this relate to, and to what
>>>>>>>>> application or component?
>>>>>>>>> Regards,
>>>>>>>>> Pierre
>>>>>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>>>>>>> <[hidden email]>het volgende:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Should we not remove this block and stuff related?
>>>>>>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>>
>>

[Jacques Le Roux]

From: "Scott Gray" <[hidden email]>

> On 8/04/2012, at 11:29 PM, Jacques Le Roux wrote:
>
>> From: "Scott Gray" <[hidden email]>
>>> On 8/04/2012, at 11:05 PM, Jacques Le Roux wrote:
>>>
>>>> From: "Scott Gray" <[hidden email]>
>>>>> Hi Jaques,
>>>>>
>>>>> All the answers are pretty obvious (to me at least) after a minute's look at the commit, but I'll humor you anyway.
>>>>
>>>> Thanks for the answer, with humour is better :o)
>>>>
>>>>> On 8/04/2012, at 10:08 PM, Jacques Le Roux wrote:
>>>>>
>>>>>> Hi Scott,
>>>>>>
>>>>>> So you committed this I see now http://svn.apache.org/viewvc?rev=1040016&view=rev
>>>>>>
>>>>>> What did you not remove it?
>>>>>
>>>>> I figured it would be nicer for users if we waited until after a release.
>>>>>
>>>>>> Is there a reason or only an oversight?
>>>>>
>>>>> Do you mean why haven't I removed it after the 11.04 release?  Because we haven't had a next release yet.
>>>>
>>>> Ha I did not understood that. I thought R11.04 was the next.
>>>
>>> Sorry I mistyped the first sentence, I meant that 11.04 has been branched but not released.  Code shouldn't be removed until
>>> after the actual release.
>>>
>>>>
>>>>>> Is it the only thing to do?
>>>>>
>>>>> No, the property file also needs to be removed.
>>>>>
>>>>>> What about @Deprecated processEventReminder method?
>>>>>
>>>>> Do you mean processWorkEffortEventReminder?  Because #1 it's a service so deprecating it would do nothing and #2 only a block
>>>>> needs to be removed so why deprecate it?
>>>>
>>>> No I meant: should we not remove also the WorkEffortServices.processEventReminder() deprecated method?
>>>
>>> Ah a different commit.  After the official release all code deprecated prior to the 11.04 branch should be removed.
>>>
>>>>>> Should we keep EventReminders.properties file, etc. ?
>>>>>
>>>>> No the property file should also be removed, I don't know what else you're referring to with "etc."
>>>>
>>>> Unknown, so I put etc. , ... in case (was not so clear to me)
>>>>
>>>> So we will clear that with R12.04, right?
>>>
>>> Sorry I don't understand the question.
>>
>> Sorry I was not clear, actually forgot that R11.04 is not already officially released. So I meant rather "when we will release
>> R11.04" and now all is clear to me, thanks
>>
>> Last question, should we not have a list of such changes somewhere (in a Jira related to release?), or a standard way to find
>> them quickly, or (another idea?)…
>
> I should've added "Deprecated" to the comment on the block.  When I'm removing old code I search for deprecated then check the
> revision history to see when it happened, would be nice if we included the date everywhere to make it easier.

OK, sounds like the best way indeed

Thanks

Jacques

>> Jacques
>>
>>>> Jacques
>>>>
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Scott Gray" <[hidden email]>
>>>>>>> The instructions seem quite clear to me.
>>>>>>>
>>>>>>> Regards
>>>>>>> Scott
>>>>>>>
>>>>>>> On 7/04/2012, at 10:09 PM, Jacques Le Roux wrote:
>>>>>>>
>>>>>>>> I meant this should awake a committer, at least one person should be aware of that...
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>> From: "Jacques Le Roux" <[hidden email]>
>>>>>>>>> Just look into *.java you will find it easily ;o)
>>>>>>>>> It's in WorkEffortServices.processWorkEffortEventReminder()
>>>>>>>>> Jacques
>>>>>>>>> From: "Pierre Smits" <[hidden email]>
>>>>>>>>>> Hi Jacques,
>>>>>>>>>> This is very cryptic. To what issue does this relate to, and to what
>>>>>>>>>> application or component?
>>>>>>>>>> Regards,
>>>>>>>>>> Pierre
>>>>>>>>>> Op 7 april 2012 11:12 schreef Jacques Le Roux
>>>>>>>>>> <[hidden email]>het volgende:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Should we not remove this block and stuff related?
>>>>>>>>>>> // TODO: Remove this block after the next release 2010-11-29
>>>>>>>>>>>
>>>>>>>>>>> Jacques
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>
>>>
>
>