ports in test-containers.xml

[Erwan de FERRIERES-3]

Hi all,

I'm planning on changing the ports for the http and https test
containers. This way, tests can be runned on the Apache jenkins instance
(8080 is already used).

Is there anyone against these ?

Cheers,

--
Erwan de FERRIERES
www.nereide.biz

[Jacques Le Roux]

+1, I can't see any issues changing default OOTB

Jacques

From: "Erwan de FERRIERES" <[hidden email]>

> Hi all,
>
> I'm planning on changing the ports for the http and https test
> containers. This way, tests can be runned on the Apache jenkins instance
> (8080 is already used).
>
> Is there anyone against these ?
>
> Cheers,
>
> --
> Erwan de FERRIERES
> www.nereide.biz

[David E. Jones-2]

As long as it is just for the test-containers.xml file.

I would be against changing this for the ofbiz-containers.xml file, too many people are used to it and too much documentation points to it, so changing it there would require a significant effort to change docs and communicate the difference, and deal with questions on the mailing lists about the change...

-David


On May 13, 2011, at 8:02 AM, Jacques Le Roux wrote:

> +1, I can't see any issues changing default OOTB
>
> Jacques
>
> From: "Erwan de FERRIERES" <[hidden email]>
>> Hi all,
>> I'm planning on changing the ports for the http and https test containers. This way, tests can be runned on the Apache jenkins instance (8080 is already used).
>> Is there anyone against these ?
>> Cheers,
>> --
>> Erwan de FERRIERES
>> www.nereide.biz
>

[Jacques Le Roux]

Of course I meant only for test. I was stuck with it also when I had to run a stagging instance (manual tests) and a test instance
(Continuous Integration running tests) on the same machine.

Jacques

From: "David E Jones" <[hidden email]>

> As long as it is just for the test-containers.xml file.
>
> I would be against changing this for the ofbiz-containers.xml file, too many people are used to it and too much documentation
> points to it, so changing it there would require a significant effort to change docs and communicate the difference, and deal with
> questions on the mailing lists about the change...
>
> -David
>
>
> On May 13, 2011, at 8:02 AM, Jacques Le Roux wrote:
>
>> +1, I can't see any issues changing default OOTB
>>
>> Jacques
>>
>> From: "Erwan de FERRIERES" <[hidden email]>
>>> Hi all,
>>> I'm planning on changing the ports for the http and https test containers. This way, tests can be runned on the Apache jenkins
>>> instance (8080 is already used).
>>> Is there anyone against these ?
>>> Cheers,
>>> --
>>> Erwan de FERRIERES
>>> www.nereide.biz
>>
>

[Pierre Smits]

+1

Op 14 mei 2011 10:12 schreef Jacques Le Roux
<[hidden email]>het volgende:

> Of course I meant only for test. I was stuck with it also when I had to
> run a stagging instance (manual tests) and a test instance (Continuous
> Integration running tests) on the same machine.
>
> Jacques
>
> From: "David E Jones" <[hidden email]>
>
>  As long as it is just for the test-containers.xml file.
>>
>> I would be against changing this for the ofbiz-containers.xml file, too
>> many people are used to it and too much documentation points to it, so
>> changing it there would require a significant effort to change docs and
>> communicate the difference, and deal with questions on the mailing lists
>> about the change...
>>
>> -David
>>
>>
>> On May 13, 2011, at 8:02 AM, Jacques Le Roux wrote:
>>
>>  +1, I can't see any issues changing default OOTB
>>>
>>> Jacques
>>>
>>> From: "Erwan de FERRIERES" <erwan.de-ferrieres@nereide.**biz<[hidden email]>
>>> >
>>>
>>>> Hi all,
>>>> I'm planning on changing the ports for the http and https test
>>>> containers. This way, tests can be runned on the Apache jenkins instance
>>>> (8080 is already used).
>>>> Is there anyone against these ?
>>>> Cheers,
>>>> --
>>>> Erwan de FERRIERES
>>>> www.nereide.biz
>>>>
>>>
>>>
>>
>
>

[Jacopo Cappellato-4]

+1

On May 13, 2011, at 3:23 PM, Erwan de FERRIERES wrote:

> Hi all,
>
> I'm planning on changing the ports for the http and https test containers. This way, tests can be runned on the Apache jenkins instance (8080 is already used).
>
> Is there anyone against these ?
>
> Cheers,
>
> --
> Erwan de FERRIERES
> www.nereide.biz

[Pierre Smits]

I will create a JIRA for this,

But for testing what port numbers will we have for:

   - ajp
   - http
   - https
   - others?

Regards,

Pierre

Op 8 april 2012 07:54 schreef Jacopo Cappellato <
[hidden email]> het volgende:

> +1
>
> On May 13, 2011, at 3:23 PM, Erwan de FERRIERES wrote:
>
> > Hi all,
> >
> > I'm planning on changing the ports for the http and https test
> containers. This way, tests can be runned on the Apache jenkins instance
> (8080 is already used).
> >
> > Is there anyone against these ?
> >
> > Cheers,
> >
> > --
> > Erwan de FERRIERES
> > www.nereide.biz
>
>

[Jacques Le Roux]

I suggest to increase by one the last ports numbers to avoid collission even when shifted (see below) for instance

RMI =  1099+1 = 1100

>   - ajp
8009+1 = 8010

etc.

Because I already suggested to follow Geronimo's way in "OFBiz integration in Apache sonar instance" thread

>>>>> Geronimo does this. They pass a value through their scripts. It
>>>>> should not be too hard to copy/adapt. Of course it should be used
>>>>> not only for the test-container files but with all containers files.
>>>>> Then it will be easy and clean to change > the ports for an
>>>>> instance.
>>>>> The idea is to pass a shift value to all ports, rather than a
>>>>> value for each ports. For instance 1 means 18080, 18443, 11099,
>>>>> etc.;
>>>>> 2 means 28080, 28443, 21099

http://markmail.org/message/mgmhrqchjjmo776q

Erwan opened https://issues.apache.org/jira/browse/OFBIZ-4763 for that

Jacques


From: "Pierre Smits" <[hidden email]>

>I will create a JIRA for this,
>
> But for testing what port numbers will we have for:
>
>   - ajp
>   - http
>   - https
>   - others?
>
> Regards,
>
> Pierre
>
> Op 8 april 2012 07:54 schreef Jacopo Cappellato <
> [hidden email]> het volgende:
>
>> +1
>>
>> On May 13, 2011, at 3:23 PM, Erwan de FERRIERES wrote:
>>
>> > Hi all,
>> >
>> > I'm planning on changing the ports for the http and https test
>> containers. This way, tests can be runned on the Apache jenkins instance
>> (8080 is already used).
>> >
>> > Is there anyone against these ?
>> >
>> > Cheers,
>> >
>> > --
>> > Erwan de FERRIERES
>> > www.nereide.biz
>>
>>
>

[Pierre Smits]

Hi all,

As it is more likely that port numbers near the ones we have are already
taken, I support the schema mentioned by Jacques relating to the Geronimo
variant.

1 & current port number for integrated testing set ups (Jenkins), leading
to:
11099
18009
18080
18443

Regards,

Pierre

Op 8 april 2012 12:17 schreef Jacques Le Roux
<[hidden email]>het volgende:

> I suggest to increase by one the last ports numbers to avoid collission
> even when shifted (see below) for instance
> RMI =  1099+1 = 1100
>
>   - ajp
>>
> 8009+1 = 8010
>
> etc.
>
> Because I already suggested to follow Geronimo's way in "OFBiz integration
> in Apache sonar instance" thread
>
>  Geronimo does this. They pass a value through their scripts. It should
>>>>>> not be too hard to copy/adapt. Of course it should be used not only for the
>>>>>> test-container files but with all containers files. Then it will be easy
>>>>>> and clean to change > the ports for an instance.
>>>>>> The idea is to pass a shift value to all ports, rather than a value
>>>>>> for each ports. For instance 1 means 18080, 18443, 11099, etc.;
>>>>>> 2 means 28080, 28443, 21099
>>>>>>
>>>>>
> http://markmail.org/message/**mgmhrqchjjmo776q<http://markmail.org/message/mgmhrqchjjmo776q>
>
> Erwan opened https://issues.apache.org/**jira/browse/OFBIZ-4763<https://issues.apache.org/jira/browse/OFBIZ-4763>for that
>
> Jacques
>
>
> From: "Pierre Smits" <[hidden email]>
>
>> I will create a JIRA for this,
>>
>> But for testing what port numbers will we have for:
>>
>>  - ajp
>>  - http
>>  - https
>>  - others?
>>
>>
>> Regards,
>>
>> Pierre
>>
>> Op 8 april 2012 07:54 schreef Jacopo Cappellato <
>> jacopo.cappellato@hotwaxmedia.**com <[hidden email]>>
>> het volgende:
>>
>>  +1
>>>
>>> On May 13, 2011, at 3:23 PM, Erwan de FERRIERES wrote:
>>>
>>> > Hi all,
>>> >
>>> > I'm planning on changing the ports for the http and https test
>>> containers. This way, tests can be runned on the Apache jenkins instance
>>> (8080 is already used).
>>> >
>>> > Is there anyone against these ?
>>> >
>>> > Cheers,
>>> >
>>> > --
>>> > Erwan de FERRIERES
>>> > www.nereide.biz
>>>
>>>
>>>
>>

[Jacques Le Roux]

Mmm, nope, sorry you did not get my point Pierre,

What I mean is this for test-containers.xml ports

>> RMI =  1099+1 = 1100
>>
>>   - ajp
>>>
>> 8009+1 = 8010


1. In all case change test-containers.xml ports by adding 1 to them (I added 1, we could add 100 or whatever). That is change them
now and commit. This way we can run test and ofbiz containers concurrently on the same machine OOTB w/out any other changes.
2. If we want to run many OFBiz instances on the same machine (being test or normal instances) we need a way to easily shift all
ports, this is what https://issues.apache.org/jira/browse/OFBIZ-4763 is supposed to be

For instance you could want to not only run many OFBiz instances on the same machine (eg: for devs manual tests on staging) but also
many test instances on another one.
One test instance may run only quick check (for instance unit tests only on custom code) when another one will run the complete set
of tests (to detect regressions on core code for instance, rare but really harmful)

Hope I'm more clear... :o)

Jacques

From: "Pierre Smits" <[hidden email]>

> Hi all,
>
> As it is more likely that port numbers near the ones we have are already
> taken, I support the schema mentioned by Jacques relating to the Geronimo
> variant.
>
> 1 & current port number for integrated testing set ups (Jenkins), leading
> to:
> 11099
> 18009
> 18080
> 18443
>
> Regards,
>
> Pierre
>
> Op 8 april 2012 12:17 schreef Jacques Le Roux
> <[hidden email]>het volgende:
>
>> I suggest to increase by one the last ports numbers to avoid collission
>> even when shifted (see below) for instance
>> RMI =  1099+1 = 1100
>>
>>   - ajp
>>>
>> 8009+1 = 8010
>>
>> etc.
>>
>> Because I already suggested to follow Geronimo's way in "OFBiz integration
>> in Apache sonar instance" thread
>>
>>  Geronimo does this. They pass a value through their scripts. It should
>>>>>>> not be too hard to copy/adapt. Of course it should be used not only for the
>>>>>>> test-container files but with all containers files. Then it will be easy
>>>>>>> and clean to change > the ports for an instance.
>>>>>>> The idea is to pass a shift value to all ports, rather than a value
>>>>>>> for each ports. For instance 1 means 18080, 18443, 11099, etc.;
>>>>>>> 2 means 28080, 28443, 21099
>>>>>>>
>>>>>>
>> http://markmail.org/message/**mgmhrqchjjmo776q<http://markmail.org/message/mgmhrqchjjmo776q>
>>
>> Erwan opened https://issues.apache.org/**jira/browse/OFBIZ-4763<https://issues.apache.org/jira/browse/OFBIZ-4763>for that
>>
>> Jacques
>>
>>
>> From: "Pierre Smits" <[hidden email]>
>>
>>> I will create a JIRA for this,
>>>
>>> But for testing what port numbers will we have for:
>>>
>>>  - ajp
>>>  - http
>>>  - https
>>>  - others?
>>>
>>>
>>> Regards,
>>>
>>> Pierre
>>>
>>> Op 8 april 2012 07:54 schreef Jacopo Cappellato <
>>> jacopo.cappellato@hotwaxmedia.**com <[hidden email]>>
>>> het volgende:
>>>
>>>  +1
>>>>
>>>> On May 13, 2011, at 3:23 PM, Erwan de FERRIERES wrote:
>>>>
>>>> > Hi all,
>>>> >
>>>> > I'm planning on changing the ports for the http and https test
>>>> containers. This way, tests can be runned on the Apache jenkins instance
>>>> (8080 is already used).
>>>> >
>>>> > Is there anyone against these ?
>>>> >
>>>> > Cheers,
>>>> >
>>>> > --
>>>> > Erwan de FERRIERES
>>>> > www.nereide.biz
>>>>
>>>>
>>>>
>>>
>

[Pierre Smits]

Hi Jacques, all,

I concur that we need

   1. a change of base port numbers in test-containers.xml to enable
   continuous integration for sequential testing (as standard ports are
   already (most likely) used by the underlying application server).
   2. a dynamic change of port numbers to enable continuous integration for
   parallel testing (in accordance with your proposal of base portnumber + n).

Regards,

Pierre

Op 8 april 2012 13:23 schreef Jacques Le Roux
<[hidden email]>het volgende:

> Mmm, nope, sorry you did not get my point Pierre,
>
> What I mean is this for test-containers.xml ports
>
>
>  RMI =  1099+1 = 1100
>>>
>>>  - ajp
>>>
>>>>
>>>>  8009+1 = 8010
>>>
>>
>
> 1. In all case change test-containers.xml ports by adding 1 to them (I
> added 1, we could add 100 or whatever). That is change them now and commit.
> This way we can run test and ofbiz containers concurrently on the same
> machine OOTB w/out any other changes.
> 2. If we want to run many OFBiz instances on the same machine (being test
> or normal instances) we need a way to easily shift all ports, this is what
> https://issues.apache.org/**jira/browse/OFBIZ-4763<https://issues.apache.org/jira/browse/OFBIZ-4763>is supposed to be
>
> For instance you could want to not only run many OFBiz instances on the
> same machine (eg: for devs manual tests on staging) but also many test
> instances on another one.
> One test instance may run only quick check (for instance unit tests only
> on custom code) when another one will run the complete set of tests (to
> detect regressions on core code for instance, rare but really harmful)
>
> Hope I'm more clear... :o)
>
>
> Jacques
>
> From: "Pierre Smits" <[hidden email]>
>
>> Hi all,
>>
>>
>> As it is more likely that port numbers near the ones we have are already
>> taken, I support the schema mentioned by Jacques relating to the Geronimo
>> variant.
>>
>> 1 & current port number for integrated testing set ups (Jenkins), leading
>> to:
>> 11099
>> 18009
>> 18080
>> 18443
>>
>> Regards,
>>
>> Pierre
>>
>> Op 8 april 2012 12:17 schreef Jacques Le Roux
>> <[hidden email]>**het volgende:
>>
>>  I suggest to increase by one the last ports numbers to avoid collission
>>> even when shifted (see below) for instance
>>> RMI =  1099+1 = 1100
>>>
>>>  - ajp
>>>
>>>>
>>>>  8009+1 = 8010
>>>
>>> etc.
>>>
>>> Because I already suggested to follow Geronimo's way in "OFBiz
>>> integration
>>> in Apache sonar instance" thread
>>>
>>>  Geronimo does this. They pass a value through their scripts. It should
>>>
>>>> not be too hard to copy/adapt. Of course it should be used not only for
>>>>>>>> the
>>>>>>>> test-container files but with all containers files. Then it will be
>>>>>>>> easy
>>>>>>>> and clean to change > the ports for an instance.
>>>>>>>> The idea is to pass a shift value to all ports, rather than a value
>>>>>>>> for each ports. For instance 1 means 18080, 18443, 11099, etc.;
>>>>>>>> 2 means 28080, 28443, 21099
>>>>>>>>
>>>>>>>>
>>>>>>>  http://markmail.org/message/****mgmhrqchjjmo776q<http://markmail.org/message/**mgmhrqchjjmo776q>
>>> <http://**markmail.org/message/**mgmhrqchjjmo776q<http://markmail.org/message/mgmhrqchjjmo776q>
>>> >
>>>
>>> Erwan opened https://issues.apache.org/****jira/browse/OFBIZ-4763<https://issues.apache.org/**jira/browse/OFBIZ-4763>
>>> <https:/**/issues.apache.org/jira/**browse/OFBIZ-4763<https://issues.apache.org/jira/browse/OFBIZ-4763>>for
>>> that
>>>
>>>
>>> Jacques
>>>
>>>
>>> From: "Pierre Smits" <[hidden email]>
>>>
>>>  I will create a JIRA for this,
>>>>
>>>> But for testing what port numbers will we have for:
>>>>
>>>>  - ajp
>>>>  - http
>>>>  - https
>>>>  - others?
>>>>
>>>>
>>>> Regards,
>>>>
>>>> Pierre
>>>>
>>>> Op 8 april 2012 07:54 schreef Jacopo Cappellato <
>>>> jacopo.cappellato@hotwaxmedia.****com <jacopo.cappellato@**
>>>> hotwaxmedia.com <[hidden email]>>>
>>>>
>>>> het volgende:
>>>>
>>>>  +1
>>>>
>>>>>
>>>>> On May 13, 2011, at 3:23 PM, Erwan de FERRIERES wrote:
>>>>>
>>>>> > Hi all,
>>>>> >
>>>>> > I'm planning on changing the ports for the http and https test
>>>>> containers. This way, tests can be runned on the Apache jenkins
>>>>> instance
>>>>> (8080 is already used).
>>>>> >
>>>>> > Is there anyone against these ?
>>>>> >
>>>>> > Cheers,
>>>>> >
>>>>> > --
>>>>> > Erwan de FERRIERES
>>>>> > www.nereide.biz
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>

[Jacques Le Roux]

From: "Jacques Le Roux" <[hidden email]>
> For instance you could want to not only run many OFBiz instances on the same machine (eg: for devs manual tests on staging) but
> also many test instances on another one.
> One test instance may run only quick check (for instance unit tests only on custom code) when another one will run the complete
> set of tests (to detect regressions on core code for instance, rare but really harmful)

This is inspired by http://martinfowler.com/articles/continuousIntegration.html#KeepTheBuildFast

Jacques

[Pierre Smits]

Indeed!

Op 8 april 2012 13:36 schreef Jacques Le Roux
<[hidden email]>het volgende:

> From: "Jacques Le Roux" <[hidden email]>
>
>  For instance you could want to not only run many OFBiz instances on the
>> same machine (eg: for devs manual tests on staging) but also many test
>> instances on another one.
>> One test instance may run only quick check (for instance unit tests only
>> on custom code) when another one will run the complete set of tests (to
>> detect regressions on core code for instance, rare but really harmful)
>>
>
> This is inspired by http://martinfowler.com/**articles/**
> continuousIntegration.html#**KeepTheBuildFast<http://martinfowler.com/articles/continuousIntegration.html#KeepTheBuildFast>
>
> Jacques