OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4787) Party Manager Default Country in Update

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4787) Party Manager Default Country in Update

Party Manager Default Country in Update
---------------------------------------

Key: OFBIZ-4787
URL: https://issues.apache.org/jira/browse/OFBIZ-4787
Project: OFBiz
Issue Type: Bug
Components: party
Affects Versions: SVN trunk
Environment: demo-trunk
Reporter: Tom Burns
Priority: Minor

In Party Manager > Profile > Contact Information > Update the "Country" drop down always defaults to "United States".
This is misleading if the Country is not "United States".
If a user were to change some other address element he/she would have to also re-set "Country" to keep it from being changed to "United States".

To reproduce:
In Party Manager lookup a party with a "Postal Address" say "DemoSupplier"*
In Contact Information > Postal Address Click "Update"
In the Country field select any country but "United States" say Switzerland
Click "Save"

Note -
Expect drop down default after save = "Switzerland"
Actual drop down default after save = "United States"

Click "Go Back"
Expect "Postal Address" country = "Switzerland"
Actual "Postal Address" country = "Switzerland"

Click
Click "Update"
Expect drop down default to be "Switzerland"
Actual "United States"

* Note:
Select any party but Company.
It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount.
This may be a separate issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4787) Party Manager Default Country in Update

[ https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Burns updated OFBIZ-4787:
-----------------------------

Attachment: OFBIZ-4787 defaultCountryGeoId.patch

> Party Manager Default Country in Update
> ---------------------------------------
>
> Key: OFBIZ-4787
> URL: https://issues.apache.org/jira/browse/OFBIZ-4787
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Priority: Minor
> Attachments: OFBIZ-4787 defaultCountryGeoId.patch
>
>
> In Party Manager > Profile > Contact Information > Update the "Country" drop down always defaults to "United States".
> This is misleading if the Country is not "United States".
> If a user were to change some other address element he/she would have to also re-set "Country" to keep it from being changed to "United States".
> To reproduce:
> In Party Manager lookup a party with a "Postal Address" say "DemoSupplier"*
> In Contact Information > Postal Address Click "Update"
> In the Country field select any country but "United States" say Switzerland
> Click "Save"
> Note -
> Expect drop down default after save = "Switzerland"
> Actual drop down default after save = "United States"
> Click "Go Back"
> Expect "Postal Address" country = "Switzerland"
> Actual "Postal Address" country = "Switzerland"
> Click
> Click "Update"
> Expect drop down default to be "Switzerland"
> Actual "United States"
> * Note:
> Select any party but Company.
> It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount.
> This may be a separate issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4787) Party Manager Default Country in Update

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248481#comment-13248481 ]

Tom Burns commented on OFBIZ-4787:
----------------------------------

Patch is a work around.
In editcontactmech.ftl the inclusion of the Common Screen handling for Country drop down is removed and replaced with the logic form countries.ftl.
An alternative would be to add logic to the Common Screen however it is used throughout the code base and require a lot more testing.

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4787) Party Manager Default Country in Update

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4787.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 11.04
Assignee: Jacques Le Roux

Thanks for detailled report Tom,

I did not use your patch. 2 years ago I introduced setDependentDropdownValuesJs.ftl to handle Dependent Dropdowns. But I did not provide any examples of its uses in Freemarker templates.

In trunk at revision 1310953 I have committed a fix for the issue you reported using setDependentDropdownValuesJs.ftl.
Also in R11.04 at r1310955.

I would really appreciate if you could use the same and fix also the other EditContactMech.ftl (eCommerce and Facility). It will also a good opportunity for you to learn how to use it (it's quite simple actually see [r1310953|http://svn.apache.org/viewvc?view=revision&revision=1310953]

> Party Manager Default Country in Update
> ---------------------------------------
>
> Key: OFBIZ-4787
> URL: https://issues.apache.org/jira/browse/OFBIZ-4787
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4787 defaultCountryGeoId.patch
>
>
> In Party Manager > Profile > Contact Information > Update the "Country" drop down always defaults to "United States".
> This is misleading if the Country is not "United States".
> If a user were to change some other address element he/she would have to also re-set "Country" to keep it from being changed to "United States".
> To reproduce:
> In Party Manager lookup a party with a "Postal Address" say "DemoSupplier"*
> In Contact Information > Postal Address Click "Update"
> In the Country field select any country but "United States" say Switzerland
> Click "Save"
> Note -
> Expect drop down default after save = "Switzerland"
> Actual drop down default after save = "United States"
> Click "Go Back"
> Expect "Postal Address" country = "Switzerland"
> Actual "Postal Address" country = "Switzerland"
> Click
> Click "Update"
> Expect drop down default to be "Switzerland"
> Actual "United States"
> * Note:
> Select any party but Company.
> It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount.
> This may be a separate issue.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4787) Party Manager Default Country in Update

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249482#comment-13249482 ]

Jacques Le Roux commented on OFBIZ-4787:
----------------------------------------

Tom,

Please open a new Jira for "It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount."

Thanks

> Party Manager Default Country in Update
> ---------------------------------------
>
> Key: OFBIZ-4787
> URL: https://issues.apache.org/jira/browse/OFBIZ-4787
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4787 defaultCountryGeoId.patch
>
>
> In Party Manager > Profile > Contact Information > Update the "Country" drop down always defaults to "United States".
> This is misleading if the Country is not "United States".
> If a user were to change some other address element he/she would have to also re-set "Country" to keep it from being changed to "United States".
> To reproduce:
> In Party Manager lookup a party with a "Postal Address" say "DemoSupplier"*
> In Contact Information > Postal Address Click "Update"
> In the Country field select any country but "United States" say Switzerland
> Click "Save"
> Note -
> Expect drop down default after save = "Switzerland"
> Actual drop down default after save = "United States"
> Click "Go Back"
> Expect "Postal Address" country = "Switzerland"
> Actual "Postal Address" country = "Switzerland"
> Click
> Click "Update"
> Expect drop down default to be "Switzerland"
> Actual "United States"
> * Note:
> Select any party but Company.
> It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount.
> This may be a separate issue.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4787) Party Manager Default Country in Update

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249562#comment-13249562 ]

Tom Burns commented on OFBIZ-4787:
----------------------------------

I will create a new issue for "It's country..."

Your patch is a hidden gem. The lack of context sensitivity in drop downs is a major OFBiz usability issue in my mind and the Country / State presentation is a poster child for the problem.
I'll open a new improvement issue for eCommerce and Facility since you have closed this one.

Tom

> Party Manager Default Country in Update
> ---------------------------------------
>
> Key: OFBIZ-4787
> URL: https://issues.apache.org/jira/browse/OFBIZ-4787
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4787 defaultCountryGeoId.patch
>
>
> In Party Manager > Profile > Contact Information > Update the "Country" drop down always defaults to "United States".
> This is misleading if the Country is not "United States".
> If a user were to change some other address element he/she would have to also re-set "Country" to keep it from being changed to "United States".
> To reproduce:
> In Party Manager lookup a party with a "Postal Address" say "DemoSupplier"*
> In Contact Information > Postal Address Click "Update"
> In the Country field select any country but "United States" say Switzerland
> Click "Save"
> Note -
> Expect drop down default after save = "Switzerland"
> Actual drop down default after save = "United States"
> Click "Go Back"
> Expect "Postal Address" country = "Switzerland"
> Actual "Postal Address" country = "Switzerland"
> Click
> Click "Update"
> Expect drop down default to be "Switzerland"
> Actual "United States"
> * Note:
> Select any party but Company.
> It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount.
> This may be a separate issue.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4787) Party Manager Default Country in Update

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249574#comment-13249574 ]

Jacques Le Roux commented on OFBIZ-4787:
----------------------------------------

Thank you for the compliment. Actually it's not that hidden. If you look at the examples: https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples#DropDownFieldsExampleForm_geoId_title

But I must say a clear example with Freemarker was missing indeed.

Looking forwar for eCommerce and Facility. A Jira for each would be better...

> Party Manager Default Country in Update
> ---------------------------------------
>
> Key: OFBIZ-4787
> URL: https://issues.apache.org/jira/browse/OFBIZ-4787
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Environment: demo-trunk
> Reporter: Tom Burns
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4787 defaultCountryGeoId.patch
>
>
> In Party Manager > Profile > Contact Information > Update the "Country" drop down always defaults to "United States".
> This is misleading if the Country is not "United States".
> If a user were to change some other address element he/she would have to also re-set "Country" to keep it from being changed to "United States".
> To reproduce:
> In Party Manager lookup a party with a "Postal Address" say "DemoSupplier"*
> In Contact Information > Postal Address Click "Update"
> In the Country field select any country but "United States" say Switzerland
> Click "Save"
> Note -
> Expect drop down default after save = "Switzerland"
> Actual drop down default after save = "United States"
> Click "Go Back"
> Expect "Postal Address" country = "Switzerland"
> Actual "Postal Address" country = "Switzerland"
> Click
> Click "Update"
> Expect drop down default to be "Switzerland"
> Actual "United States"
> * Note:
> Select any party but Company.
> It's Country can not be changed because a foreign missing parameter on a call to updateEftAccount.
> This may be a separate issue.