Hi Taher,
The initial script was written by Gavin from infra long ago. Since then I'm mostly the maintainer.
The script has changed a lot. Last iteration for the split had more impact. It's not yet completely done. For instance I still wonder about splitting
plugins for archives and especially RAT.
I used externals because it was easy to do, comes at no cost once done and also because I had nothing else at hand. I did both testing: Buildbot and
locally. I tested ofbiz-framework-buildbot locally, works perfectly. On Buildbot the 8080 port issue resurfaced, that's on infra side...
We could indeed instead use the ofbiz-framework branch and a new pullAllPluginsSource Gradle task. For that we would add a new step like
f_ofb_1.addStep(ShellCommand(command=["gradle", "--stacktrace", "pullAllPluginsSource"],
haltOnFailure=True,
))
before the build step and would refer to ofbiz-framework and not ofbiz-framework-buildbot in the BuildBot script.
The only difference is you have to maintain the pullAllPluginsSource, while externals don't need it. Anyway, logically we will maintain
pullAllPluginsSource. I guess with an external list of components (text file) used by pullPluginSource. So that should not be a problem.
Remains the questions on splitting plugins for archives and RAT. If we want to define plugins as another product then we need another archive. RAT
could be done with integration tests. Simpler but we lose the notion of product, maybe not an issue.
Note: I'm not sure yet why, the RAT builds were not launched, to be continued...
Jacques
Le 14/02/2017 à 12:53, Taher Alkhateeb a écrit :
> Hi Jacques,
>
> Is this script written by us or infra? Do you do local testing or only on
> buildbot? And finally, why did we introduce svn:externals through a new
> branch? I thought we had a discussion about using the gradle system itself
> to fetch dependencies
>
> Regards,
>
> On Tue, Feb 14, 2017 at 1:34 PM, Jacques Le Roux <
>
[hidden email]> wrote:
>
>> Yes sure:
https://svn.apache.org/repos/infra/infrastructure/buildbot/a>> egis/buildmaster/master1/projects/ofbiz.conf
>>
>> Jacques
>>
>>
>>
>> Le 14/02/2017 à 11:28, Taher Alkhateeb a écrit :
>>
>>> Hi Jacques,
>>>
>>> I'm a little lost on the entire build process, can you please explain how
>>> the whole thing is structured? how many buildbot instances for each
>>> project
>>> and how the whole thing is structured. Better yet, can we take a look at
>>> the buildbot scripts?
>>>
>>> Regards,
>>>
>>> Taher Alkhateeb
>>>
>>> On Tue, Feb 14, 2017 at 11:26 AM, Jacques Le Roux <
>>>
[hidden email]> wrote:
>>>
>>> Hi,
>>>> The ofbiz-framework-buildbot branch should not only be used by Buildbot
>>>> but also when testing a complete integration is needed.
>>>>
>>>> So if you make change in plugins remember to use the
>>>> ofbiz-framework-buildbot to test your changes
>>>>
>>>> BTW since it needs to check all the externals before starting it takes a
>>>> bit more time to initialise.
>>>>
>>>> For this reason I will remove the svn:externals for static files in the
>>>> root (LICENCE, NOTICE, etc.) Those files are of no interest for
>>>> integration
>>>> tests
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>>
>>>>
>
Locked
