Users - Is this a typo/bug/or misuse?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Users - Is this a typo/bug/or misuse?

Ruth Hoffman
${cartLine.getItemTypeDescription()?if_exists} maybe should be:

${cartLine.getItemType()?if_exists} or ${cartLine.getName()?if_exists}

This shows up in a few places - showcart.ftl, splitship.ftl,minicart.ftl

When I view a cart after adding an item with no product id (a
non-product item) I get the following error. Here's the start of the
error...

*Method public java.lang.String
org.ofbiz.order.shoppingcart.ShoppingCartItem.getItemTypeDescription()
threw an exception when invoked on
org.ofbiz.order.shoppingcart.ShoppingCartItem@e4281f The problematic
instruction: ---------- ==>
${cartLine.getItemTypeDescription()?if_exists} [on line 58, column 47 in
minicart.ftl] ---------- Java backtrace for programmers: ----------
freemarker.template.TemplateModelException: Method public*

A quick look at ShoppingCartItem suggests that this method is going out
and looking for descriptions based on OrderItemTypes. In my case, I
don't have any OrderItemType's on record for this non-product item. Is
that my problem? Should I not be adding something to the shopping cart
that doesn't have a link to an OrderItemType.

Ruth
 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - Is this a typo/bug/or misuse?

Jacopo Cappellato
Hi Ruth,

this should be fixed in svn rev. 7555

Could you please make a few tests and let me know?

Thanks

Jacopo


Ruth Hoffman wrote:

> ${cartLine.getItemTypeDescription()?if_exists} maybe should be:
>
> ${cartLine.getItemType()?if_exists} or ${cartLine.getName()?if_exists}
>
> This shows up in a few places - showcart.ftl, splitship.ftl,minicart.ftl
>
> When I view a cart after adding an item with no product id (a
> non-product item) I get the following error. Here's the start of the
> error...
>
> *Method public java.lang.String
> org.ofbiz.order.shoppingcart.ShoppingCartItem.getItemTypeDescription()
> threw an exception when invoked on
> org.ofbiz.order.shoppingcart.ShoppingCartItem@e4281f The problematic
> instruction: ---------- ==>
> ${cartLine.getItemTypeDescription()?if_exists} [on line 58, column 47 in
> minicart.ftl] ---------- Java backtrace for programmers: ----------
> freemarker.template.TemplateModelException: Method public*
>
> A quick look at ShoppingCartItem suggests that this method is going out
> and looking for descriptions based on OrderItemTypes. In my case, I
> don't have any OrderItemType's on record for this non-product item. Is
> that my problem? Should I not be adding something to the shopping cart
> that doesn't have a link to an OrderItemType.
>
> Ruth
>  
> _______________________________________________
> Users mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/users
>


 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users
Reply | Threaded
Open this post in threaded view
|

Re: Users - Is this a typo/bug/or misuse?

Ruth Hoffman
Hi Jacopo:
I'm not going to be able to test w/7555 until early next week. I'll keep
you posted.
Thanks for your help.
Ruth

Jacopo Cappellato wrote:

>Hi Ruth,
>
>this should be fixed in svn rev. 7555
>
>Could you please make a few tests and let me know?
>
>Thanks
>
>Jacopo
>
>
>Ruth Hoffman wrote:
>  
>
>>${cartLine.getItemTypeDescription()?if_exists} maybe should be:
>>
>>${cartLine.getItemType()?if_exists} or ${cartLine.getName()?if_exists}
>>
>>This shows up in a few places - showcart.ftl, splitship.ftl,minicart.ftl
>>
>>When I view a cart after adding an item with no product id (a
>>non-product item) I get the following error. Here's the start of the
>>error...
>>
>>*Method public java.lang.String
>>org.ofbiz.order.shoppingcart.ShoppingCartItem.getItemTypeDescription()
>>threw an exception when invoked on
>>org.ofbiz.order.shoppingcart.ShoppingCartItem@e4281f The problematic
>>instruction: ---------- ==>
>>${cartLine.getItemTypeDescription()?if_exists} [on line 58, column 47 in
>>minicart.ftl] ---------- Java backtrace for programmers: ----------
>>freemarker.template.TemplateModelException: Method public*
>>
>>A quick look at ShoppingCartItem suggests that this method is going out
>>and looking for descriptions based on OrderItemTypes. In my case, I
>>don't have any OrderItemType's on record for this non-product item. Is
>>that my problem? Should I not be adding something to the shopping cart
>>that doesn't have a link to an OrderItemType.
>>
>>Ruth
>>
>>_______________________________________________
>>Users mailing list
>>[hidden email]
>>http://lists.ofbiz.org/mailman/listinfo/users
>>
>>    
>>
>
>
>
>_______________________________________________
>Users mailing list
>[hidden email]
>http://lists.ofbiz.org/mailman/listinfo/users
>
>  
>
 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users