[jira] Created: (OFBIZ-1097) Replacing FindBillingAccount.ftl by a Form

[Nicolas Malin (Jira)]

Replacing FindBillingAccount.ftl by a Form
------------------------------------------

                 Key: OFBIZ-1097
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Minor


There is no need to use FTL there since we can do the same using a Form.
Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1097:
----------------------------------------

    Attachment: FindBillingAccount-SVN.patch

Patches both applications/accounting/widget/BillingAccountForms.xml and applications/accounting/widget/BillingAccountScreens.xml

Once applied applications/accounting/webapp/accounting/billingaccount/FindBillingAccount.ftl can be removed.

Perhaps somebody can also get rid of the bsh by modifying the screen / form action accordingly.

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1097:
----------------------------------------

    Assignee: Jacopo Cappellato

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1097.
------------------------------------

    Resolution: Fixed

Jeremy,

thanks for your patch; however I've committed in rev. 550411 a different implementation (based on your initial work).
Have a look at it to see how you can do some nice stuff with widgets.
The main issue was that the screen can be reached from the link in party detail pages and, if that link is used, should only show the accounts (and role) of that party.

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507828 ]

Wickersheimer Jeremy commented on OFBIZ-1097:
---------------------------------------------

I checked how you did it with conditions.
But something seems wrong to me, Role and Party doesn't belong to BillingAccount but to BillingAccountRole, so if no party is specified it should not show those fields.

Also when partyId is given, the list returned by the bsh is: billingAccountRolesByParty and not billingAccounts. So i guess we need a different Form when partyId is given to display that list.

What do you think ?

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507831 ]

Jacopo Cappellato commented on OFBIZ-1097:
------------------------------------------

Jeremy,

they are good points but I think you have missed one of the changes I did (to the bsh script).
Have a look at it and see if this answers your questions.
Thanks

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507834 ]

Wickersheimer Jeremy commented on OFBIZ-1097:
---------------------------------------------

Indeed, but still: accounts = delegator.findAll("BillingAccount")
won't return any roleId or partyId, so they appear blank in the list
when no partyId is given.
It doesn't make sense to have those columns in that case.

So perhaps we could use two different forms. I will propose a patch in
a few minutes.

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy reopened OFBIZ-1097:
-----------------------------------------

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1097:
----------------------------------------

    Attachment: ofbiz-1097.patch

There is the new form, i think this is cleaner this way.

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507838 ]

Wickersheimer Jeremy commented on OFBIZ-1097:
---------------------------------------------

Last question for today, is there a way to get rid of the bsh ? is it possible to have conditions in the form actions ?
I am working on sorting by columns for the forms, so every BSH will be extra work for me to implement that feature.

Thanks for your time anyway :)

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507841 ]

Jacopo Cappellato commented on OFBIZ-1097:
------------------------------------------

Yes,

the syntax is:

<condition>
    <not><if-empty field-name="parameters.partyId"/></not>
</condition>
<actions>
... here you can select using the roles
</actions>
<widgets>
...
</widgets>
<fail-widgets>
...
</fail-widgets>

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1097:
----------------------------------------

    Attachment:     (was: ofbiz-1097.patch)

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1097:
----------------------------------------

    Attachment: ofbiz-1097b.patch

I removed the previous patch, this one makes the BSH obsolete.
The BSH is not used anymore in applications/accounting so you can remove it if you approve the patch.

I find the logic in the Screen a bit "twisted", at first i though there was a <fail-actions> that could be used, but it seems not... or if there is i didn't find how to use it.
Current logic would have both actions executed, which is "not pretty" but works.

If you think there is a better way to do that i would be glad to here it because i may need this trick on other screens.

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097b.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508063 ]

Jacopo Cappellato commented on OFBIZ-1097:
------------------------------------------

This should work:

...
<fail-widgets>
  <section>
    <actions></actions>
    <widgets></widgets>
  </section>
</fail-widgets>

Let me know!

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097b.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1097:
----------------------------------------

    Attachment:     (was: ofbiz-1097b.patch)

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1097:
----------------------------------------

    Attachment: ofbiz-1097c.patch

Yes, thanks !

Now the screen is much more "readable" i think.
Actually the structure make sense, i should have seen the session -> widgets -> session -> ...

I guess it is final this time.

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097c.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508122 ]

Wickersheimer Jeremy commented on OFBIZ-1097:
---------------------------------------------

If you can apply it, i have another patch for the BillingAccountInvoices to get rid of the BSH script and to add a separate form to display the BAInvoices.

I prefer not to use the Form from InvoiceForms because:
1. it conflicts with pagination
2. there may be a filter ( see OFBIZ-84 )
3. it will be easier to customize the form without side effects

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097c.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508736 ]

Jacopo Cappellato commented on OFBIZ-1097:
------------------------------------------

About the new form for invoices: it makes sense to create a separate form; you may also consider to create the new form as an extension of the original one; for this see the tags extends-resource and extends

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097c.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1097.
------------------------------------

    Resolution: Fixed

Thanks Jeremy, your patch is in rev. 551460

> Replacing FindBillingAccount.ftl by a Form
> ------------------------------------------
>
>                 Key: OFBIZ-1097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: FindBillingAccount-SVN.patch, ofbiz-1097c.patch
>
>
> There is no need to use FTL there since we can do the same using a Form.
> Patch is coming next.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.