OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

_‹ Previous Topic Next Topic _›

Classic

List

7 messages Options

Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

Two build files of specialpurpose applications has still 1.4 has source tag
---------------------------------------------------------------------------

Key: OFBIZ-1184
URL: https://issues.apache.org/jira/browse/OFBIZ-1184
Project: OFBiz
Issue Type: Improvement
Affects Versions: SVN trunk
Environment: mac os
Reporter: Marco Risaliti
Priority: Trivial
Fix For: SVN trunk

There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
Is this something correct ?
If someone want to correct it this is the trivial patch to solve it.

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1184:
----------------------------------

Attachment: build_1_5.patch

This is the patch

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1184.
----------------------------------

Resolution: Fixed
Assignee: Jacques Le Roux

Hi Marco,

I suppose that this was copied and nobody did care since then. If I'm wrong simply revert this changes, thanks.

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1184.
----------------------------------

Resolution: Fixed
Assignee: Jacques Le Roux

Strange : this was supposed to be closed at 16h51 today : (anyway close again...)

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1184.
----------------------------------

Resolution: Fixed
Assignee: Jacques Le Roux

Hi Marco,

I suppose that this was copied and nobody did care since then. If I'm wrong simply revert this changes, thanks.

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517859 ]

Bilgin Ibryam commented on OFBIZ-1184:
--------------------------------------

Just a question: What about this line Start.java:56 private static final double REQUIRED_JDK = 1.4;
Should we change it also to 1.5 ?

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517883 ]

Jacques Le Roux commented on OFBIZ-1184:
----------------------------------------

I changed it to 1.5 but actually it"s not needed as before we get

Exception in thread "main" java.lang.UnsupportedClassVersionError: org/ofbiz/base/start/Start (Unsupported major.minor version 49.0)
at java.lang.ClassLoader.defineClass0(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:539)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:251)
at java.net.URLClassLoader.access$100(URLClassLoader.java:55)
at java.net.URLClassLoader$1.run(URLClassLoader.java:194)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:187)
at java.lang.ClassLoader.loadClass(ClassLoader.java:289)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:274)
at java.lang.ClassLoader.loadClass(ClassLoader.java:235)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:302)

So I wonder if we should kept this in code. Any opinions among commiters ?

Commited in trunk rev. 563105, release4.0 563106

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1184) Two build files of specialpurpose applications has still 1.4 has source tag

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517900 ]

Jacques Le Roux commented on OFBIZ-1184:
----------------------------------------

Reverted release4.0 in revision: 563115 from a comment of Christian Geisert in dev. ML (was a bit sleepy. Only truynk was needed as it's obvious in the issue requirement, sorry)

> Two build files of specialpurpose applications has still 1.4 has source tag
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-1184
> URL: https://issues.apache.org/jira/browse/OFBIZ-1184
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Environment: mac os
> Reporter: Marco Risaliti
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: build_1_5.patch
>
>
> There are still two build files of specialpurpose applications that they have still 1.4 in source tag into the build.xml.
> Is this something correct ?
> If someone want to correct it this is the trivial patch to solve it.
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.