[
https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530473 ]
Adrian Crum commented on OFBIZ-1258:
------------------------------------
David,
Thank you for taking the time to work on this. The code changes resulted from me trying to get the code back to its original working state.
I understand what you're saying about a proliferation of methods, but at the same time this is a "Worker" class that would be expected to accomodate more than one scenario. Before the recent changes, calling classes had several template rendering options: render a template with only a template location, render a template with a String object that contains the template, and render a template with an existing template reader.
In rev 573442 you changed the code to address the template reader object not being closed issue. At the same time it appeared you tried to eliminate "a bunch of methods that aren't really needed" - which broke peripheral code. Those methods were needed. Al attempted to fix the broken code in rev 576766.
My approach to this situation was to go back to rev 564957 and apply only your changes that fixed the reader not being closed issue. I didn't eliminate any existing methods. That's why it appears I made unnecessary changes.
As long as the problem is fixed, I don't care. My preference is to avoid redundant code, but as long as it works, that's all that matters.
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL:
https://issues.apache.org/jira/browse/OFBIZ-1258> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
