[jira] Created: (OFBIZ-1349) Add notes regarding ofbiz-component.xml <base-permission> element usage

[Nicolas Malin (Jira)]

Add notes regarding ofbiz-component.xml <base-permission> element usage
-----------------------------------------------------------------------

                 Key: OFBIZ-1349
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1349
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Adrian Crum
            Priority: Trivial
         Attachments: base_permission.patch

The ofbiz-component.xml <base-permission> element contains a list. It's not clear if the permissions in that list are ANDed or ORed to grant permission to use the application. It would be helpful to have some notes on the correct usage.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1349:
-------------------------------

    Attachment: base_permission.patch

Attached patch contains the notes.

> Add notes regarding ofbiz-component.xml <base-permission> element usage
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1349
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1349
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Trivial
>         Attachments: base_permission.patch
>
>
> The ofbiz-component.xml <base-permission> element contains a list. It's not clear if the permissions in that list are ANDed or ORed to grant permission to use the application. It would be helpful to have some notes on the correct usage.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1349:
-------------------------------

    Attachment: base_permission.patch

Okay, now I feel stupid. The original appbar.ftl DID check for the ADMIN permission via OFBizSecurity.hasEntityPermission(...). Why it didn't work for me originally, I don't know.

The attached patch reverts appbar.ftl and adds the comments.

My apologies to the committers.

> Add notes regarding ofbiz-component.xml <base-permission> element usage
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1349
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1349
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Trivial
>         Attachments: base_permission.patch, base_permission.patch
>
>
> The ofbiz-component.xml <base-permission> element contains a list. It's not clear if the permissions in that list are ANDed or ORed to grant permission to use the application. It would be helpful to have some notes on the correct usage.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1349:
----------------------------------------

    Assignee: Jacopo Cappellato

> Add notes regarding ofbiz-component.xml <base-permission> element usage
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1349
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1349
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: base_permission.patch, base_permission.patch
>
>
> The ofbiz-component.xml <base-permission> element contains a list. It's not clear if the permissions in that list are ANDed or ORed to grant permission to use the application. It would be helpful to have some notes on the correct usage.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1349.
------------------------------------

    Resolution: Fixed

Thank you Adrian,

your patch is in rev. 585879

> Add notes regarding ofbiz-component.xml <base-permission> element usage
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1349
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1349
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>         Attachments: base_permission.patch, base_permission.patch
>
>
> The ofbiz-component.xml <base-permission> element contains a list. It's not clear if the permissions in that list are ANDed or ORed to grant permission to use the application. It would be helpful to have some notes on the correct usage.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.