[jira] Created: (OFBIZ-854) implementing rtl in project

[Nicolas Malin (Jira)]

implementing rtl in project
---------------------------

                 Key: OFBIZ-854
                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Majid Kalkatechi


As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485082 ]

Majid Kalkatechi commented on OFBIZ-854:
----------------------------------------

I copied the last comment of mine from OFBIZ-852 issue, and I think it's a good place to start:
The problem of parentheses, make sense when we use "Latin alphabet" in rtl direction, Arabic alphabet ,as I tested, didn't have any problem,even in 'order list' screen.
Now, I'm thinking how we can change direction automatically in page, my best idea is to put it in properties file, so it became part of internationalization system.
But as we can see, some elements of a page always have "Latin alphabet" (like language select box), this elements have to keep thier ltr direction, even in rtl contexts.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485092 ]

Chris Howe commented on OFBIZ-854:
----------------------------------

A couple of resources
http://www.w3.org/International/technique-index
http://www.w3.org/TR/i18n-html-tech-lang/

Due to practicality,I can only imagine that most of the real world demonstrations of a good solution will not be described in English, which compounds the issue further.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485223 ]

Adrian Crum commented on OFBIZ-854:
-----------------------------------

I suggested a method of enabling rtl direction in the dev mailing list. Subject was "RFC - Language Translation Idea" - if no one objects to it, I can create a patch that implements my suggestion and that can get things started.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-854:
------------------------------

    Attachment: header_ftl.patch

Attached patch follows w3.org guidelines for bidi markup.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-854:
------------------------------

    Attachment: header_ftl.patch

Improved patch - eliminates embedded ltr markup.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-854:
------------------------------

    Attachment: rtl_poc.patch

rtl proof of concept patch. This patch is NOT intended to be part of the project.

Concept:

1. header.ftl sets the reading direction of each page based upon the Locale object's language.
2. A rtl stylesheet is created that cascades maincss.css and reverses the direction of its styles. Only a handful of styles are included in this patch - a project-worthy version would have to include all maincss.css styles.
3. A property (CommonReadingDirection) is added to all rtl translations of CommonUiLabels.properties. This property is set to rtl.
4. The Global Decorator checks to see if the CommonReadingDirection property is set to rtl. If it is, then it loads the rtl style sheet.

I don't know how to conditionally execute an action in a screen widget, so this patch requires a line to be uncommented to try it out. Look for the  "<!-- Uncomment the following line for rtl layout -->" comment in the Global Decorator.

That's the general process I propose. Comments are welcome.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch, rtl_poc.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489167 ]

Adrian Crum commented on OFBIZ-854:
-----------------------------------

The main project header.ftl has been updated to support bidi layout, revision 528925.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch, rtl_poc.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490505 ]

Jacopo Cappellato commented on OFBIZ-854:
-----------------------------------------

can we close this issue now?

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch, rtl_poc.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490626 ]

Adrian Crum commented on OFBIZ-854:
-----------------------------------

Jacopo,

This issue still has more steps to complete. They are:

1. Modify the Global Decorator so that an optional rtl style sheet is loaded depending upon the currently selected locale (using a test like the one found in the main header.ftl file).

2. Create a cascading rtl style sheet.

3. Remove embedded ltr HTML markup from the project.

Step 3 is being accomplished through the UI refactor. I don't know how to implement step 1 because I'm not skilled enough in screen widget XML files. I can do step 2 after the maincss.css file has settled down a bit. I'd like to create a rtl style sheet after some of the deprecated styles have been actually removed from the main style sheet.

All in all, we're very close to having a rtl compatible project.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch, rtl_poc.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535429 ]

Jacopo Cappellato commented on OFBIZ-854:
-----------------------------------------

What is the status of this issue now?

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch, rtl_poc.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-854.
-----------------------------

    Resolution: Fixed

Jacopo,

I'm closing this issue because it's basically finished. All of the building blocks are there to implement rtl in OFBiz. The only thing left to do is remove embedded ltr styling from the markup - a huge task.

The rtl users can submit separate Jira issues for removing ltr markup or to improve the rtl support.

> implementing rtl in project
> ---------------------------
>
>                 Key: OFBIZ-854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-854
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Majid Kalkatechi
>         Attachments: header_ftl.patch, header_ftl.patch, rtl_poc.patch
>
>
> As a result of 'OFBIZ-852' issue, to use ofbiz in some languages (farsi, arabic ...) that the direction of sentences is right-to-left, the first thing is to make the page direction changed, this change of direction is based on the locale of system, and also there is some elements that need to be left-to-right even in rtl languages. So, there must be an approach to tackle this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.