[jira] Created: (OFBIZ-1373) Incorrect Available Balance Display due to i18n

[Nicolas Malin (Jira)]

Incorrect Available Balance Display due to i18n
-----------------------------------------------

                 Key: OFBIZ-1373
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1373
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Guido Amarilla
            Priority: Minor
         Attachments: BillingAccountForms.patch

When displaying the Available Balance in EditBillingAccount screen an incorrect (100 times greater) value is displayed. This only occurs in languages with a comma as decimal separator (eg Spanish). This is caused by an incorrect rendering of BigDecimal numbers.
The solution is the same that the one adopted to show other currencies in the same component.
See patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guido Amarilla updated OFBIZ-1373:
----------------------------------

    Attachment: BillingAccountForms.patch

This patch solved this issue in a test case.

> Incorrect Available Balance Display due to i18n
> -----------------------------------------------
>
>                 Key: OFBIZ-1373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1373
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Priority: Minor
>         Attachments: BillingAccountForms.patch
>
>
> When displaying the Available Balance in EditBillingAccount screen an incorrect (100 times greater) value is displayed. This only occurs in languages with a comma as decimal separator (eg Spanish). This is caused by an incorrect rendering of BigDecimal numbers.
> The solution is the same that the one adopted to show other currencies in the same component.
> See patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1373:
----------------------------------------

    Assignee: Jacopo Cappellato

> Incorrect Available Balance Display due to i18n
> -----------------------------------------------
>
>                 Key: OFBIZ-1373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1373
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: BillingAccountForms.patch
>
>
> When displaying the Available Balance in EditBillingAccount screen an incorrect (100 times greater) value is displayed. This only occurs in languages with a comma as decimal separator (eg Spanish). This is caused by an incorrect rendering of BigDecimal numbers.
> The solution is the same that the one adopted to show other currencies in the same component.
> See patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1373.
------------------------------------

    Resolution: Fixed

Thanks Guido,

your patch is in rev. 589978

To all: this is really a workaround but we should probably improve the widget code to better handle numeric fields.

> Incorrect Available Balance Display due to i18n
> -----------------------------------------------
>
>                 Key: OFBIZ-1373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1373
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: BillingAccountForms.patch
>
>
> When displaying the Available Balance in EditBillingAccount screen an incorrect (100 times greater) value is displayed. This only occurs in languages with a comma as decimal separator (eg Spanish). This is caused by an incorrect rendering of BigDecimal numbers.
> The solution is the same that the one adopted to show other currencies in the same component.
> See patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538693 ]

David E. Jones commented on OFBIZ-1373:
---------------------------------------

I agree this should be fixed soon in the form widget... that much code to kludge this out is a pretty big red flag.

> Incorrect Available Balance Display due to i18n
> -----------------------------------------------
>
>                 Key: OFBIZ-1373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1373
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: BillingAccountForms.patch
>
>
> When displaying the Available Balance in EditBillingAccount screen an incorrect (100 times greater) value is displayed. This only occurs in languages with a comma as decimal separator (eg Spanish). This is caused by an incorrect rendering of BigDecimal numbers.
> The solution is the same that the one adopted to show other currencies in the same component.
> See patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538706 ]

Jacopo Cappellato commented on OFBIZ-1373:
------------------------------------------

David, Guido, all,

in rev. 589991 I've committed a better solution to the issue.
The trick to remember is this: if in a display element you want to use the type="currency" attribute then the "description" attribute shouldn't be set (because it is already a string) and instead the numeric object must be available in the context.

> Incorrect Available Balance Display due to i18n
> -----------------------------------------------
>
>                 Key: OFBIZ-1373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1373
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: BillingAccountForms.patch
>
>
> When displaying the Available Balance in EditBillingAccount screen an incorrect (100 times greater) value is displayed. This only occurs in languages with a comma as decimal separator (eg Spanish). This is caused by an incorrect rendering of BigDecimal numbers.
> The solution is the same that the one adopted to show other currencies in the same component.
> See patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.