[jira] Created: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
---------------------------------------------------------------------------------------

                 Key: OFBIZ-1374
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
             Project: OFBiz
          Issue Type: Bug
          Components: ecommerce
    Affects Versions: SVN trunk
         Environment: Hotwaxmedia demo server
            Reporter: Raj Saini
         Attachments: quickAnonProcessCustomerSettings.htm

When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0

On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raj Saini updated OFBIZ-1374:
-----------------------------

    Attachment: quickAnonProcessCustomerSettings.htm

HTML source code containing duplicate html tags

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539285 ]

Jonathon Wong commented on OFBIZ-1374:
--------------------------------------

Does it have anything to do with the message "permission denied to call method XMLhttprequest.open"?

Go to applications/ecommerce/webapp/ecommerce/order/quickAnonPaymentInformation.ftl. In javascript function "getPaymentInformation", replace "<@ofbizUrl>quickAnonEnterExtOffline</@ofbizUrl>" with "/ecommerce/control/quickAnonEnterExtOffline" (which stops OFBiz from generating "http://localhost:8080/ecommerce/control/quickAnonEnterExtOffline..."). Clicking on "Submit Order" should go through now.

However, there seems to be other permissions problems after that.

The reproduce bug, order something as an anonymous shopper, do a "Quick Checkout" (Checkout Without Login), select "Ext_Offline" payment method, select any shipping method, then click "Submit Order".

I'm looking at OFBiz 4.0, rev 589272.

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539287 ]

Jonathon Wong commented on OFBIZ-1374:
--------------------------------------

Ah, a typo error in applications/ecommerce/webapp/ecommerce/WEB-INF/conroller.xml .

Change "quickAnonenterExtOffline" to "quickAnonEnterExtOffline".

From trunk and 4.0 r490651. Error was there when "quickAnonenterExtOffline" was first introduced.

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1374:
----------------------------------------

    Assignee: Jacopo Cappellato

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1374.
------------------------------------

    Resolution: Fixed

Thanks Jonathon, I've applied your fix both to the release and trunk.


> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

rajsaini
Jacopo,

I do not see this working for Credit Card payment. When credit card is
selected as payment mode, clicking on submit button does not do
anything. I think you fixed what Jonathan reported for offline payment.

Should I reopen the issue?

Thanks,

Raj

Jacopo Cappellato (JIRA) wrote:

>      [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jacopo Cappellato closed OFBIZ-1374.
> ------------------------------------
>
>     Resolution: Fixed
>
> Thanks Jonathon, I've applied your fix both to the release and trunk.
>
>
>  
>> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
>> ---------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-1374
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>>             Project: OFBiz
>>          Issue Type: Bug
>>          Components: ecommerce
>>    Affects Versions: SVN trunk
>>         Environment: Hotwaxmedia demo server
>>            Reporter: Raj Saini
>>            Assignee: Jacopo Cappellato
>>         Attachments: quickAnonProcessCustomerSettings.htm
>>
>>
>> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
>> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.
>>    
>
>  

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reopened OFBIZ-1374:
--------------------------------------


Message from the mailing list by Raj Saini:
=====================
I do not see this working for Credit Card payment. When credit card is selected as payment mode, clicking on submit button does not do anything. I think you fixed what Jonathan reported for offline payment.
=====================

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Jacopo Cappellato
In reply to this post by rajsaini
Yes,

sorry, Raj; I've reopened the issue.

Jacopo

Raj Saini wrote:

> Jacopo,
>
> I do not see this working for Credit Card payment. When credit card is
> selected as payment mode, clicking on submit button does not do
> anything. I think you fixed what Jonathan reported for offline payment.
>
> Should I reopen the issue?
>
> Thanks,
>
> Raj
>
> Jacopo Cappellato (JIRA) wrote:
>>      [
>> https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>> ]
>>
>> Jacopo Cappellato closed OFBIZ-1374.
>> ------------------------------------
>>
>>     Resolution: Fixed
>>
>> Thanks Jonathon, I've applied your fix both to the release and trunk.
>>
>>
>>  
>>> Anonymous quick check is broken, nothing happen when click on the
>>> "Submit Order" button
>>> ---------------------------------------------------------------------------------------
>>>
>>>
>>>                 Key: OFBIZ-1374
>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>>>             Project: OFBiz
>>>          Issue Type: Bug
>>>          Components: ecommerce
>>>    Affects Versions: SVN trunk
>>>         Environment: Hotwaxmedia demo server
>>>            Reporter: Raj Saini
>>>            Assignee: Jacopo Cappellato
>>>         Attachments: quickAnonProcessCustomerSettings.htm
>>>
>>>
>>> When click on the "Submit Button" on second page of Anonymous
>>> checkout, form is not submitted. It seems this bug is introduced
>>> after adding the creditCardFields screen in CommonScreen.xml of
>>> accounting module. It seems to be working well in Branch 4.0
>>> On further analysis, I found that html tag is included twice in the
>>> generated html. Please look at the attached html file for duplicate
>>> html tag.
>>>    
>>
>>  

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539530 ]

Jonathon Wong commented on OFBIZ-1374:
--------------------------------------

Raj is right about there being redundant <html> tags. This shouldn't be allowed to happen.

Looking in ecommerce module, widget/OrderScreens.xml , I see widget screen "quickAnonCheckoutLinks" used (via decorator "quickAnonCheckoutDecorator") in 2 screens: "quickAnonCustSettings" and "quickAnonOrderReview". Both screens do not require "quickAnonCheckoutLinks" to output <html> tags. This is obviously wrong. We should remove the <html> tags (leaving just the javascript tag and the <div> tag) in quickAnonCheckoutLinks.ftl .

As for the bug that Raj spotted, it could be due to another typo error. Line 54 in quickAnonPaymentInformation.ftl, change "paymentMethodId" to "paymentMethodTypeId".

Haven't test this. As just theory. Try it out? Thanks.

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539546 ]

Jacopo Cappellato commented on OFBIZ-1374:
------------------------------------------

Jonathon,

I think you are right: I've applied the fix you have suggested.
Raj, can you please test now?

Thanks.


> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

rajsaini
Jacopo,

Thanks Jacopo, thanks Jonathon. I tested this and it is working now.

Raj


Jacopo Cappellato (JIRA) wrote:

>     [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539546 ]
>
> Jacopo Cappellato commented on OFBIZ-1374:
> ------------------------------------------
>
> Jonathon,
>
> I think you are right: I've applied the fix you have suggested.
> Raj, can you please test now?
>
> Thanks.
>
>
>  
>> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
>> ---------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-1374
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>>             Project: OFBiz
>>          Issue Type: Bug
>>          Components: ecommerce
>>    Affects Versions: SVN trunk
>>         Environment: Hotwaxmedia demo server
>>            Reporter: Raj Saini
>>            Assignee: Jacopo Cappellato
>>         Attachments: quickAnonProcessCustomerSettings.htm
>>
>>
>> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
>> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.
>>    
>
>  

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1374.
------------------------------------

    Resolution: Fixed

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1374) Anonymous quick check is broken, nothing happen when click on the "Submit Order" button

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663441#action_12663441 ]

chris commented on OFBIZ-1374:
------------------------------

I'm tried all suggestions and bug still alive. I commented out following code and submit worked: dojo.addOnLoad(init); This line is in quickAnonPaymentInformation.ftl and quickAnonOptionSettings.ftl. So problem seems to be with dojo and IE7. The function processOrder() in quickAnonCheckoutReview.ftl never fires. The other functions that are registered with dojo.addOnLoad()  do fire. Of course, with dojo.addOnLoad commented out, the payment choices are not rendered. My research I found this bug report "http://dojotoolkit.org/forum/dojo-core-dojo-0-9/dojo-core-support/dojo-addonload-bug-ie7". Any suggestions for a temporary workaround I can use?

> Anonymous quick check is broken, nothing happen when click on the "Submit Order" button
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1374
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: Hotwaxmedia demo server
>            Reporter: Raj Saini
>            Assignee: Jacopo Cappellato
>         Attachments: quickAnonProcessCustomerSettings.htm
>
>
> When click on the "Submit Button" on second page of Anonymous checkout, form is not submitted. It seems this bug is introduced after adding the creditCardFields screen in CommonScreen.xml of accounting module. It seems to be working well in Branch 4.0
> On further analysis, I found that html tag is included twice in the generated html. Please look at the attached html file for duplicate html tag.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.