[jira] Created: (OFBIZ-1389) Add support for <description> element in entity model classes

[Nicolas Malin (Jira)]

Add support for <description> element in entity model classes
-------------------------------------------------------------

                 Key: OFBIZ-1389
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: entity_model.patch

Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1389:
-------------------------------

    Attachment: entity_model.patch

Attached patch adds support for the <description> element to the ModelRelation and ModelIndex classes.

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541137 ]

Adam Heath commented on OFBIZ-1389:
-----------------------------------

It'd be better to place this description stuff into ModelChild, which all of ModelField, ModelIndex, and ModelRelation extend.

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1389:
-------------------------------

    Attachment: entity_model.patch

Improved patch - now with inheritance goodness.

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entity_model.patch, entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1389:
-------------------------------

    Attachment: entity_model.patch

More betterful patch - ModelEntity now has get/set location of entity definition.

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entity_model.patch, entity_model.patch, entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1389:
-------------------------------

    Attachment: entity_model.patch

Improved patch - view entities were losing field descriptions.

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entity_model.patch, entity_model.patch, entity_model.patch, entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544039 ]

Adrian Crum commented on OFBIZ-1389:
------------------------------------

Bump.

If we could get this committed, it will help with the entity documentation effort.

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entity_model.patch, entity_model.patch, entity_model.patch, entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1389:
----------------------------------------

    Assignee: Jacopo Cappellato

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: entity_model.patch, entity_model.patch, entity_model.patch, entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1389.
------------------------------------

    Resolution: Fixed

Thanks Adrian, your patch is in rev. 596815

> Add support for <description> element in entity model classes
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1389
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: entity_model.patch, entity_model.patch, entity_model.patch, entity_model.patch
>
>
> Some of the entity model classes do not support the <description> element, even though it is specified in the DTD.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.