[jira] Created: (OFBIZ-1401) Improve FOP screen renderer

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
Improve FOP screen renderer
---------------------------

                 Key: OFBIZ-1401
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Adrian Crum
            Priority: Minor


The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1401:
-------------------------------

    Attachment: webtools_fop.patch

webtools_fop.patch contains a re-written FOP screen renderer and changes to the Webtools component to enable outputting the entity reference chart to a PDF file.

Committers: DO NOT commit this patch - it is here for evaluation only. I still have more work to do on it.


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1401:
-------------------------------

    Attachment: entityRefReport.zip

The attached zip file contains:

entityRefReport.xml (16MB) - the xsl-fo file
entityRefReport.pdf (3MB) - the pdf result


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542583 ]

Adrian Crum commented on OFBIZ-1401:
------------------------------------

Problem description: converting a large xsl-fo file using the embedded FOP takes forever to run, sometimes it doesn't finish at all. The entity reference report feature I'm trying to add to the Webtools component ran for an hour, then I finally gave up and shut it down. Running the same xsl-fo file through the command-line version of FOP takes about 15 seconds and produces a perfect PDF file.

I tried increasing available memory . I tried using temp files instead of rendering to a String. I used the same class methods as the command-line version. All of those changes are in the patch. I also tried to run a profiler, but I couldn't get it to work.

I give up. I've spent two days trying to get this fixed and I'm at a complete loss. If someone can figure out how to get it to run faster, please post a patch here and I will resume my work.


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543137 ]

Christian Geisert commented on OFBIZ-1401:
------------------------------------------

Ok, I had a first look at the issue.

The patch applied with small problems (Stripping trailing CRs from patch, FAILED at startofbiz.bat)
A first run produced a java.lang.NoClassDefFoundError: org/apache/xml/utils/URI$MalformedURIException (this a issue with the 0.94 release which has been fixed)

Then I tried it with the latest FOP from trunk and it seems the PDF generation is very slow from the beginning - doesn't look like a memory problem.

Now that I think about it I remember that I noticed sometime ago  that the PDF generation in trunk was way slower than in the release branch - Adrian, have you tried it with the release branch yet? (I will do it later)




> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543185 ]

Adrian Crum commented on OFBIZ-1401:
------------------------------------

Christian,

Thank you for taking a look at this! No, I haven't tried it with the release branch.  After taking a day off from it, I decided to give it another go. I'm tracing through the FOP source code now. It would help if someone experienced with a profiler could take a look at it to see where the bottleneck is.


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Geisert updated OFBIZ-1401:
-------------------------------------

    Attachment: patch-ofbiz-entityrefpdf-branch.diff

I've applied the patch (with quick & dirty modifications) to the release branch and the pdf is generated there without problems.
(Patch attached for testing purposes)

The big question is why?
I don't think this is a FOP problem, maybe a issue with the transaction manager.


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, patch-ofbiz-entityrefpdf-branch.diff, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544043 ]

Adrian Crum commented on OFBIZ-1401:
------------------------------------

Christian,

Thank you very much for the patch! I applied it to R4 and you're right - FOP rendering runs much faster on R4, so something has changed to slow things down.

I created a diff between the trunk and the R4 branch with the hope that I could spot the difference - but it contained thousands of changes. Ack.

I don't know what our next step is. I hope someone monitoring this issue will supply a hint. Or, like I said before, someone experienced with profilers could see where things are getting bogged down. I noticed on my PC the FOP rendering drove CPU utilization up to 50% - so it's working really hard doing something.


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, patch-ofbiz-entityrefpdf-branch.diff, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1401) Improve FOP screen renderer

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1401.
------------------------------

    Resolution: Fixed

Fixed - rev 603107.


> Improve FOP screen renderer
> ---------------------------
>
>                 Key: OFBIZ-1401
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1401
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: entityRefReport.zip, patch-ofbiz-entityrefpdf-branch.diff, webtools_fop.patch
>
>
> The FOP screen renderer bogs down on large xsl-fo files. Work needs to be done to find a way to speed it up. This issue is intended for collaborative research and discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.