[jira] Created: (OFBIZ-1548) [patch] rateProductTaxCalc expecting a value for orderShippingAmount but marked optional in servicedef

[Nicolas Malin (Jira)]

[patch] rateProductTaxCalc expecting a value for orderShippingAmount but marked optional in servicedef
------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1548
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1548
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Trivial
             Fix For: SVN trunk


The service calcTax is declared as implemeting the calcTaxInterface but the orderShippingAmount which is declared optional is expecting to have a Double value in the java method.
I came accross this small bug while writing unit tests, an easy fix is to also test the value to be not null instead of just checking  orderShippingAmount.doubleValue() > 0

Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1548:
----------------------------------------

    Attachment: 1548.patch

> [patch] rateProductTaxCalc expecting a value for orderShippingAmount but marked optional in servicedef
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1548
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1548
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: 1548.patch
>
>
> The service calcTax is declared as implemeting the calcTaxInterface but the orderShippingAmount which is declared optional is expecting to have a Double value in the java method.
> I came accross this small bug while writing unit tests, an easy fix is to also test the value to be not null instead of just checking  orderShippingAmount.doubleValue() > 0
> Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-1548:
---------------------------------

    Assignee: Scott Gray

> [patch] rateProductTaxCalc expecting a value for orderShippingAmount but marked optional in servicedef
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1548
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1548
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: 1548.patch
>
>
> The service calcTax is declared as implemeting the calcTaxInterface but the orderShippingAmount which is declared optional is expecting to have a Double value in the java method.
> I came accross this small bug while writing unit tests, an easy fix is to also test the value to be not null instead of just checking  orderShippingAmount.doubleValue() > 0
> Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-1548.
-----------------------------

    Resolution: Fixed

Thanks Jérémy, committed in rev. 607359

> [patch] rateProductTaxCalc expecting a value for orderShippingAmount but marked optional in servicedef
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1548
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1548
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Scott Gray
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: 1548.patch
>
>
> The service calcTax is declared as implemeting the calcTaxInterface but the orderShippingAmount which is declared optional is expecting to have a Double value in the java method.
> I came accross this small bug while writing unit tests, an easy fix is to also test the value to be not null instead of just checking  orderShippingAmount.doubleValue() > 0
> Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.