[jira] Created: (OFBIZ-1773) Store Order Item changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
Store Order Item changes
------------------------

                 Key: OFBIZ-1773
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
             Project: OFBiz
          Issue Type: New Feature
          Components: order
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
            Assignee: Bilgin Ibryam
            Priority: Minor
             Fix For: SVN trunk


Hi all,

the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html

I followed Jacopo's  suggestions and attached a patch.
All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
Also this entity could store the reason and comments about Order Item update or cancel.

Reviews and feedback are welcome.
Thanks,
Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1773:
---------------------------------

    Attachment: orderItemChange.patch

> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595521#action_12595521 ]

Jacques Le Roux commented on OFBIZ-1773:
----------------------------------------

Looks good, +1 for changes history



> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595538#action_12595538 ]

Jacques Le Roux commented on OFBIZ-1773:
----------------------------------------

Actually I did not answer yesterday because I tried to see if some other changes history could be interesting. But during my tests I encountered some problems.

If you want to add an item in an existing order created online by a customer in eCommerce (I think this makes sense as a customer could ask by phone to add after she/he has made her/his order online), you get this error if you have a configured product in the order

2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [   ShoppingCartItem.java:535:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ShoppingCartServices.java:376:ERROR]
---- exception report ----------------------------------------------------------
Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
---- stack trace ---------------------------------------------------------------
org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:536)
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:345)
org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:593)
[...]

I think I will create a new Jira issue for this but I'd like to be sure I'm not missing something before, any ideas ?

I tried also w/o a configurable product. Trying to add in a new shipment group I got (same shipment group was ok, no shipping method has the same problem)

2008-05-09 11:41:40,765 (http-0.0.0.0-18443-Processor4) [  ServiceDispatcher.java:522:ERROR] Error in Service [appendOrderItem]: Please Select Your Shipping Method.
2008-05-09 11:41:40,765 (http-0.0.0.0-18443-Processor4) [    TransactionUtil.java:275:ERROR]
---- exception report ----------------------------------------------------------
[TransactionUtil.rollback]
Exception: java.lang.Exception
Message: Stack Trace
---- stack trace ---------------------------------------------------------------
java.lang.Exception: Stack Trace
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:274)
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:256)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:526)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:334)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:454)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:281)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:198)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:78)
[...]

Same question : should I open an issue an begin to work on it or am I missing something ?

I also tried to use a split shipment from eCommerce. It worked well but when I tried to add in a new shipment group I got

2008-05-09 12:35:13,015 (http-0.0.0.0-18443-Processor3) [  ServiceDispatcher.java:500:ERROR]
---- exception report ----------------------------------------------------------
Service [appendOrderItem] threw an unexpected exception/error
Exception: org.ofbiz.service.GenericServiceException
Message: Service target threw an unexpected exception (index: 2)
---- stack trace ---------------------------------------------------------------
org.ofbiz.service.GenericServiceException: Service target threw an unexpected exception (index: 2)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:108)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:54)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:334)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:454)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:281)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:198)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:78)

Same question : should I open an issue an begin to work on it or am I missing something ?

There was also something about payment I crossed but I don't remember and can't find it in the logs.

> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595543#action_12595543 ]

Jacques Le Roux commented on OFBIZ-1773:
----------------------------------------

OK, I found the payment error : simply try to add a product in a new shipment group in the demo order
https://demo.hotwaxmedia.com/ordermgr/control/appendItemToOrder?orderId=DEMO10090

You get this error

    Problem calling releaseOrderPaymentPreference service for orderPaymentPreferenceId9000

and this stack

2008-05-09 12:47:08,937 (http-0.0.0.0-18443-Processor2) [  ServiceDispatcher.java:500:ERROR]
---- exception report ----------------------------------------------------------
Service [releaseOrderPaymentPreference] threw an unexpected exception/error
Exception: org.ofbiz.service.GenericServiceException
Message: Service target threw an unexpected exception (null)
---- stack trace ---------------------------------------------------------------
org.ofbiz.service.GenericServiceException: Service target threw an unexpected exception (null)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:108)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:54)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
org.ofbiz.accounting.payment.PaymentGatewayServices.releaseOrderPayments(PaymentGatewayServices.java:717)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:96)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:54)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
org.ofbiz.order.order.OrderServices.loadCartForUpdate(OrderServices.java:3440)
org.ofbiz.order.order.OrderServices.addItemToApprovedOrder(OrderServices.java:3115)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:96)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:54)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:334)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:454)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:281)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:198)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:78)
[...]

> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595544#action_12595544 ]

Jacques Le Roux commented on OFBIZ-1773:
----------------------------------------

Sorry to hack your issue Bilgin, my intention is to keep readable traces (in ML you can't read easily stack)

> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595556#action_12595556 ]

Bilgin Ibryam commented on OFBIZ-1773:
--------------------------------------

Jacques, if you create separate issues for the erros (icluding the logs) I can take a look them.
Thanks for your vote.

Any other opinions about the patch?

> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1773) Store Order Item changes

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1773.
--------------------------------

    Resolution: Fixed

More comments for this issue in the dev list can be found here http://www.nabble.com/new-OrderItemChange-entity-to17160956.html#a17184060
Replaced OrderItemChangeType with Enumeration and committed in rev. 655452

> Store Order Item changes
> ------------------------
>
>                 Key: OFBIZ-1773
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1773
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemChange.patch
>
>
> Hi all,
> the discussion about the issue is here http://www.nabble.com/Where-to-store-the-reason-for-canceling-some-quantity-of-Order-Item-to17101121.html
> I followed Jacopo's  suggestions and attached a patch.
> All changes to OrderItem entity fields: itemDescription, quantity, unitPrice, cancelQuantity are store to OrderItemChange entity.
> Also this entity could store the reason and comments about Order Item update or cancel.
> Reviews and feedback are welcome.
> Thanks,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.