[jira] Created: (OFBIZ-1780) Clean up labels between order and ecommerce application
Locked
12345
... 7
12345
... 7
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597809#action_12597809 ] Marco Risaliti commented on OFBIZ-1780: --------------------------------------- WARNING !!! Please remember that if someone of you has a custom application that extends order and ecommerce application has to replace the following labels with the new ones. EcommercePromotionsApplied --> OrderPromotionsApplied EcommerceQuickAdd --> OrderQuickAdd EcommerceRanking --> OrderRanking EcommerceRatings --> OrderRatings EcommerceSave --> OrderSave EcommerceShoppingCart --> OrderShoppingCart EcommerceShoppingCartEmpty --> OrderShoppingCartEmpty EcommerceSpecialOffers --> OrderSpecialOffers EcommerceToAddSelectedItemsToShoppingList --> OrderToAddSelectedItemsToShoppingList EcommerceToCart --> OrderToCart EcommerceTotal --> OrderTotal EcommerceViewAllPromotions --> OrderViewAllPromotions EcommerceViewCart --> OrderViewCart EcommerceYouMust --> OrderYouMust EcommerceYourPrice --> OrderYourPrice > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597825#action_12597825 ] Jacques Le Roux commented on OFBIZ-1780: ---------------------------------------- Hi Marco, First of all, thanks for your hard work on this. I just checked your last commit and found at least a problem I dreaded to face : inconsistent labels between files, for instance EcommerceRating in Order and Ecommerce component. This can be seen from 2 POVs : 1) These labels are simply inconsistent and, though we lost information in your rewriting, it shoud not be a big deal to fix them. 2) This was done intentionally and the labels are not inconsistent but overriden (as Adrian already outlined in http://docs.ofbiz.org/display/OFBIZ/Tips+for+translation) As you can see, it implies to look exhaustively in each use of each label to be sure of their usages... That's why we should be very careful when doing this task. There is no hurry and we can't afford to lose information. There is a french(?) proverb which says "L'enfer est pavé de bonnes intentions" (hell is paved with good intentions) very suitable in this case (http://www.answers.com/topic/list-of-english-proverbs :o) There are maybe more like this one, I did not check further Thanks > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597830#action_12597830 ] Marco Risaliti commented on OFBIZ-1780: --------------------------------------- Hi Jacques, I'm sorry but I did not understand you. Could you please give me a simple example (with a screenshot) that shows me your issues. I have checked the label EcommerceRating and it's used now only in the ecommerce application and so I didn't understand what you mean in this case for order application. Thanks Marco > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-1780: ----------------------------------- Attachment: screenshot-1.jpg > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-1780: ----------------------------------- Attachment: screenshot-2.jpg > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597836#action_12597836 ] Jacques Le Roux commented on OFBIZ-1780: ---------------------------------------- Marco, I agree that it's not obvious. Please, note however that my intent is to make a more general comment, anyway here is the example As you can see in http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?view=diff&r1=657556&r2=657557&pathrev=657557, previously we had - <property key="EcommerceRating"> - <value xml:lang="de">Bewertung (1-5; 5 entspricht sehr gut)</value> - <value xml:lang="en">Rating (1-5; 5 being best)</value> - <value xml:lang="es">Voto (de 1 a 5)</value> - <value xml:lang="fr">Note(s) (de 1 à 5, 5 étant la meilleure)</value> - <value xml:lang="it">Posizione(1-5; 5 è il migliore)</value> - <value xml:lang="nl">Waardering (1-5; 5 is het beste)</value> - <value xml:lang="pt_PT">Classe (1-5; 5 para o melhor)</value> - <value xml:lang="ro">Pozitia(1-5; 5 este cea mai buna )</value> - <value xml:lang="ru">Рейтинг (1-5; 5 лучший)</value> - <value xml:lang="th">การประเมิณ (1-5; 5 คุณสมบัติดีที่สุด)</value> - <value xml:lang="zh">评级 (1-5; 5最好)</value> - </property> In Order component and this was used in Ecommerce as you can see in screenshot-1. Now we have only the poorer one (at least in french but there are other languages concerned) which was already in Ecommerce as you can see in screenshot-2. As I said my intent is to underline the kind of drawbacks we can get doing this delicate issue. I did not find the time yet to evaluate the work proposed by Bruno but maybe we should have a look to see if it can avoid this type of issues. But I doubt it's possible to do this automatically easily since it's seems a challenging task, even by hand, as I hope this comment proves it. > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597837#action_12597837 ] Marco Risaliti commented on OFBIZ-1780: --------------------------------------- Jacques, Yes, I have understood your problem but I have follow this way to merge all the labels between ecommerce and order : if the translated labels was already available in EcommerceUiLabels.xml then I have take the translation form there otherwise from the OrderUiLabels.xml. So for French probably the correct translation was on it and we have lost it but I cannot know it. Thanks Marco > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597838#action_12597838 ] Jacques Le Roux commented on OFBIZ-1780: ---------------------------------------- Yes I understand you POV. And Actually it''s more because the legacy work was poorly done. Hopefully, there are not much like that and I will have a look and at least will put back the old Order one In Ecommerce as there is more information there. Thanks > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597841#action_12597841 ] Bruno Busco commented on OFBIZ-1780: ------------------------------------ The python script that I attached in OFBIZ-1698 scans for label duplication between files if a duplication is found then it merges the languages strings in the higher priority file (so that no content is lost) and deletes the entry from the lower priority file. Then the files are automatically sorted and so what remains to do is to change the name of the labels according to the file they are in. In the file there is also a report of what it has done when I run it. If you are interested and need help just ask. -Bruno > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597842#action_12597842 ] Jacques Le Roux commented on OFBIZ-1780: ---------------------------------------- Marco, I'm currently looking at this issue and it clearly appears that the problem is that the Order labels were loaded after the Ecommerce labels and were definitive > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597842#action_12597842 ] jacques.le.roux edited comment on OFBIZ-1780 at 5/18/08 1:48 PM: ----------------------------------------------------------------- Marco, I'm currently looking at this issue and it clearly appears that the problem is that the Order labels were loaded after the Ecommerce labels and hence were overrided them. They (Order labels) were definitively better writed (at least in french but it seems that it's true for other languages too). I'm rewriting them in french (and even for all other languages when they are totally missing as for EcommerceRead for instance) and I suggest to evrybody to check them. I propose to stop this sort of work and to have a look at what Bruno suggested before everything else... Thanks to both was (Author: jacques.le.roux): Marco, I'm currently looking at this issue and it clearly appears that the problem is that the Order labels were loaded after the Ecommerce labels and were definitive > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597845#action_12597845 ] Jacques Le Roux commented on OFBIZ-1780: ---------------------------------------- For instance a good example is EcommerceSelectedGiftWrap Before - <property key="EcommerceSelectedGiftWrap"> - <value xml:lang="en">"Selected Gift Wrap is not available for all items. The items which are available have been selected, the others remain unchanged."</value> - <value xml:lang="es">"La evoltura no está permitida para todos los artíclos. Los artículos disponibles han sido seleccionados, la orden permanece sin cambios."</value> - <value xml:lang="fr">"L'emballage cadeau choisi n'est pas disponible pour tous les articles. Les articles pour lesquels c'est disponible ont été retenus, les autres restent inchangés."</value> - <value xml:lang="it">"Selezione Omaggio non disponivile per tutte le righe. Le righe che sono disponibile saranno selezionate, le altre rimarrano invariate."</value> - <value xml:lang="nl">"De geselecteerde geschenkverpakking is niet beschikbaar voor alle items. De items die beschikbaar zijn, zijn geselecteerd, de anderen zijn niet veranderd."</value> - <value xml:lang="ro">"Selectioneaza Omagiu indisponibil pentru toate liniile. Liniile care sunt disponibile vor fi selectionate, celelalte vor ramane invariate."</value> - <value xml:lang="ru">"Выбранная подарочная упаковка не доступна для всех позиций. Выбраны только позиции для которых упаковка доступна."</value> - <value xml:lang="th">"การเลือกกระดาษห่อของขวัญไม่สามารถนำไปใช้ได้กับทุกรายการ. เลือกใช้ได้กับรายการอื่น ๆ ที่ยังไม่มีการเปลี่ยนแปลงเหลืออยู่" -</value> After <property key="EcommerceSelectedGiftWrap"> <value xml:lang="en">Selected Gift Wrap</value> <value xml:lang="es">"La evoltura no está permitida para todos los artíclos. Los artículos disponibles han sido seleccionados, la orden permanece sin cambios."</value> <value xml:lang="fr">Papier cadeau sélezctionné</value> <value xml:lang="hi_IN">चुना गया लपेटन सभी सामान के लिये उपलब्ध नहीं है, जो सामान उपलब्ध है वह चुना गया है, बाकी वैसे ही है.</value> <value xml:lang="it">"Selezione Omaggio non disponivile per tutte le righe. Le righe che sono disponibile saranno selezionate, le altre rimarrano invariate."</value> <value xml:lang="ja">"Selected Gift Wrap is not available for all items. The items which are available have been selected, the others remain unchanged."</value> <value xml:lang="nl">"De geselecteerde geschenkverpakking is niet beschikbaar voor alle items. De items die beschikbaar zijn, zijn geselecteerd, de anderen zijn niet veranderd."</value> <value xml:lang="ro">"Selectioneaza Omagiu indisponibil pentru toate liniile. Liniile care sunt disponibile vor fi selectionate, celelalte vor ramane invariate."</value> <value xml:lang="ru">"Выбранная подарочная упаковка не доступна для всех позиций. Выбраны только позиции для которых упаковка доступна."</value> <value xml:lang="th">เลือกห่อของขวัญ</value> <value xml:lang="zh">"所选的礼品包装无法对全部明细使用。这些选中的明细是可用的，其它没有改变。"</value> </property> Another french proverb : "L'enfer est dans les détails" (Hell is in details) (seems that Frenchs like to talk about Hell ;o) > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597845#action_12597845 ] jacques.le.roux edited comment on OFBIZ-1780 at 5/18/08 1:58 PM: ----------------------------------------------------------------- For instance a good example is EcommerceSelectedGiftWrap Before - <property key="EcommerceSelectedGiftWrap"> - <value xml:lang="en">"Selected Gift Wrap is not available for all items. The items which are available have been selected, the others remain unchanged."</value> - <value xml:lang="es">"La evoltura no está permitida para todos los artíclos. Los artículos disponibles han sido seleccionados, la orden permanece sin cambios."</value> - <value xml:lang="fr">"L'emballage cadeau choisi n'est pas disponible pour tous les articles. Les articles pour lesquels c'est disponible ont été retenus, les autres restent inchangés."</value> - <value xml:lang="it">"Selezione Omaggio non disponivile per tutte le righe. Le righe che sono disponibile saranno selezionate, le altre rimarrano invariate."</value> - <value xml:lang="nl">"De geselecteerde geschenkverpakking is niet beschikbaar voor alle items. De items die beschikbaar zijn, zijn geselecteerd, de anderen zijn niet veranderd."</value> - <value xml:lang="ro">"Selectioneaza Omagiu indisponibil pentru toate liniile. Liniile care sunt disponibile vor fi selectionate, celelalte vor ramane invariate."</value> - <value xml:lang="ru">"Выбранная подарочная упаковка не доступна для всех позиций. Выбраны только позиции для которых упаковка доступна."</value> - <value xml:lang="th">"การเลือกกระดาษห่อของขวัญไม่สามารถนำไปใช้ได้กับทุกรายการ. เลือกใช้ได้กับรายการอื่น ๆ ที่ยังไม่มีการเปลี่ยนแปลงเหลืออยู่" -</value> - <value xml:lang="zh">"所选的礼品包装无法对全部明细使用。这些选中的明细是可用的，其它没有改变。"</value> - </property> After <property key="EcommerceSelectedGiftWrap"> <value xml:lang="en">Selected Gift Wrap</value> <value xml:lang="es">"La evoltura no está permitida para todos los artíclos. Los artículos disponibles han sido seleccionados, la orden permanece sin cambios."</value> <value xml:lang="fr">Papier cadeau sélezctionné</value> <value xml:lang="hi_IN">चुना गया लपेटन सभी सामान के लिये उपलब्ध नहीं है, जो सामान उपलब्ध है वह चुना गया है, बाकी वैसे ही है.</value> <value xml:lang="it">"Selezione Omaggio non disponivile per tutte le righe. Le righe che sono disponibile saranno selezionate, le altre rimarrano invariate."</value> <value xml:lang="ja">"Selected Gift Wrap is not available for all items. The items which are available have been selected, the others remain unchanged."</value> <value xml:lang="nl">"De geselecteerde geschenkverpakking is niet beschikbaar voor alle items. De items die beschikbaar zijn, zijn geselecteerd, de anderen zijn niet veranderd."</value> <value xml:lang="ro">"Selectioneaza Omagiu indisponibil pentru toate liniile. Liniile care sunt disponibile vor fi selectionate, celelalte vor ramane invariate."</value> <value xml:lang="ru">"Выбранная подарочная упаковка не доступна для всех позиций. Выбраны только позиции для которых упаковка доступна."</value> <value xml:lang="th">เลือกห่อของขวัญ</value> <value xml:lang="zh">"所选的礼品包装无法对全部明细使用。这些选中的明细是可用的，其它没有改变。"</value> </property> Another french proverb : "L'enfer est dans les détails" (Hell is in details) (seems that Frenchs like to talk about Hell ;o) was (Author: jacques.le.roux): For instance a good example is EcommerceSelectedGiftWrap Before - <property key="EcommerceSelectedGiftWrap"> - <value xml:lang="en">"Selected Gift Wrap is not available for all items. The items which are available have been selected, the others remain unchanged."</value> - <value xml:lang="es">"La evoltura no está permitida para todos los artíclos. Los artículos disponibles han sido seleccionados, la orden permanece sin cambios."</value> - <value xml:lang="fr">"L'emballage cadeau choisi n'est pas disponible pour tous les articles. Les articles pour lesquels c'est disponible ont été retenus, les autres restent inchangés."</value> - <value xml:lang="it">"Selezione Omaggio non disponivile per tutte le righe. Le righe che sono disponibile saranno selezionate, le altre rimarrano invariate."</value> - <value xml:lang="nl">"De geselecteerde geschenkverpakking is niet beschikbaar voor alle items. De items die beschikbaar zijn, zijn geselecteerd, de anderen zijn niet veranderd."</value> - <value xml:lang="ro">"Selectioneaza Omagiu indisponibil pentru toate liniile. Liniile care sunt disponibile vor fi selectionate, celelalte vor ramane invariate."</value> - <value xml:lang="ru">"Выбранная подарочная упаковка не доступна для всех позиций. Выбраны только позиции для которых упаковка доступна."</value> - <value xml:lang="th">"การเลือกกระดาษห่อของขวัญไม่สามารถนำไปใช้ได้กับทุกรายการ. เลือกใช้ได้กับรายการอื่น ๆ ที่ยังไม่มีการเปลี่ยนแปลงเหลืออยู่" -</value> After <property key="EcommerceSelectedGiftWrap"> <value xml:lang="en">Selected Gift Wrap</value> <value xml:lang="es">"La evoltura no está permitida para todos los artíclos. Los artículos disponibles han sido seleccionados, la orden permanece sin cambios."</value> <value xml:lang="fr">Papier cadeau sélezctionné</value> <value xml:lang="hi_IN">चुना गया लपेटन सभी सामान के लिये उपलब्ध नहीं है, जो सामान उपलब्ध है वह चुना गया है, बाकी वैसे ही है.</value> <value xml:lang="it">"Selezione Omaggio non disponivile per tutte le righe. Le righe che sono disponibile saranno selezionate, le altre rimarrano invariate."</value> <value xml:lang="ja">"Selected Gift Wrap is not available for all items. The items which are available have been selected, the others remain unchanged."</value> <value xml:lang="nl">"De geselecteerde geschenkverpakking is niet beschikbaar voor alle items. De items die beschikbaar zijn, zijn geselecteerd, de anderen zijn niet veranderd."</value> <value xml:lang="ro">"Selectioneaza Omagiu indisponibil pentru toate liniile. Liniile care sunt disponibile vor fi selectionate, celelalte vor ramane invariate."</value> <value xml:lang="ru">"Выбранная подарочная упаковка не доступна для всех позиций. Выбраны только позиции для которых упаковка доступна."</value> <value xml:lang="th">เลือกห่อของขวัญ</value> <value xml:lang="zh">"所选的礼品包装无法对全部明细使用。这些选中的明细是可用的，其它没有改变。"</value> </property> Another french proverb : "L'enfer est dans les détails" (Hell is in details) (seems that Frenchs like to talk about Hell ;o) > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610707#action_12610707 ] Jacques Le Roux commented on OFBIZ-1780: ---------------------------------------- Hi Marco, all developers, I think we are able to continue this work. The rule has unofficially changed (except if someone is against and has good arguments) : there should be only one instance of a label in all translation files and labels should be, as much as passible, prefixed by the application name. Please comment if you have any ideas. If we officialy agree, I will update this page accordingly http://docs.ofbiz.org/display/OFBIZ/Tips+for+translation which is wrong for the moment... Thanks > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610745#action_12610745 ] Marco Risaliti commented on OFBIZ-1780: --------------------------------------- I'm agree with you Jacques about new rules for translation of labels. We can wait comments and/or ideas before continue it in that way. Thanks Marco > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1780: ---------------------------------- Attachment: cleanup_labels5.patch Removed some unsued labels. > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, cleanup_labels5.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1780: ---------------------------------- Attachment: cleanup_labels6.patch This patch contains some labels renamed from OrderXXX to EcommerceXXX OrderBeSureToIncludeYourOrderNb --> EcommerceBeSureToIncludeYourOrderNb OrderAssignItems --> EcommerceAssignItems OrderBackHome --> EcommerceBackHome OrderChangePaymentInfo --> EcommerceChangePaymentInfo OrderChangeShippingAddress --> EcommerceChangeShippingAddress OrderChangeShippingOptions --> EcommerceChangeShippingOptions OrderConfirmation --> EcommerceOrderConfirmation OrderContinueShopping --> EcommerceContinueShopping Thanks Marco > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, cleanup_labels5.patch, cleanup_labels6.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645604#action_12645604 ] Marco Risaliti commented on OFBIZ-1780: --------------------------------------- cleanup_labels5.patch committed in rev. 711973 cleanup_labels6.patch committed in rev. 711991 > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, cleanup_labels5.patch, cleanup_labels6.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1780: ---------------------------------- Attachment: cleanup_labels7.patch This patch contains some labels renamed from OrderXXX to EcommerceXXX OrderDefaultShipmentMethod --> EcommerceDefaultShipmentMethod OrderDefaultShipmentMethodMsg --> EcommerceDefaultShipmentMethodMsg OrderEstimateNextOrderDate --> EcommerceEstimateNextOrderDate OrderHistory --> EcommerceOrderHistory Removed unused labels: OrderFinalOrderNotification OrderInvoice Thanks Marco > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, cleanup_labels5.patch, cleanup_labels6.patch, cleanup_labels7.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1780: ---------------------------------- Attachment: cleanup_labels7.patch Updated patch after conflict resolution. > Clean up labels between order and ecommerce application > ------------------------------------------------------- > > Key: OFBIZ-1780 > URL: https://issues.apache.org/jira/browse/OFBIZ-1780 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assignee: Marco Risaliti > Priority: Minor > Fix For: SVN trunk > > Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch, cleanup_labels5.patch, cleanup_labels6.patch, cleanup_labels7.patch, cleanup_labels7.patch, screenshot-1.jpg, screenshot-2.jpg > > > Clean up labels between order and ecommerce application. > If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX). > This is the first patch and some more work is needed. > Let me know what did you think of it ? > Thanks > Marco -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |