[jira] Created: (OFBIZ-1780) Clean up labels between order and ecommerce application

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
123 messages Options
1234 ... 7
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
Clean up labels between order and ecommerce application
-------------------------------------------------------

                 Key: OFBIZ-1780
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
             Project: OFBiz
          Issue Type: Improvement
          Components: ecommerce, order
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Assignee: Marco Risaliti
            Priority: Minor
             Fix For: SVN trunk
         Attachments: cleanup_labels.patch

Clean up labels between order and ecommerce application.
If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
This is the first patch and some more work is needed.
Let me know what did you think of it ?

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1780:
----------------------------------

    Attachment: cleanup_labels.patch

First patch.

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595947#action_12595947 ]

Jacques Le Roux commented on OFBIZ-1780:
----------------------------------------

Hi Marco,

I did not review completly, this makes sense but do you remember OFBIZ-1698 ? I'm still working on the French part of the 18550 lines of ProductUiLabels.xml, sitll 1/3 to do. And some work done by another person on (party or order or both I don't remember) is waiting my review (as translating OFBiz is a bit specific)

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595993#action_12595993 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

Hi Jacques,

I'm thinking that the patch in OFBIZ-1698 is a very important task to be done but I think it's not valid for Order and Ecommerce applications because it's not enough to move label duplicated into OrderUiLabels.xml and EcommerceUiLabels.xml to EcommerceUiLabels.xml.
I think that every single label that is used only in Ecommerce has to be put into EcommerceUiLabels.xml and instead if it's used on both application it has to be renamed to OrderXXX and change all the references to this one.
For example the label EcommerceAddAllToCart has to be renamed to OrderAddAllToCart because it was used on both applications.

Thanks
Marco

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596026#action_12596026 ]

Jacques Le Roux commented on OFBIZ-1780:
----------------------------------------

Marco,

Yes I agree, actually it was more a reminder. I can't see any problems with your patch which makes totally sense as I already said. Morevoer I'm very respectful for such work : it's really tedious (I know what I'm speaking about ;o). But at the end OFBiz will be more attractive to new comers (always the 1st impression impact) and with this specific issue more easy to maintain and understand from the translation POV. Please feel free to commit.



> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596182#action_12596182 ]

Bruno Busco commented on OFBIZ-1780:
------------------------------------

Marco, Jacques,

I suggest to use the script contained in the OFBIZ-1698 issue before working on other name changing. In this way at least the number of label to edit is reduced (about 800 duplication were eliminated last time I ran it).


> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596198#action_12596198 ]

Jacques Le Roux commented on OFBIZ-1780:
----------------------------------------

Bruno,

I have done more than 2/3 of the work I need to commit before running this script. So I would prefer to run it after because I'm afraid or merging issues if it's ran before this commit. Then I will run it and continue my work on my side. I think that the work done by Marco can be commite before also. I hope to find time thereafter to write some scripts from your script to ease some processes (like finding missing labels in a language). In the same time I will learn Ruby but I'm not too afraid by that. Maybe I will use Java though, I will see when using your script... I will not be available for this task before next week anyway.

Also my concern is that we have to check the result of your script before commiting.

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596200#action_12596200 ]

Bruno Busco commented on OFBIZ-1780:
------------------------------------

Jacques,
fill free to do as you like... in any case the script is in Python ;-)

-Bruno

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596205#action_12596205 ]

Jacques Le Roux commented on OFBIZ-1780:
----------------------------------------

Yes, I meaned Python sorry (same kind of beast for me so far ;o).
Frankly I could also search for a free APL interpreter and write it in APL (when I need APL - ie when I need to write a script or a simple expression very quicly -  I still use APL+Win 4.0 from 2001) but I prefer to concentrate on novelties :o)

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596867#action_12596867 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

First patch committed in OFBiz trunk rev. 656347.

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1780:
----------------------------------

    Attachment: cleanup_labels2.patch

Second patch

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596935#action_12596935 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

Second patch committed in OFBiz trunk rev. 656426.
Please let me know if something is not correct.

Thanks
Marco

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597095#action_12597095 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

WARNING !!!

Please remember that if someone of you has a custom application that extends order and ecommerce application hat to replace the following labels with the new ones.

EcommerceAddAlltoCart -->  OrderAddAllToCart
EcommerceAddCheckedtoCart --> OrderAddCheckedToCart
EcommerceChooseVariations --> OrderChooseVariations
EcommerceChooseAmount --> OrderChooseAmount
EcommerceAverageRating --> OrderAverageRating
EcommerceAddtoShoppingList --> OrderAddToShoppingList
EcommerceAnonymous --> OrderAnonymous
EcommerceCheckoutQuick --> OrderCheckoutQuick
EcommerceCheckout --> OrderCheckout
EcommerceCartItemUseinPromotions --> OrderCartItemUseinPromotions
EcommerceCartSummary --> OrderCartSummary
EcommerceAlwaysList --> OrderAlwaysList


> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1780:
----------------------------------

    Attachment: cleanup_labels3.patch

Third patch.

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597261#action_12597261 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

Third patch committed in OFBiz trunk rev. 656832.
Please let me know if something is not correct.

Thanks
Marco

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597263#action_12597263 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

WARNING !!!

Please remember that if someone of you has a custom application that extends order and ecommerce application hat to replace the following labels with the new ones.

EcommerceClearSearchHistory --> OrderClearSearchHistory
EcommerceClearSearchHistoryNote --> OrderClearSearchHistoryNote
EcommerceConfigure --> OrderConfigure
EcommerceCustomerReviews --> OrderCustomerReviews
EcommerceCustomerTaxId --> OrderCustomerTaxId
EcommerceDigitalProductFiles --> OrderDigitalProductFiles
EcommerceEcludeCategories --> OrderExcludeCategories
EcommerceEcommerce --> OrderEcommerce
EcommerceErrorNoPromotionFoundWithID --> OrderErrorNoPromotionFoundWithID
EcommerceIncludes --> OrderIncludes
EcommerceIncludeSubCategories --> OrderIncludeSubCategories
EcommerceIsAPromotionalItem --> OrderIsAPromotionalItem
EcommerceItem --> OrderItem
EcommerceItemN --> OrderItemN
EcommerceItems --> OrderItems

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1780:
----------------------------------

    Attachment: cleanup_labels4.patch

Fourth patch

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597753#action_12597753 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

Fourth patch committed in OFBiz trunk rev. 657466.
Please let me know if something is not correct.

Thanks
Marco

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597754#action_12597754 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

WARNING !!!

Please remember that if someone of you has a custom application that extends order and ecommerce application has to replace the following labels with the new ones.

EcommerceLastSearches --> OrderLastSearches
EcommerceListType --> OrderListType
EcommerceMakeBooking --> OrderMakeBooking
EcommerceNbrPersons --> OrderNbrPersons
EcommerceNewShoppingList --> OrderNewShoppingList
EcommerceNothingToDoHere --> OrderNothingToDoHere
EcommerceOfPromotion --> OrderOfPromotion
EcommerceOnSale --> OrderOnSale
EcommercePieces --> OrderPieces
EcommerceProduct --> OrderProduct
EcommerceProductsForPromotion --> OrderProductsForPromotion
EcommercePromotionCategories --> OrderPromotionCategories
EcommercePromotionDetails --> OrderPromotionDetails
EcommercePromotionInformation --> OrderPromotionInformation
EcommercePromotionProductsInCategories --> OrderPromotionProductsInCategories


> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1780) Clean up labels between order and ecommerce application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597808#action_12597808 ]

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

Fifth patch committed in OFBiz trunk rev. 657557.
Please let me know if something is not correct.

Thanks
Marco

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch, cleanup_labels2.patch, cleanup_labels3.patch, cleanup_labels4.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be converted to OrderXXX style and instead if they has been used by a specific application they will be converted to that specific style (OrderXXX or EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

1234 ... 7