[jira] Created: (OFBIZ-1841) Using collapsable screenlet in Lookups
Locked
[jira] Created: (OFBIZ-1841) Using collapsable screenlet in Lookups
 
|
Using collapsable screenlet in Lookups
-------------------------------------- Key: OFBIZ-1841 URL: https://issues.apache.org/jira/browse/OFBIZ-1841 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bruno Busco Attachments: collapsable-lookup.patch In the attached patch a new CollapsableLookupDecorator has been defined. With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. The following lookups have been changed to use this new decorator: LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: collapsable-lookup.patch > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: collapsable-lookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605088#action_12605088 ] Adrian Crum commented on OFBIZ-1841: ------------------------------------ Do we really need an additional decorator? Why not make these changes to the existing lookup decorator? > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: collapsable-lookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605100#action_12605100 ] Bruno Busco commented on OFBIZ-1841: ------------------------------------ Sure, the final one should be to change the existing decorator. I created a new one so that it could be possible to have a gradual migration of all lookups. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: collapsable-lookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605127#action_12605127 ] Bruno Busco commented on OFBIZ-1841: ------------------------------------ OK, I have seen that even making the changes to the actual LookupDecorator and not creating a new one does not break the not-yet-adapted Lookups. I will update the patch soon. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: collapsable-lookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: order-newlookup.patch product-newlookup.patch callapsable-lookupdecorator.patch I have sligtly modified (and removed) the previous patch. Now in the callapsable-lookupdecorator.patch file there is a change that makes the search part of LookupDecorator collapsable. The new decorator still renders fine all lookups that use it (even if they will be not collapsable). I have started to convert all ofbiz lookups, please find the first three sets in: product-newlookup.patch, order-newlookup.patch, party-newlookup.patch If you are ok with this other will come... > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: party-newlookup.patch > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: (was: collapsable-lookup.patch) > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-1841: ---------------------------------- Assignee: Adrian Crum > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605137#action_12605137 ] Adrian Crum commented on OFBIZ-1841: ------------------------------------ Bruno, Thank you very much for the updated Lookup decorator patch. I made some changes to it and committed it - rev 667965. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605165#action_12605165 ] Bruno Busco commented on OFBIZ-1841: ------------------------------------ Adrian, thank you for your modifications, now the lookup works exactly the same as before if no change are done to the LookupScreens. Great ! I have learned more about decorator sections from your modification. I have seen that you also changed that the initial status of the search section of the lookup is not collapsed. In my opinion the lookup table should appear to the user as just a table and the search part should be an option the user could use if needed. This is why I decided to use the collapsable functionality in lookups. May be a drawback of having the search section initially collapsed is that it could never be accessed if scripting is disabled. But apart of this (and may be there is a workaround) I think it should better be collapsed. What about the remaining patches? Are we ok to commit them? Or is there a different pattern we would better use? Once we are sure of the pattern the lookupsceens should have I can move on changing all other files. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605189#action_12605189 ] David E. Jones commented on OFBIZ-1841: --------------------------------------- My opinion on this: 1. the search parameters form should start out expanded 2. the results form should start out empty, ie there should not be an initial query in place The reason for this is pretty simple: the only reason to have a lookup window is because there will likely be a lot of results, too many for the alternative of a simpler drop down field. In the case when we know there will be lots of results we don't want to just show results with no constraints, unless the user explicitly submits the parameters form with no constraints to request it. That is the point of the parameter/field to not do a search with no parameters/constraints. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605292#action_12605292 ] Jacques Le Roux commented on OFBIZ-1841: ---------------------------------------- I agree with David > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605305#action_12605305 ] Adrian Crum commented on OFBIZ-1841: ------------------------------------ Bruno, I intend to commit the remaining patches. I was waiting a bit to think about some issues - some of which were just discussed. Since the collapsible screenlet was converted to JavaScript we now have a problem. If you collapse the screenlet and then use one of the pagination controls, the screenlet will expand itself. This is because the screenlet state change has not been "saved" anywhere. I'm not sure how to solve the problem, so I will hold off committing the additional patches until I do. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606596#action_12606596 ] Adrian Crum commented on OFBIZ-1841: ------------------------------------ Bruno, I have fixed the problem in the screenlet widget. If you have time, could you update your patches so that the full list isn't displayed when the window first appears? Once that is done I will commit the remaining patches. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, order-newlookup.patch, party-newlookup.patch, product-newlookup.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: (was: product-newlookup.patch) > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: (was: party-newlookup.patch) > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: (was: order-newlookup.patch) > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1841: ------------------------------- Attachment: lookupScreens.patch OK, I have modified ALL lookups to use the LookupDecorator. Now there is less code for every lookup and there are no more container tags used. BTW: I find that the bug that makes the collapsed to expand again during pagination is still there, don't you? > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, lookupScreens.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-1841) Using collapsable screenlet in Lookups
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-1841. ------------------------------ Resolution: Fixed Thanks Bruno. Your patch is in svn - rev 670249. > Using collapsable screenlet in Lookups > -------------------------------------- > > Key: OFBIZ-1841 > URL: https://issues.apache.org/jira/browse/OFBIZ-1841 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Bruno Busco > Assignee: Adrian Crum > Attachments: callapsable-lookupdecorator.patch, lookupScreens.patch > > > In the attached patch a new CollapsableLookupDecorator has been defined. > With this decorator the lookup pops up with the search section collapsed and with the elements list not filtered. > The following lookups have been changed to use this new decorator: > LookupProduct, LookupProductAndPrice, LookupProductCategory, LookupProductFeature, LookupProductStore. > If everybody is fine with the CollapsableLookupDecorator I will try to change the other lookups also. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |