[jira] Created: (OFBIZ-1856) Improvments in "deleteWorkEffort" Service.

[Nicolas Malin (Jira)]

Improvments in "deleteWorkEffort" Service.
------------------------------------------

                 Key: OFBIZ-1856
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1856
             Project: OFBiz
          Issue Type: Improvement
          Components: workeffort
            Reporter: Ratnesh Upadhyay
            Priority: Minor


Imporvents needed for " deleteWorkEffort Service" :
1). Delete all the records from associated entites with a work effort, when we delete the workeffort.
2). Remove operation is missing for few entities, please verified all associated entities.
3).  We can use WorkEffortNote entity instead of DataNote for deletion of associated notes with a workeffort.
       Because there can be more than one notes exist for a work effort as well.

Thanks to Ashish for discussing with me on the issue.

-- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1856:
----------------------------------

    Attachment: serviceImprovements.patch

Improved code for deletion of all records from associated entites with a work effort, when we delete the workeffort.

Thanks to Ratnesh Upadhayay for helping.
Thanks and Regards
-Awdesh Parihar

> Improvments in "deleteWorkEffort" Service.
> ------------------------------------------
>
>                 Key: OFBIZ-1856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1856
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Ratnesh Upadhyay
>            Priority: Minor
>         Attachments: serviceImprovements.patch
>
>
> Imporvents needed for " deleteWorkEffort Service" :
> 1). Delete all the records from associated entites with a work effort, when we delete the workeffort.
> 2). Remove operation is missing for few entities, please verified all associated entities.
> 3).  We can use WorkEffortNote entity instead of DataNote for deletion of associated notes with a workeffort.
>        Because there can be more than one notes exist for a work effort as well.
> Thanks to Ashish for discussing with me on the issue.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609273#action_12609273 ]

Anil K Patel commented on OFBIZ-1856:
-------------------------------------

Have not seen the patch yet.

Are we actually deleting records? or Marking them deleted. I mean setting thruDate date?

> Improvments in "deleteWorkEffort" Service.
> ------------------------------------------
>
>                 Key: OFBIZ-1856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1856
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Ratnesh Upadhyay
>            Priority: Minor
>         Attachments: serviceImprovements.patch
>
>
> Imporvents needed for " deleteWorkEffort Service" :
> 1). Delete all the records from associated entites with a work effort, when we delete the workeffort.
> 2). Remove operation is missing for few entities, please verified all associated entities.
> 3).  We can use WorkEffortNote entity instead of DataNote for deletion of associated notes with a workeffort.
>        Because there can be more than one notes exist for a work effort as well.
> Thanks to Ashish for discussing with me on the issue.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-1856:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Improvments in "deleteWorkEffort" Service.
> ------------------------------------------
>
>                 Key: OFBIZ-1856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1856
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: serviceImprovements.patch
>
>
> Imporvents needed for " deleteWorkEffort Service" :
> 1). Delete all the records from associated entites with a work effort, when we delete the workeffort.
> 2). Remove operation is missing for few entities, please verified all associated entities.
> 3).  We can use WorkEffortNote entity instead of DataNote for deletion of associated notes with a workeffort.
>        Because there can be more than one notes exist for a work effort as well.
> Thanks to Ashish for discussing with me on the issue.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620651#action_12620651 ]

Adrian Crum commented on OFBIZ-1856:
------------------------------------

Or you can set their status to Cancelled. I believe trying to delete them will be hard to do.

> Improvments in "deleteWorkEffort" Service.
> ------------------------------------------
>
>                 Key: OFBIZ-1856
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1856
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: serviceImprovements.patch
>
>
> Imporvents needed for " deleteWorkEffort Service" :
> 1). Delete all the records from associated entites with a work effort, when we delete the workeffort.
> 2). Remove operation is missing for few entities, please verified all associated entities.
> 3).  We can use WorkEffortNote entity instead of DataNote for deletion of associated notes with a workeffort.
>        Because there can be more than one notes exist for a work effort as well.
> Thanks to Ashish for discussing with me on the issue.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.