[jira] Created: (OFBIZ-1885) Selectable Visual Themes
Locked
12345
12345
[jira] Created: (OFBIZ-1885) Selectable Visual Themes
 
|
Selectable Visual Themes
------------------------ Key: OFBIZ-1885 URL: https://issues.apache.org/jira/browse/OFBIZ-1885 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visual_theme_data.patch visual_theme_data.patch contains the entities and seed data. I'll continue working on this when I have time. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_theme_data.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615014#action_12615014 ] Jacopo Cappellato commented on OFBIZ-1885: ------------------------------------------ Hi Adrian, this is interesting, thanks for sharing your work in progress. IMO it would be better to rename the entity "VisualThemeType" to "VisualTheme" so that the naming conventions for the header/item patter are better followed: VisualTheme |______________> VisualThemeResource |______________> VisualThemeResource |______________> VisualThemeResource .... Also, but not sure about this: would it make sense to store the VisualThemeResourceTypes in the Enumeration entity instead of their own one? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_theme_data.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615032#action_12615032 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Jacopo, Those are great suggestions - thanks! > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_theme_data.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visual_theme_data.patch Updated patch. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_theme_data.patch, visual_theme_data.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: (was: visual_theme_data.patch) > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: (was: visual_theme_data.patch) > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visual_themes.patch New patch. Now includes a service to get visual themes and changes to the UI artifacts to display the theme. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617225#action_12617225 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Steps needed for completion: 1. Theme CRUD services. 2. Theme CRUD UI artifacts. 3. Theme selection screen in MyPage component. I won't be able to work on this for a few weeks. If anyone wants to jump in and help, they are welcome to do so. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617245#action_12617245 ] David E. Jones commented on OFBIZ-1885: --------------------------------------- To make things more consistent, how about renaming resourceEnumId as resourceTypeEnumId. BTW, just a side note while reviewing this... implementing the main service in Java is interesting, but the code would be simpler and more concise written in Groovy, and you could probably even do this in a simple-method. BTW2: for the CrUD services try the entity-auto thingy. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617271#action_12617271 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ How would I implement the theme cache in Groovy or simple method? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1885: ------------------------------- Attachment: visual_themes.patch Updated patch. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-1885: ------------------------------- Attachment: theme_1.zip Adrian, I tryed your patch and I found it really cool !!! I did not resist to see how a theme could be distributed and installed leveraging on the theme system you have built and I found a way that IMO is really easy but for sure it needs a review... In the attached file theme_1.zip there is something that could be considered a pluggable theme. To install the theme it must be unzipped in the hot-deploy directory and then, using the webtool, the ext seed must be imported (or this can be done executing ant run-extseed). Then, since we have not yet the UI to select the theme, a manual selection can be done changing the line: <set field="visualThemeId" from-field="userPrefValue" default-value="DEFAULT"/> to: <set field="visualThemeId" from-field="userPrefValue" default-value="THEME_1"/> in the framework\common\widget\CommonScreens.xml file. What do you think of it? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617976#action_12617976 ] bruno.busco edited comment on OFBIZ-1885 at 7/29/08 3:03 PM: ------------------------------------------------------------- Adrian, I tryed your patch and I found it really cool !!! I did not resist to see how a theme could be distributed and installed leveraging on the theme system you have built and I found a way that IMO is really easy but for sure it needs a review... In the attached file theme_1.zip there is something that could be considered a pluggable theme. To install the theme it must be unzipped in the hot-deploy directory and then, using the webtool, the ext reader must be imported (or this can be done executing ant run-extseed). Then, since we have not yet the UI to select the theme, a manual selection can be done changing the line: <set field="visualThemeId" from-field="userPrefValue" default-value="DEFAULT"/> to: <set field="visualThemeId" from-field="userPrefValue" default-value="THEME_1"/> in the framework\common\widget\CommonScreens.xml file. What do you think of it? was (Author: bruno.busco): Adrian, I tryed your patch and I found it really cool !!! I did not resist to see how a theme could be distributed and installed leveraging on the theme system you have built and I found a way that IMO is really easy but for sure it needs a review... In the attached file theme_1.zip there is something that could be considered a pluggable theme. To install the theme it must be unzipped in the hot-deploy directory and then, using the webtool, the ext seed must be imported (or this can be done executing ant run-extseed). Then, since we have not yet the UI to select the theme, a manual selection can be done changing the line: <set field="visualThemeId" from-field="userPrefValue" default-value="DEFAULT"/> to: <set field="visualThemeId" from-field="userPrefValue" default-value="THEME_1"/> in the framework\common\widget\CommonScreens.xml file. What do you think of it? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617981#action_12617981 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ May be a special reader could be defined just for themes. This reader could be imported using a UI command in order to install new themes after they have been copied in the hot-deploy folder. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617985#action_12617985 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Reading the thread back I found the list of todos: 1. Theme CRUD services. 2. Theme CRUD UI artifacts. 3. Theme selection screen in MyPage component. May be we only need n. 3, don't we? > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617990#action_12617990 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ Bruno, Thank you very much for taking the time to look at this! Your zip file represents what we have discussed on the dev mailing list so far - themes can be added to OFBiz by dropping them in the hot-deploy folder. Don't worry about the theme implementation changing - I'm pretty happy with where it is right now. If any changes are made to the code I've submitted so far, they will be minor ones. (Example: I'm thinking we should have a "Footer Javascript" resource type.) Getting step #3 implemented would help others see the visual theme capability sooner. Steps #1 and #2 are based on something David suggested: a UI so people can build their own themes by uploading style sheets, java script files, and such. I don't have time right now to try out your theme. I'm fully committed to other projects for the next few weeks. I will get back to this though - it is something I have been wanting in OFBiz for a long time. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617998#action_12617998 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Theme_1.zip does not pretend to be an usable theme, the css file is something I was working on but not finisched and header and footer are the standard one with an additional label to check that they were loaded in plase of the original. So it is just a test theme to discuss about the format. Looking forward to the real theme-gallery !!! ;-) I will try to include a drop-down field in the preferences screen to have #3 working... > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618013#action_12618013 ] Bruno Busco commented on OFBIZ-1885: ------------------------------------ Unfortunately #3 seems not as easy as adding a drop-down field in the same form where the mypage preferences check boxes are...sorry :-( > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618015#action_12618015 ] Adrian Crum commented on OFBIZ-1885: ------------------------------------ The MyPage Preferences page should have a tab bar menu with two items: Main and Visual Theme. The Main tab would contain the current MyPage preferences form, the Visual Theme tab would contain the visual theme selection box. > Selectable Visual Themes > ------------------------ > > Key: OFBIZ-1885 > URL: https://issues.apache.org/jira/browse/OFBIZ-1885 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch > > > Implement entities, services, and UI artifacts to add support for selectable Visual Themes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |