OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1912) Configurable products with Virtual product options

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

16 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1912) Configurable products with Virtual product options

Configurable products with Virtual product options
--------------------------------------------------

Key: OFBIZ-1912
URL: https://issues.apache.org/jira/browse/OFBIZ-1912
Project: OFBiz
Issue Type: New Feature
Components: product
Affects Versions: SVN trunk
Reporter: Bilgin Ibryam
Assignee: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
Attachments: conf_virtual_product.patch

Hi all,

to implement this feature I did the following things:

1. Added a new entity ConfigOptionProductOption to store selected variant products per configuration.
2. Moved a code snippet about products with VV_FEATURETREE from ShoppingCartEvents to ProductWorker.
3. Added a demo product PIZZA to test demonstrate Configurable products with Virtual product options.

After applying the patch and run-install you can find the product on ecommerce and order manager. Based on selected variant products, the price of configurable product is recalculated.

Any test, review and thoughts would be greatly appreciated.
Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1912) Configurable products with Virtual product options

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1912:
---------------------------------

Attachment: conf_virtual_product.patch

> Configurable products with Virtual product options
> --------------------------------------------------
>
> Key: OFBIZ-1912
> URL: https://issues.apache.org/jira/browse/OFBIZ-1912
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: conf_virtual_product.patch
>
>
> Hi all,
> to implement this feature I did the following things:
> 1. Added a new entity ConfigOptionProductOption to store selected variant products per configuration.
> 2. Moved a code snippet about products with VV_FEATURETREE from ShoppingCartEvents to ProductWorker.
> 3. Added a demo product PIZZA to test demonstrate Configurable products with Virtual product options.
> After applying the patch and run-install you can find the product on ecommerce and order manager. Based on selected variant products, the price of configurable product is recalculated.
> Any test, review and thoughts would be greatly appreciated.
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621148#action_12621148 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

Hi Bilgin,

I hope to do a complete review in the following days...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621547#action_12621547 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

Just tested for now.

1st I'd like to thank you for that work !

I was suprised to see any variants as I thought it will be a virtual product, of configurable type, with variants. So I think to demonstrate the advantages of your combination you should better use an at least 2 level features categorie (like tomato or chili + 2 kinds of cheese or whatelse). This because with the config options you are already able to do a one level choise (like small or large pizza)

In my cursorily review, I also noticed that
. in eCommerce, the Product Aggregated Price is well recalculated when changing a config option but not when you choose a variant option.
. There are some new tabs in configproductdetail.ftl, inlineProductDetail.ftl

BTW, in this respect, ShoppingCartEvents.java is a real mess... I know you are not the culprit, Hans seems to be (Revision: 651480). Anyway most of it (if not all) will go away wih your commit I guess.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621556#action_12621556 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

Ha no sorry Hans, It was there before it seems. I checked I'm not the culprit ...phew!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621743#action_12621743 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

Ha also BIlgin, you could pick an image somewhere (licence ok) for your pizza :D

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621783#action_12621783 ]

Bilgin Ibryam commented on OFBIZ-1912:
--------------------------------------

Jacques,

thanks for your review and ideas.
I wanted to add an image, but was not sure about licence issues for images.
You said (licence ok), is it means that I can choose an image from internet and add to OFBiz w/o any licence concerns?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621790#action_12621790 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

Unfortunately not, the images have to be free of rights as are the ones in framework\images\webapp\images\products\.
But there are free images libraries on Internet... fun isn'it ;o)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1912.
--------------------------------

Resolution: Fixed

Committed in trunk rev. 685807

Jacques, do you know any free images libraries on Internet or where from are downloaded the images in ofbiz?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622504#action_12622504 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

I don't remember where come from the images in OFBiz. You may find new ones using http://www.masternewmedia.org/where_to_find_free_images_and_visuals/ (just found with Google using "free images libraries"

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622505#action_12622505 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

This one is not too bad : http://gallery.hd.org/_tn/sml/food/_more2007/_more10/pizza-potato-based-home-made-homemade-with-cherry-and-chopped-tomatoes-onion-garlic-mozzarella-cheese-basil-leaves-and-the-help-of-one-toddler-cooking-and-tasting-eating-66-DHD.jpg

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Ashish Vijaywargiya

Re: [jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

Here are some more free Image/Picture websites :-

http://www.free-pictures-photos.com/
http://www.freefoto.com/index.jsp
http://www.freephoto1.com/
http://www.bigfoto.com/

Google was my friend for searching those websites :-).

--
Ashish Vijaywargiya
Indore (M.P), India
http://en.wikipedia.org/wiki/Indore

On Thu, Aug 14, 2008 at 3:57 PM, Jacques Le Roux (JIRA) <[hidden email]>wrote:

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622505#action_12622505]
>
> Jacques Le Roux commented on OFBIZ-1912:
> ----------------------------------------
>
> This one is not too bad :
> http://gallery.hd.org/_tn/sml/food/_more2007/_more10/pizza-potato-based-home-made-homemade-with-cherry-and-chopped-tomatoes-onion-garlic-mozzarella-cheese-basil-leaves-and-the-help-of-one-toddler-cooking-and-tasting-eating-66-DHD.jpg
>
> > Configurable products with Virtual product options
> > --------------------------------------------------
> >
> > Key: OFBIZ-1912
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1912
> > Project: OFBiz
> > Issue Type: New Feature
> > Components: product
> > Affects Versions: SVN trunk
> > Reporter: Bilgin Ibryam
> > Assignee: Bilgin Ibryam
> > Priority: Minor
> > Fix For: SVN trunk
> >
> > Attachments: conf_virtual_product.patch
> >
> >
> > Hi all,
> > to implement this feature I did the following things:
> > 1. Added a new entity ConfigOptionProductOption to store selected variant
> products per configuration.
> > 2. Moved a code snippet about products with VV_FEATURETREE from
> ShoppingCartEvents to ProductWorker.
> > 3. Added a demo product PIZZA to test demonstrate Configurable products
> with Virtual product options.
> > After applying the patch and run-install you can find the product on
> ecommerce and order manager. Based on selected variant products, the price
> of configurable product is recalculated.
> > Any test, review and thoughts would be greatly appreciated.
> > Bilgin Ibryam
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

Administrator

Yes, it seems that it's easier to find photographies than illustrations.
No surprise though : easier also to shoot than to draw ;o)

Jacques

From: "Ashish Vijaywargiya" <[hidden email]>

> Here are some more free Image/Picture websites :-
>
> http://www.free-pictures-photos.com/
> http://www.freefoto.com/index.jsp
> http://www.freephoto1.com/
> http://www.bigfoto.com/
>
> Google was my friend for searching those websites :-).
>
> --
> Ashish Vijaywargiya
> Indore (M.P), India
> http://en.wikipedia.org/wiki/Indore
>
>
>
> On Thu, Aug 14, 2008 at 3:57 PM, Jacques Le Roux (JIRA) <[hidden email]>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622505#action_12622505]
>>
>> Jacques Le Roux commented on OFBIZ-1912:
>> ----------------------------------------
>>
>> This one is not too bad :
>> http://gallery.hd.org/_tn/sml/food/_more2007/_more10/pizza-potato-based-home-made-homemade-with-cherry-and-chopped-tomatoes-onion-garlic-mozzarella-cheese-basil-leaves-and-the-help-of-one-toddler-cooking-and-tasting-eating-66-DHD.jpg
>>
>> > Configurable products with Virtual product options
>> > --------------------------------------------------
>> >
>> > Key: OFBIZ-1912
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1912
>> > Project: OFBiz
>> > Issue Type: New Feature
>> > Components: product
>> > Affects Versions: SVN trunk
>> > Reporter: Bilgin Ibryam
>> > Assignee: Bilgin Ibryam
>> > Priority: Minor
>> > Fix For: SVN trunk
>> >
>> > Attachments: conf_virtual_product.patch
>> >
>> >
>> > Hi all,
>> > to implement this feature I did the following things:
>> > 1. Added a new entity ConfigOptionProductOption to store selected variant
>> products per configuration.
>> > 2. Moved a code snippet about products with VV_FEATURETREE from
>> ShoppingCartEvents to ProductWorker.
>> > 3. Added a demo product PIZZA to test demonstrate Configurable products
>> with Virtual product options.
>> > After applying the patch and run-install you can find the product on
>> ecommerce and order manager. Based on selected variant products, the price
>> of configurable product is recalculated.
>> > Any test, review and thoughts would be greatly appreciated.
>> > Bilgin Ibryam
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>

Bilgin Ibryam

Re: [jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

On Fri, 2008-08-15 at 22:19 +0200, Jacques Le Roux wrote:

> Yes, it seems that it's easier to find photographies than illustrations.
> No surprise though : easier also to shoot than to draw ;o)
>
> Jacques
>
> From: "Ashish Vijaywargiya" <[hidden email]>
> > Here are some more free Image/Picture websites :-
> >
> > http://www.free-pictures-photos.com/
> > http://www.freefoto.com/index.jsp
> > http://www.freephoto1.com/
> > http://www.bigfoto.com/
> >

Jacques, Ashish, thanks for helping me.

I couldn't find any drawings similar to the ones in ofbiz, also I have
some concerns about the "terms of use" in these pages. There are
conditions like "You MUST NOT: Redistribute the images for public
download..." and I don't know is it ok to add to ofbiz images with these
terms.
For now I give up, at least till I find something that I'm sure is ok to
add to ofbiz.

If someone finds/has suitable images, fell free to add or propose.

Bilgin

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636412#action_12636412 ]

Jacques Le Roux commented on OFBIZ-1912:
----------------------------------------

I finally put one image in revision: 701201

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637042#action_12637042 ]

Bilgin Ibryam commented on OFBIZ-1912:
--------------------------------------

It is perfect, thanks Jacques!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.