[jira] Created: (OFBIZ-1988) Find product By this id or other identification

[Nicolas Malin (Jira)]

Find product By this id or other identification
-----------------------------------------------

                 Key: OFBIZ-1988
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
             Project: OFBiz
          Issue Type: New Feature
          Components: product
    Affects Versions: SVN trunk
            Reporter: nicolas malin
             Fix For: SVN trunk


I create a service to find a product are all product that match a value given.
If the service has just a productId, he search the product by the productId and after on all goodIdentification.
If a goodIdentificationType is present, the search is limit to this type


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas malin updated OFBIZ-1988:
---------------------------------

    Attachment: findProductByGI.patch

> Find product By this id or other identification
> -----------------------------------------------
>
>                 Key: OFBIZ-1988
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: findProductByGI.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> I create a service to find a product are all product that match a value given.
> If the service has just a productId, he search the product by the productId and after on all goodIdentification.
> If a goodIdentificationType is present, the search is limit to this type

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637822#action_12637822 ]

Ray Barlow commented on OFBIZ-1988:
-----------------------------------

Nicolas,

There is an existing function findProductsById found in FacilityServices.java that seems to do nearly what you have submitted here? It doesn't extract the first result and isolate it but that sounds like a very bespoke requirement and the service would better suit reuse if it just returned a complete list.

Some general comments:
The code in the patch does not follow the standard formatting guidelines recommended for OFBiz
You've completely ignored error handling and are throwing general database exceptions back through the service call which is a problem.
You're using the view GoodIdentificationAndProduct so why not just return that rather than loop through and look up all the real "Product" entities? Chances are most callers would find the information they require on the GoodIdentificationAndProduct view entity and if required they can get the real Product entity. Might save a fair amount of database access for the majority of usage.

Ray

> Find product By this id or other identification
> -----------------------------------------------
>
>                 Key: OFBIZ-1988
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: findProductByGI.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> I create a service to find a product are all product that match a value given.
> If the service has just a productId, he search the product by the productId and after on all goodIdentification.
> If a goodIdentificationType is present, the search is limit to this type

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637875#action_12637875 ]

Marco Risaliti commented on OFBIZ-1988:
---------------------------------------

It seems to me that searching product by GoodIdentification type/id is already existing into advanced search of catalog application.
I propose to close this issue as invalid.

Thanks
Marco

> Find product By this id or other identification
> -----------------------------------------------
>
>                 Key: OFBIZ-1988
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: findProductByGI.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> I create a service to find a product are all product that match a value given.
> If the service has just a productId, he search the product by the productId and after on all goodIdentification.
> If a goodIdentificationType is present, the search is limit to this type

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Barlow closed OFBIZ-1988.
-----------------------------

    Resolution: Invalid

I agree Marco more effort to fix than benefit delivered to the project as it stands.

Nicolas just to say thank you for the submission but in this case more work is required, so please consider the comments above and if after that you think there is still benefit for the project then please submit another new and improved patch.

Thanks,

Ray

> Find product By this id or other identification
> -----------------------------------------------
>
>                 Key: OFBIZ-1988
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: findProductByGI.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> I create a service to find a product are all product that match a value given.
> If the service has just a productId, he search the product by the productId and after on all goodIdentification.
> If a goodIdentificationType is present, the search is limit to this type

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638547#action_12638547 ]

nicolas malin commented on OFBIZ-1988:
--------------------------------------

Ray,
Thanks for your return. I didn't look the service in FacilityServices.java before my coding, I was prefered improve it. And you right for my code, I leaved some formatting Neogia project, excuse me.

The puspose of th function isn't the same that advanced search, because when you want search product by id you need search by productId and if not exists on goodIdentification. This is more use for quick search screen, example in warehouse because the screen have just one text input.

I propose to improve the actual function and move this on Product module. I think to find a product by ids in quick find is can use on other components that order, facility, and all module who an operator can use a bar code reader. Are you OK ? If yes, I open a new Jira with the improvement

> Find product By this id or other identification
> -----------------------------------------------
>
>                 Key: OFBIZ-1988
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: findProductByGI.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> I create a service to find a product are all product that match a value given.
> If the service has just a productId, he search the product by the productId and after on all goodIdentification.
> If a goodIdentificationType is present, the search is limit to this type

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638763#action_12638763 ]

Jacques Le Roux commented on OFBIZ-1988:
----------------------------------------

Nicolas,

Which screen are you talking about in warehouse, "Receive Inventory" ?

I think it coul be a good improvment but you will have to deal GoodIdentification.idValue non uniqueness.
For instance have a look in DemoRetail.xml, GZ-1000 and GZ-1001 have the same. So you can have 2 products with the same GoodIdentification.idValue. The POS UI deals with that in SelectProduct.java.

HTH

> Find product By this id or other identification
> -----------------------------------------------
>
>                 Key: OFBIZ-1988
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1988
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: findProductByGI.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> I create a service to find a product are all product that match a value given.
> If the service has just a productId, he search the product by the productId and after on all goodIdentification.
> If a goodIdentificationType is present, the search is limit to this type

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.