OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity
---------------------------------------------------------------------------------------------------------------------------

Key: OFBIZ-2018
URL: https://issues.apache.org/jira/browse/OFBIZ-2018
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/projectmgr, workeffort
Affects Versions: SVN trunk
Environment: any
Reporter: Hans Bakker
Assignee: Hans Bakker
Priority: Minor
Fix For: SVN trunk

Proposed are 2 changes realting to a rate:

1. move the currencyUomId field in the primary key of the Ratetype table and change the reference to the PartyRate including the rateType and currencyUomId. This allows to specify a rateType in different currencies.

2. Add a percentage field to the partyRate entity to charge only a percentage of the actual time spend on the task. We have many employees in training and we want only a percentage of the time to be charged on the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646037#action_12646037 ]

Hans Bakker commented on OFBIZ-2018:
------------------------------------

to make the fields more consistent i would also like to rename the field: rateUomId to: currencyUomId in the RateType table

> put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2018
> URL: https://issues.apache.org/jira/browse/OFBIZ-2018
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/projectmgr, workeffort
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
>
> Proposed are 2 changes realting to a rate:
> 1. move the currencyUomId field in the primary key of the Ratetype table and change the reference to the PartyRate including the rateType and currencyUomId. This allows to specify a rateType in different currencies.
> 2. Add a percentage field to the partyRate entity to charge only a percentage of the actual time spend on the task. We have many employees in training and we want only a percentage of the time to be charged on the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646040#action_12646040 ]

David E. Jones commented on OFBIZ-2018:
---------------------------------------

Would that make the purpose of the field less clear?

What I mean is that if there is a "rate" field and a "rateUomId" it is clear they go together, but if it was named something else then it would be hard to tell by the names and would only be clear through documentation or something (not that there shouldn't be documentation too, but it's nice to see patterns according to how things are named).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646046#action_12646046 ]

Hans Bakker commented on OFBIZ-2018:
------------------------------------

David, I tried to count the number of times currencyUomId is used through the entites and stopped counting at 20. so it is an often used pattern. That is the reason i renamed it because the file need to be recreated anyway..
uomId can mean anything and adding the 'currency' to it makes it more clear. To have a compromise rateCurrencyUomId is a solution?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646124#action_12646124 ]

David E. Jones commented on OFBIZ-2018:
---------------------------------------

This is one case where it might be good to have less consistency, or in other words to have these fields be more distinguished.

What I mean is that in a way having a field named "currencyUomId" is only a little better than having a field named "uomId". In either case you don't know what the Uom is describing, ie what field it relates to.

Fields that relate to other fields but are not similarly named is something we could consider an "anti-pattern" and it would be nice to change these to be more specific than less.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-2018.
------------------------------

Resolution: Invalid

I was starting to implement this and came to the conclusion that this is not a good approach.

If we put the currency in the key of the ratetype entity then all entities referrring to it (4 in total) also have the currency in the entity....not a good idea.

i will open a new issue...

Hans

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646128#action_12646128 ]

Jacques Le Roux commented on OFBIZ-2018:
----------------------------------------

Hans,

Why would you want to change from rateUomId to rateCurrencyUomId ? Are we sure that a rate would ever be for a currency ? It seems tome that here a rate concept is more general and open.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

hans_bakker

Re: [jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

Can you give an example of a usage not involving currency?

On Sun, 2008-11-09 at 15:12 -0800, Jacques Le Roux (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646128#action_12646128 ]
>
> Jacques Le Roux commented on OFBIZ-2018:
> ----------------------------------------
>
> Hans,
>
> Why would you want to change from rateUomId to rateCurrencyUomId ? Are we sure that a rate would ever be for a currency ? It seems tome that here a rate concept is more general and open.
>
>
> > put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity
> > ---------------------------------------------------------------------------------------------------------------------------
> >
> > Key: OFBIZ-2018
> > URL: https://issues.apache.org/jira/browse/OFBIZ-2018
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: specialpurpose/projectmgr, workeffort
> > Affects Versions: SVN trunk
> > Environment: any
> > Reporter: Hans Bakker
> > Assignee: Hans Bakker
> > Priority: Minor
> > Fix For: SVN trunk
> >
> >
> > Proposed are 2 changes realting to a rate:
> > 1. move the currencyUomId field in the primary key of the Ratetype table and change the reference to the PartyRate including the rateType and currencyUomId. This allows to specify a rateType in different currencies.
> > 2. Add a percentage field to the partyRate entity to charge only a percentage of the actual time spend on the task. We have many employees in training and we want only a percentage of the time to be charged on the invoice.
>

--
Antwebsystems.com: Quality OFBiz services for competitive prices

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2018) put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646129#action_12646129 ]

Jacques Le Roux commented on OFBIZ-2018:
----------------------------------------

Hans,

Forget it, our comments crossed on the wire ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-2018) put currency currencyUomIdfield in the primary key of the RateType entity and add percentage field inthe partyRate entity

Administrator

In reply to this post by hans_bakker

Did not look into details, but for instance you want to charge only for a percentage in some case (that one of your other
requriements), it's also a rate, isn'it ?
BTW I just had a look at RateType and in this case rateTypeId would be DISCOUNTED. We can imagine other uses of rate, any type of
percentage is also a rate (survey, quality, etc.). Or I'm wrong and it should be always used with currency in mind ? Anyway it's too
late here, no more imagination.

Jacques

From: "Hans Bakker" <[hidden email]>

> Can you give an example of a usage not involving currency?
>
>
> On Sun, 2008-11-09 at 15:12 -0800, Jacques Le Roux (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646128#action_12646128 ]
>>
>> Jacques Le Roux commented on OFBIZ-2018:
>> ----------------------------------------
>>
>> Hans,
>>
>> Why would you want to change from rateUomId to rateCurrencyUomId ? Are we sure that a rate would ever be for a currency ? It
>> seems tome that here a rate concept is more general and open.
>>
>>
>> > put currency currencyUomId field in the primary key of the RateType entity and add percentage field in the partyRate entity
>> > ---------------------------------------------------------------------------------------------------------------------------
>> >
>> > Key: OFBIZ-2018
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-2018
>> > Project: OFBiz
>> > Issue Type: Improvement
>> > Components: specialpurpose/projectmgr, workeffort
>> > Affects Versions: SVN trunk
>> > Environment: any
>> > Reporter: Hans Bakker
>> > Assignee: Hans Bakker
>> > Priority: Minor
>> > Fix For: SVN trunk
>> >
>> >
>> > Proposed are 2 changes realting to a rate:
>> > 1. move the currencyUomId field in the primary key of the Ratetype table and change the reference to the PartyRate including
>> > the rateType and currencyUomId. This allows to specify a rateType in different currencies.
>> > 2. Add a percentage field to the partyRate entity to charge only a percentage of the actual time spend on the task. We have
>> > many employees in training and we want only a percentage of the time to be charged on the invoice.
>>
> --
> Antwebsystems.com: Quality OFBiz services for competitive prices
>