[jira] Created: (OFBIZ-2103) Updating Webtool JobList to use PerformFind and FindScreenDecorator

[Nicolas Malin (Jira)]

Updating Webtool JobList to use PerformFind and FindScreenDecorator
-------------------------------------------------------------------

                 Key: OFBIZ-2103
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Bruno Busco
         Attachments: PerformFindJobList.patch

Hi,
I did some update on webtool JobList.

Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
I tryed it in a framework-only installation but it should work in a full OFBiz only.

If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment: PerformFindJobList.patch

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz only.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Description:
Hi,
I did some update on webtool JobList.

Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
I tryed it in a framework-only installation but it should work in a full OFBiz also.

If this is OK I think I will do a similar job on ServiceList.

  was:
Hi,
I did some update on webtool JobList.

Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
I tryed it in a framework-only installation but it should work in a full OFBiz only.

If this is OK I think I will do a similar job on ServiceList.

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment: PerformFindJobList.patch

In the new patch I have also removed the labels that are no longer used.
I have also tested the patch in a full ofbiz installation (not framework-only) and it is ok.

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch, PerformFindJobList.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment: WebToolsTabBar.patch

In the attached WebToolsTabBar patch I have changed the webtools application screens to use TabBars and now all screens are more UI consistent.

The Webtool Main screen is still there but now almost all tools are reachable through the Application Menu and relative TabBars.
There are few screens that have not yet been placed in the menus becaouse I am not sure where to put them.
When all screens will have found theit location in menus than the main.ftl file could be removed.

The new patch includes also the old one attached to this issue.

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch, PerformFindJobList.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659397#action_12659397 ]

David E. Jones commented on OFBIZ-2103:
---------------------------------------

Thanks for these contributions Bruno. I like the direction (using the framework tools instead of more manual coding for these screens) and I was going to commit them, but I ran into too many issues to just go for it:

1. there are a lot more changes in the patches than are described in the comments you left; I bring this up as important because as a committer you would need to be detailed in your comments in order to collaborate well with others

2. the WebToolsTabBar patch seems to include the changes from the PerformFindJobList patch, but they are presented as separate patches which makes the contribution unclear and more difficult to review

3. you changed the "main" request-map to require auth, which it should not; it is meant to not require auth to make demo usage easier and provide a starting point; this could be changed, but not without some discussion first; the main point is to be careful about what you change, especially with a large patch like this where accidental damage can be done that others may not catch for a long time (again this goes back to working with others in the community, making sure to understand what already exists before changing anything, and other aspects mentioned in the contributor and committers guides in the admin space on docs.ofbiz.org)

Thanks again for your work on this, and keep going since these are valuable contributions and it's great to see your involvement with the community.

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch, PerformFindJobList.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659400#action_12659400 ]

Bruno Busco commented on OFBIZ-2103:
------------------------------------

Many thanks David for reviewing my patch.
You are right the patch was too large and I was not too detailed with change description. I try to add more here.

The attached "WebToolsTabBar.patch" file includes the previous one "PerformFindJobList.patch" (I actually wrote this in the comment "The new patch includes also the old one attached to this issue.")

This patch is intended to update the webtools application to the latest standard patterns that are being used into OFBiz. No new features.

Detailed change description:
1 - The "JobList" screen has been renamed as "FindJob" and a standard FindScreenDecorator along with a call to a performFind service has been used. Doing this, the same previous search features are available but one. Now it is not possible to select Jobs with more than one statusId because the status checkboxes have been removed and replaced with a single StatusId drop-down. (I hope this will not harm)

2 - Columns of the FindJob results table are now sortable

3 - Several labels used to describe the removed checkboxes have been removed from WebToolsUiLabels because not used any more

4 - The "findJobs" service has been removed becouse it is not used any more.

5 - The CommonServiceDecorator has been moved to the CommonScreen.xml file

6 - The "WebtoolsMessage14" has been replaced with "WebtoolsViewPermissionError" to have a behaviour similar to all other applications (I think that the label naming pattern WebToolsMessageNN should be gradually changed to the standard WebToolsWordsOfSentence pattern)

7 - appheader.ftl application menu has been replaced with an Application Menu widget

8 - The availableServices request has been renamed to ServiceList

9 - The jobList sequest has been renamed to FindJob

10 - The serviceList request has been renamed to ServiceLog

11 - The main request authorization has been turned to true to have it consistent to all other main application pages

12 - A CommonEntityDecorator screen has been defined to be used into all entity related screens and the permission check has been moved from the entity screens to the decorator

13 - The WebToolsMenu has been deleted and all already (not yet used) TabBar menus included have been moved to Menus.xml

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch, PerformFindJobList.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment: WebToolsTabBar.patch

Patch updated against the latest trunk (there were some conflict due to recent changes to WebTools UIlabels)

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: PerformFindJobList.patch, PerformFindJobList.patch, WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment:     (was: PerformFindJobList.patch)

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660246#action_12660246 ]

Bruno Busco commented on OFBIZ-2103:
------------------------------------

PerformFindJobList.patch removed because it is included in the more recent WebToolsTabBar.patch

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment:     (was: PerformFindJobList.patch)

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660333#action_12660333 ]

Jacques Le Roux commented on OFBIZ-2103:
----------------------------------------

Hi Bruno,

Not sure why, but there are 2 instances of appheader.ftl in you patch, testing...

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660336#action_12660336 ]

Jacques Le Roux commented on OFBIZ-2103:
----------------------------------------

You removed AvailableServicesList from AvailableServicesScreens.xml but it's still used when you want to change the dispatcher and is in the Controller also
<view-map name="availableServices" type="screen" page="component://webtools/widget/AvailableServicesScreens.xml#AvailableServicesList"/>

BTW I wonder why we use this dispatcher feature (is it a filter ?) as it's always the same number of services returned. I wonder also why the partymgr is the default (did not look into details, just quick questions so far)

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660342#action_12660342 ]

Bruno Busco commented on OFBIZ-2103:
------------------------------------

Jacques,
this happens (I think) because I deleted the appheader.ftl AND the
includes folder that contains it. It is a TortoiseSVN behaviour.

Thank you for reviewing the patch.
-Bruno

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660349#action_12660349 ]

Jacques Le Roux commented on OFBIZ-2103:
----------------------------------------

Bruno,

I think you should try to delete inside Tortoise (or Eclipse).
This is also interesting to read : http://tortoisesvn.net/#node-351, that Eclipse (ie Subclipse) is not dealing with very well (to say the least)

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660349#action_12660349 ]

jacques.le.roux edited comment on OFBIZ-2103 at 1/2/09 9:36 AM:
----------------------------------------------------------------

Bruno,

I think you should try to delete inside Tortoise (or Eclipse).
This is also interesting to read : http://tortoisesvn.net/#node-351. That, Eclipse (ie Subclipse) is not dealing with very well (to say the least)

      was (Author: jacques.le.roux):
    Bruno,

I think you should try to delete inside Tortoise (or Eclipse).
This is also interesting to read : http://tortoisesvn.net/#node-351, that Eclipse (ie Subclipse) is not dealing with very well (to say the least)
 

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-2103:
-------------------------------

    Attachment: WebToolsTabBar.patch

Jacques,
you were right there was still some link to AvailableService. Now I have fixed them all and discovered there was also the jobs.ftl file that could be removed.
Please find attached an updated patch.

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660362#action_12660362 ]

Bruno Busco commented on OFBIZ-2103:
------------------------------------

There is still one of the David's comment that was not addressed:
"3. you changed the "main" request-map to require auth, which it should not; it is meant to not require auth to make demo usage easier and provide a starting point; this could be changed, but not without some discussion first;"

I think even WebApp should show the user the same login screen as all other applications. This change has been intentionally done in the patch. If someone does not agree with this than please advice and I will update the patch. In this case I need also to change the Italian message that is shown to the user because it really is without any clear sense.

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660415#action_12660415 ]

Jacques Le Roux commented on OFBIZ-2103:
----------------------------------------

On point 3 I agree with David : we should keep it open and I don't see any reasons to have a different login screen, why should it be different ?

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660416#action_12660416 ]

Bruno Busco commented on OFBIZ-2103:
------------------------------------

This means you agree with me actually! ;-)

The point is that now, if you go to http://localhost:8080/webtools and if you are not yet logged in, you see a screen that tells you should be logged in to access.
On all other applications you are directly prompted for a user/password.

With the change I did in the patch even the WebTools works in the same way (directly to login prompt).

> Updating Webtool JobList to use PerformFind and FindScreenDecorator
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-2103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2103
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>         Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch, WebToolsTabBar.patch
>
>
> Hi,
> I did some update on webtool JobList.
> Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator.
> I tryed it in a framework-only installation but it should work in a full OFBiz also.
> If this is OK I think I will do a similar job on ServiceList.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.