[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716875#action_12716875 ] Divesh Dutta edited comment on OFBIZ-2407 at 6/6/09 6:03 AM: ------------------------------------------------------------- I have reviewed and tested this patch. From the description given above, #1 and #2 are fulfilled in this patch. So this can be committed now as this does not break any funtioanlity. New patch can be submitted for #3. was (Author: diveshdut): I am have reviewed this patch. From the description given above, #1 and #2 are fulfilled in this patch. So this can be committed now as this does not break any funtioanlity. New patch can be submitted for #3. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716876#action_12716876 ] Ashish Vijaywargiya commented on OFBIZ-2407: -------------------------------------------- The updated work is done in trunk revision no. 782258. Thanks Akash Jain for your contribution. Special thanks to Divesh, Pranay & Vikas for review and discussing things with Akash. -- Ashish > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716878#action_12716878 ] Akash Jain commented on OFBIZ-2407: ----------------------------------- Thanks Ashish, Vikas, Pranay and Divesh :) Thanks and Regards -- Akash Jain > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2407: ------------------------------ Attachment: OFBIZ-2407.patch Worked on "Warning Form". Now when newEstimatedShippingCharges is greater/less than 10% of estimatedShippingCharges then shown warning form. Steps for testing :- 1) Create a sales order it should be in Approved status 2) Go to Facility -> Verify Pick, and verified the items 3) Go to Facility -> Packing, and entered the above verified orderId and depress "Weight Package Only" button. 4) Made packages and depress "Complete" button, if newEstimatedShippingCharges (calculated based on package(s) weight) is 10% grater/less than estimatedShippingCharges (which is calculated when order is created) then there will be shown "Warning Form" 5) There will be two buttons "Ship Now" and "Hold Shipment" in warning form. 6) If depress "Ship Now" button than package(s) are packed and shipment status changed from Picked to Packed and invoice status from Invoice-In_Process to Paid. 7) And if depress "Hold Shipment" button then just shown Weight Package Only screen. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717544#action_12717544 ] Ashish Vijaywargiya commented on OFBIZ-2407: -------------------------------------------- Hello Akash, I have reviewed your patch. It looks almost good. Here are my comments: 1) On the warning for we are showing: "There is much difference in shipping charges" along with two button. Isn't it good to show the old value and new value too on this form? 2) >> // chenk the differences in shippingCharges, if it is greater/less than 10% than shown warning form Improve this sentence for spelling mistake. -- Ashish > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2407: ------------------------------ Attachment: OFBIZ-2407.patch Thanks Ashish for reviewing the patch. I have done the following changes as per your suggestions and uploading the improved patch 1) Now estimatedShippingCharges and actualShippingCharges shown on warning form 2) Fixed typo > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |