[jira] Created: (OFBIZ-2560) On order view page when editing items, on clicking update items all the adjustments are duplicated.

[Nicolas Malin (Jira)]

On order view page when editing items, on clicking update items all the adjustments are duplicated.
----------------------------------------------------------------------------------------------------

                 Key: OFBIZ-2560
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Ratnesh Upadhyay
             Fix For: Release Branch 9.04, SVN trunk


Steps to regenerate the issue :-
1). Create an sales order.
2). Click on Edit Item button available in action block of order view page.
3). Click on Update Items.

Now you can see that all the adjustment are duplicated and also added/subtracted in order total.

-- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chirag Manocha updated OFBIZ-2560:
----------------------------------

    Attachment: OrderAdjustmentFix_OFBiz-2560.patch

Here is patch for fix for the problem.
Thanks to Arpit Singh Pandya and Ratnesh Upadhyay

--
Chirag Manocha

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716556#action_12716556 ]

Vikas Mayur commented on OFBIZ-2560:
------------------------------------

I reviewed the patch and I think it is done exactly it should be done to fix the issue, that is to just remove the existing adjustments from the database and add the complete new set of re-calculated adjustments back to the database.

While adding re-calculated adjustments, existing code does not acknowledge the existing adjustments and neither it update them. It just add a bunch of new adjustments which bring up the issue mentioned in the jira issue.

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716557#action_12716557 ]

Vikas Mayur commented on OFBIZ-2560:
------------------------------------

though the code can be improved a little on how the adjustments are removed

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-2560:
-------------------------------

    Attachment: OrderAdjustmentFix_OFBiz-2560.patch

Please ignore my last comments as now I did a thorough search and the older OrderAdjustment from the database was actually deleted. It was only a case of the old adjustment from the cart were not removed. This patch solves the purpose.

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch, OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716837#action_12716837 ]

Ratnesh Upadhyay commented on OFBIZ-2560:
-----------------------------------------

Vikas, I tested the fix by applying your patch but It was not solves the purpose. It removes Manually added "Shipping & Handling Charges", Manually added "Promotion" and Manually added "Sales Tax" on clicking update Items.

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch, OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2560:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch, OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2560.
--------------------------------------

    Resolution: Fixed

Thanks Chirag & Ratnesh for your contribution.
Patch is in trunk at rev 782642 & 782655 (trunk and RB9.04)

--
Ashish

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch, OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717552#action_12717552 ]

Chirag Manocha commented on OFBIZ-2560:
---------------------------------------

Also thanks to Arpit Singh Pandya for Researching and working with me on this.

--
Chirag Manocha

> On order view page when editing items, on clicking update items all the adjustments are duplicated.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2560
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2560
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Ratnesh Upadhyay
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OrderAdjustmentFix_OFBiz-2560.patch, OrderAdjustmentFix_OFBiz-2560.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on Edit Item button available in action block of order view page.
> 3). Click on Update Items.
> Now you can see that all the adjustment are duplicated and also added/subtracted in order total.
> -- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.