[jira] Created: (OFBIZ-2407) Functionality for Weight Packages Only on packing screen
Locked
12
12
[jira] Created: (OFBIZ-2407) Functionality for Weight Packages Only on packing screen
 
|
Functionality for Weight Packages Only on packing screen
-------------------------------------------------------- Key: OFBIZ-2407 URL: https://issues.apache.org/jira/browse/OFBIZ-2407 Project: OFBiz Issue Type: Sub-task Reporter: Pranay Pandey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-2407: --------------------------------- Component/s: product Fix Version/s: SVN trunk Priority: Minor (was: Major) Description: Functionality for "Weight Packages Only" option on pack order screen is to be added. # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". #* if Ship Now is pressed the system will run as normal #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. Affects Version/s: SVN trunk Summary: Functionality for "Weight Packages Only" option on pack order screen (was: Functionality for Weight Packages Only on packing screen) > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Priority: Minor > Fix For: SVN trunk > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-2407: --------------------------------- Attachment: OFBIZ-2407.patch I am uploading the patch for "Weight Package Only" . There are steps for testing # Create sales order, it should be in Approved status # Verified all order items, now shipmentId (in Picked status) and invoiceId (in INVOICE_IN_PROCESS status) will generate # Now go in pack order screen, select the order items and depress "Pack Item" button, all items will be in package(s) # Depress " Weight Package Only" button, weight package only form will open there will be field for enter weight package, dimensions, shipment package type and two buttons "Next Package" and "Complete" # Enter all fields and depress Next Package button, enter the weight and dimensions of all packages one by one, then depress "Complete" button # If new estimate shipping charges is 10% less or grater than estimate shipping charges (taken when order created) then warning form will open otherwise shipment will be packed and order will be complete and dimension will save in ShipmentPackage entity # There are warning message "There is much difference in shipping charges" and two buttons "Ship Now" and "Hold Shipment" in warning form # If depress on Ship Now button then shipment will be packed and order status will be complete and dimensions, shipment package type will be save in ShipmentPackage entity # If depress on Hold Shipment button then shipment will remains in Picked status and dimension, shipment package type will save in ShipmentPackage entity. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Mayur reassigned OFBIZ-2407: ---------------------------------- Assignee: Vikas Mayur > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705065#action_12705065 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ There is one label (EcommerceLength) that is used from ecommerce. I think we should add this label to more appropriate component, I would say to common component then it can be used in product component and other references can be changed as well. My opinion is based on the fact that it would certainly add a dependency on the special purpose component. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705033#action_12705033 ] Pranay Pandey edited comment on OFBIZ-2407 at 5/1/09 11:26 AM: --------------------------------------------------------------- This patch is from Akash Jain. Thanks. Following are the steps for testing: # Create sales order, it should be in Approved status. # Verify all order items from "Facility-->Verify Pick" screen, now shipmentId (in PICKED status) and invoiceId (in INVOICE_IN_PROCESS status) will be generated. # Now go in Pack Order screen, select the order items and depress "Pack Item" button, all items will be in package(s). # Depress "Weight Package Only" button, weight package only form will open. There will be field for entering Package weight, Dimensions, Shipment Package Type and two buttons "Next Package" and "Complete" # Enter all fields and depress Next Package button, enter the weight and dimensions of all packages one by one, then depress "Complete" button. # If new estimate shipping charges is 10% less or grater than estimate shipping charges (taken when order created) then warning form will open otherwise shipment will be packed; order will be in COMPLETED and dimensions will be saved in ShipmentPackage entity. # The warining form will show message "There is much difference in shipping charges" and two buttons "Ship Now" and "Hold Shipment". # If Ship Now button clicked then shipment will be PACKED, order status will be COMPLETED and Dimensions, Shipment Package Type will be saved in ShipmentPackage entity. # If "Hold Shipment" button is clicked then shipment will remain in PICKED status and Dimensions, Shipment Package type will saved in ShipmentPackage entity. was (Author: pandeypranay): I am uploading the patch for "Weight Package Only" . There are steps for testing # Create sales order, it should be in Approved status # Verified all order items, now shipmentId (in Picked status) and invoiceId (in INVOICE_IN_PROCESS status) will generate # Now go in pack order screen, select the order items and depress "Pack Item" button, all items will be in package(s) # Depress " Weight Package Only" button, weight package only form will open there will be field for enter weight package, dimensions, shipment package type and two buttons "Next Package" and "Complete" # Enter all fields and depress Next Package button, enter the weight and dimensions of all packages one by one, then depress "Complete" button # If new estimate shipping charges is 10% less or grater than estimate shipping charges (taken when order created) then warning form will open otherwise shipment will be packed and order will be complete and dimension will save in ShipmentPackage entity # There are warning message "There is much difference in shipping charges" and two buttons "Ship Now" and "Hold Shipment" in warning form # If depress on Ship Now button then shipment will be packed and order status will be complete and dimensions, shipment package type will be save in ShipmentPackage entity # If depress on Hold Shipment button then shipment will remains in Picked status and dimension, shipment package type will save in ShipmentPackage entity. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705214#action_12705214 ] Ashish Vijaywargiya commented on OFBIZ-2407: -------------------------------------------- >> My opinion is based on the fact that it would certainly add a dependency on the special purpose component. Infact, this will. This is bad practice to have dependency of applications component on specialpurpose component and we should avoid it. +1 for adding this on Common component and let's use it from there. (if it don't exists there) Thanks ! -- Ashish Vijaywargiya > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705253#action_12705253 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ Hi Akash, I seen few issues while doing a walk through 1) UOM for Length, Width and Height are not mentioned. You could mention the UOM along with the labels like it is done for Weight. 2) Since a box dimensions are mentioned in ShipmentBoxType, I think user should be given a choice to either enter (Lenght, Width and Height) or just selects Shipment Box Type. I see both are optional but at a time only one should be required. If user enter values in both then a sort of warning message should be displayed so that user can do the correction to his selection. 3) When the last package is reached, we should not display Next Package link, IMO. 4) Their is no option to go back and redo changes in the packages in this screen. It would be nice to have a Previous Package link to facilitate this. If this available in any other screen we can use that to edit the packages, but this option adds flexibility and enhance the usability of the screen. 5) Complete button should be replaced with some meaningful names or better use a simplified version of the screen which describes only this work flow. Vikas > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2407: ------------------------------ Attachment: OFBIZ-2407.patch Thanks Ashish and Vikas for your valuable suggestion I have made new UiLabel for length (CommonLength) Vikas I have implemented all the new functionality improvement as per your suggestions 1) Defined the unit of measurement of dimension (length, width and height) 2) Applied server side validation, now user can select either Dimension or Shipment Box Type 3) Now only weightPackageForm will appear when depress "Weight Package Only" button. 4) Now "Complete " button will be shown only when weight and dimensions are entered for all the packages and no other package remains 5) Made an editable list form, and an add form below it. To add a new package use the add form at the bottom. To change any of the packages just edit it in the list form and submit. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2407: ------------------------------ Attachment: OFBIZ-2407.patch Minor changes in condition in PackOrder.ftl which are missed in previous patch. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709781#action_12709781 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ Thanks Akash, Few more suggestions on the code. {code} + if (UtilValidate.isNotEmpty(packageLength)) { + if (UtilValidate.isEmpty(packageWidth) || UtilValidate.isEmpty(packageHeight)) { + session.setDimensionAndShipmentBoxType(packageSeqId); + return ServiceUtil.returnError(UtilProperties.getMessage("ProductErrorUiLabels", "ProductErrorNotEnteredAllFieldsInDimension", locale)); + } else if (UtilValidate.isNotEmpty(shipmentBoxTypeId)) { + session.setDimensionAndShipmentBoxType(packageSeqId); + return ServiceUtil.returnError(UtilProperties.getMessage("ProductErrorUiLabels", "ProductErrorEnteredBothDimensionAndPackageInputBoxField", locale)); + } + } else if (UtilValidate.isNotEmpty(packageWidth) || UtilValidate.isNotEmpty(packageHeight)) { + session.setDimensionAndShipmentBoxType(packageSeqId); + return ServiceUtil.returnError(UtilProperties.getMessage("ProductErrorUiLabels", "ProductErrorNotEnteredAllFieldsInDimension", locale)); + } {code} can be simplified with {code} if (length || width || height) { // Check if user enter any of the dimensions if (boxType) { // check if user also enter box // ERROR: Entered Dimension and Package input box, both the fields cannot be processed together } else if (!(lenght && width && height)) { // check if user does not enter all the dimensions // ERROR: Not entered all fields (length, width and height) in Dimension } } {code} > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709782#action_12709782 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ Use the title attribute in {code} + <relation type="one" fk-name="FAC_DEF_DUOM" rel-entity-name="Uom"> + <key-map field-name="defaultDimensionUomId" rel-field-name="uomId"/> + </relation> + <relation type="one" fk-name="FAC_DEF_WUOM" rel-entity-name="Uom"> {code} > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709783#action_12709783 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ Why not use the complete variable name so that code is more readable where this boolean is used. Boolean force = (Boolean) context.get("forceComplete"); > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2407: ------------------------------ Attachment: OFBIZ-2407.patch Thanks Vikas for your comments. I have done the following changes as per your suggestion 1) Simplified "if"condition in PackingServices.java 2) Added "title" attribute in relation. 3) Changed the name of variable force -> complete 4) Changed the key dimensionSaveInSession -> dimensionSavedInSession in PackingServices.java > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709830#action_12709830 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ Thanks Akash, Your patch is in trunk rev. 775128 excluding only framework/common/config/CommonUiLabels.xml This would need framework rights, so keeping this issue opened. Vikas > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709833#action_12709833 ] Akash Jain commented on OFBIZ-2407: ----------------------------------- Thanks Vikas :) Regards -- Akash Jain > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2407. ---------------------------------- Resolution: Fixed Thanks, Pranay, Vikas, Akash, I commited CommonUiLabels.xml at r775180 > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709869#action_12709869 ] Vikas Mayur commented on OFBIZ-2407: ------------------------------------ Thank you, Jacques! > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-2407: ------------------------------ Attachment: OFBIZ-2407.patch As weight package screen was reverted few days back, again introducing weight package only screen with following functionalities: 1) Now user can weigh packages and enter dimensions with weight package only screen only when he has gone through "Verify Pick" process 2) Now "pack process" and "weight package only process" are independent of each other Steps to test: 1) Create a sales order, should be in approved status. 2) Follow "Verify Pick" process, and then go to facility -> packing. 3) There will be two buttons, depress "Weight Package Only" 4) Now enter the weights and dimensions/shipmentBoxType of the package. 5) Remember that number of packages can not be more than the number of ordered quantity 6) Finally click on "Complete" button, order will be get completed > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2407) Functionality for "Weight Packages Only" option on pack order screen
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716875#action_12716875 ] Divesh Dutta commented on OFBIZ-2407: ------------------------------------- I am have reviewed this patch. From the description given above, #1 and #2 are fulfilled in this patch. So this can be committed now as this does not break any funtioanlity. New patch can be submitted for #3. > Functionality for "Weight Packages Only" option on pack order screen > --------------------------------------------------------------------- > > Key: OFBIZ-2407 > URL: https://issues.apache.org/jira/browse/OFBIZ-2407 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: SVN trunk > Reporter: Pranay Pandey > Assignee: Vikas Mayur > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch, OFBIZ-2407.patch > > > Functionality for "Weight Packages Only" option on pack order screen is to be added. > # In Facility -> Packing screens when the order entered already has a Shipment that exists in the Picked status: add a "Weight Packages Only" button. > # When user clicks on "Weight Packages Only" show a form with Weight input box, optional dimension input boxes (length, width, height), optional drop-down for pre-configured boxes (using data from ShipmentBoxType entity and two buttons: "Next Package" and "Complete" . > # When the "Complete" button is pressed if the shipping charge is 10%(configure in shipment.properties file, use property name "shipment.default.cost.actual_over_estimated_percent_allowed") above the estimated amount (the amount that would be charged to the customer). > #* The system will warn user that the shipping amount is too much there will be a warning form with two buttons: "Ship Now" and "Hold Shipment". > #* if Ship Now is pressed the system will run as normal > #* if Hold Shipment is pressed the Shipment will remain in the Picked status, weight/size changes will be retained, no other changes made. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |