Exception on checkout with apostrophe in address
------------------------------------------------ Key: OFBIZ-248 URL: http://issues.apache.org/jira/browse/OFBIZ-248 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: order Reporter: Jacopo Cappellato Priority: Minor Copy of an old issue from Ray Barlow: Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. You can see from this extract of the exception the cause of the problem: WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') Exception: 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot al, triggered by rule on Service: storeOrder 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a chained request. 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU ri=checkBlacklist nextView=null 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist 179838[ CheckOutHelper.java:955:ERROR] ---- exception report ---------------------------------------------------------- Problems with OrderBlacklist lookup. Exception: org.ofbiz.entity.GenericDataSourceException Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) ---- stack trace --------------------------------------------------------------- org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY PE_ID = ?))]) org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: 747) org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 9) org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 53) org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 88) sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) All Comments Work Log Change History Sort Order: [navigator.ascending.order] Comment by Guy Gershoni [05/Aug/05 11:28 AM] [ Permlink ] Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=all ]
Jacopo Cappellato updated OFBIZ-248: ------------------------------------ Attachment: patch.patch Copied from the old issue. > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > Attachments: patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=comments#action_12434412 ]
David E. Jones commented on OFBIZ-248: -------------------------------------- This patch appears to just replace a single ['] (single quote) with two single quote characters. Does that actually fix the problem? I haven't tested it, but it seems a little funny... > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > Attachments: patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=comments#action_12435317 ]
Jacques Le Roux commented on OFBIZ-248: --------------------------------------- I think that this http://lists.ofbiz.org/pipermail/users/2006-April/011600.html is related > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Priority: Minor > Attachments: patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=all ]
Jacques Le Roux reassigned OFBIZ-248: ------------------------------------- Assignee: Jacques Le Roux > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=comments#action_12435581 ]
Jacques Le Roux commented on OFBIZ-248: --------------------------------------- Here is the comments from http://jira.undersunconsulting.com/browse/OFBIZ-869 where tha above link was taken When I try to put quotation marks in, say, the Product Name for my product, everything starting with first quotation mark is silently chopped off. According to David, this is probably an HTML rendering thing, since these are not currently being escaped in the default templates. It would be best if they were - there are other characters, and administrators (often "mere mortals") should not be asked to use escape characters in their names. A pass through the front-end applications to catch any of these strings that aren't currently being escaped would be in order. Also, David suggested supplying a service that can replace the HTML-escaped characters that people may currently have in their DBs to work around this issue. That would probably be good to include while committing a fix for this issue. Commentaire de la part de Benjamin Cox [30/avr./06 07:20 AM] The conversation alluded to in the description above took place on the mailing list at http://lists.ofbiz.org/pipermail/users/2006-April/011600.html Commentaire de la part de Benjamin Cox [30/avr./06 07:33 AM] Just to clarify, it's not the ecommerce templates that need this, it's the catalog templates. The first time you put it in, it shows up on the ecommerce side without a hitch. However, if you go to the product's Content page it's chopped off in the form field. If you click Update without typing those words in again, that's how they get erased from the field. > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=all ]
Jacques Le Roux updated OFBIZ-248: ---------------------------------- Attachment: checkOrderBlacklist.patch This patch fix the problem reported by Ray (Ray's was too old and missing a line). BTW CheckOutHelper.checkOrderBlacklist returns "OrderFailed" to CheckOutEvents.checkOrderBlacklist which in turn returns "errorMessage" but finally order is approved !? I tried to replace ServiceUtil.returnError by ServiceUtil.returnFailure in checkOrderBlacklist (CheckOutHelper.java) but I got a blank page and stopped my investigations. It seems that this part of code is obsolete ? Nevertheless I'll apply this patch soon if nobody complains. > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: checkOrderBlacklist.patch, patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=comments#action_12460901 ]
Jacques Le Roux commented on OFBIZ-248: --------------------------------------- I forgot to say that I fixed the problem reported by Benjamin Cox in rev. 490368. The solution was given by David in http://lists.ofbiz.org/pipermail/users/2006-April/011601.html > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: checkOrderBlacklist.patch, patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-248?page=all ]
Jacques Le Roux closed OFBIZ-248. --------------------------------- Fix Version/s: SVN trunk Resolution: Fixed Fixed in revision: 491221 > Exception on checkout with apostrophe in address > ------------------------------------------------ > > Key: OFBIZ-248 > URL: http://issues.apache.org/jira/browse/OFBIZ-248 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Reporter: Jacopo Cappellato > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: checkOrderBlacklist.patch, patch.patch > > > Copy of an old issue from Ray Barlow: > Create an order that contains an apostrophe in address line 1 i.e. "Gardener's Cottage" > The exception below is thrown during the order creation stage of checkout, the order is created and no error is visible to the customer, but blacklist check is failing. > You can see from this extract of the exception the cause of the problem: > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') > Exception: > 179768[ ServiceEcaRule.java:122:INFO ] Running Service ECA Service: resetGrandTot > al, triggered by rule on Service: storeOrder > 179808[ RequestHandler.java:297:INFO ] [RequestHandler.doRequest]: Response is a > chained request. > 179808[ RequestHandler.java:116:INFO ] [RequestHandler]: Chain in place: requestU > ri=checkBlacklist nextView=null > 179818[ RequestHandler.java:199:INFO ] [Processing Request]: checkBlacklist > 179838[ CheckOutHelper.java:955:ERROR] > ---- exception report ---------------------------------------------------------- > Problems with OrderBlacklist lookup. > Exception: org.ofbiz.entity.GenericDataSourceException > Message: SQL Exception while executing the following:SELECT BLACKLIST_STRING, ORDER_B > LACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_T > X_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COT > TAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpected token in statement [SELECT BLACK > LIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREA > TED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('blacklistString') = U > PPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?))]) > ---- stack trace --------------------------------------------------------------- > org.ofbiz.entity.GenericDataSourceException: SQL Exception while executing the follow > ing:SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATE > D_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST WHERE ((UPPER('black > listString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TYPE_ID = ?)) (Unexpec > ted token in statement [SELECT BLACKLIST_STRING, ORDER_BLACKLIST_TYPE_ID, LAST_UPDATE > D_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM ORDER_BLACKLIST > WHERE ((UPPER('blacklistString') = UPPER('GARDENER'S COTTAGE') AND ORDER_BLACKLIST_TY > PE_ID = ?))]) > org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:386) > org.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java: > 747) > org.ofbiz.entity.datasource.GenericDAO.selectByCondition(GenericDAO.java:618) > org.ofbiz.entity.datasource.GenericHelperDAO.findByCondition(GenericHelperDAO.java:16 > 9) > org.ofbiz.entity.GenericDelegator.findByCondition(GenericDelegator.java:1016) > org.ofbiz.entity.GenericDelegator.findByOr(GenericDelegator.java:967) > org.ofbiz.order.shoppingcart.CheckOutHelper.checkOrderBlacklist(CheckOutHelper.java:9 > 53) > org.ofbiz.order.shoppingcart.CheckOutEvents.checkOrderBlacklist(CheckOutEvents.java:4 > 88) > sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > All Comments Work Log Change History Sort Order: [navigator.ascending.order] > Comment by Guy Gershoni [05/Aug/05 11:28 AM] > [ Permlink ] > Please note that the attached diff files are based on svn release 5458. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |